Patchwork [3/3] UBUNTU: Add the linux-tools package to TI OMAP4

login
register
mail settings
Submitter Bryan Wu
Date Jan. 24, 2011, 2:50 a.m.
Message ID <1295837418-3884-4-git-send-email-bryan.wu@canonical.com>
Download mbox | patch
Permalink /patch/80085/
State Accepted
Delegated to: Tim Gardner
Headers show

Comments

Bryan Wu - Jan. 24, 2011, 2:50 a.m.
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 meta-source/debian/control.common |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
Stefan Bader - Jan. 24, 2011, 9:22 a.m.
On 01/24/2011 03:50 AM, Bryan Wu wrote:
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
>  meta-source/debian/control.common |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/meta-source/debian/control.common b/meta-source/debian/control.common
> index d8b7f12..be7ad0c 100644
> --- a/meta-source/debian/control.common
> +++ b/meta-source/debian/control.common
> @@ -5,3 +5,11 @@ Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
>  Standards-Version: 3.6.1
>  Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
>  Vcs-Git: http://kernel.ubuntu.com/git-repos/ubuntu/ubuntu-maverick-meta.git
> +

Ok, in general. But I find the naming scheme not too intuitive:
> +Package: linux-tools-omap4
                        ^ no ti-
> +Architecture: armel
> +Section: metapackages
> +Depends: ${misc:Depends}, linux-ti-omap4-tools-${kernel-abi-version}
                                   ^ with ti- and why not
				   linux-tools-(ti-)omap4-...
> +Description: Linux kernel versioned Tools
> + This package will always depend on the latest Linux kernel versioned tools
> + available. The Ubuntu patches have been applied.
Andy Whitcroft - Jan. 24, 2011, 1:58 p.m.
On Mon, Jan 24, 2011 at 10:22:37AM +0100, Stefan Bader wrote:
> On 01/24/2011 03:50 AM, Bryan Wu wrote:
> > Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> > ---
> >  meta-source/debian/control.common |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> > 
> > diff --git a/meta-source/debian/control.common b/meta-source/debian/control.common
> > index d8b7f12..be7ad0c 100644
> > --- a/meta-source/debian/control.common
> > +++ b/meta-source/debian/control.common
> > @@ -5,3 +5,11 @@ Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
> >  Standards-Version: 3.6.1
> >  Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
> >  Vcs-Git: http://kernel.ubuntu.com/git-repos/ubuntu/ubuntu-maverick-meta.git
> > +
> 
> Ok, in general. But I find the naming scheme not too intuitive:
> > +Package: linux-tools-omap4
>                         ^ no ti-
> > +Architecture: armel
> > +Section: metapackages
> > +Depends: ${misc:Depends}, linux-ti-omap4-tools-${kernel-abi-version}
>                                    ^ with ti- and why not
> 				   linux-tools-(ti-)omap4-...
> > +Description: Linux kernel versioned Tools
> > + This package will always depend on the latest Linux kernel versioned tools
> > + available. The Ubuntu patches have been applied.

This is because where we put names at the right hand end they are
flavour names.  And for better or worse the flavour name here is omap4
and not ti-omap4.

-apw
Stefan Bader - Jan. 24, 2011, 3:23 p.m.
On 01/24/2011 02:58 PM, Andy Whitcroft wrote:
> On Mon, Jan 24, 2011 at 10:22:37AM +0100, Stefan Bader wrote:
>> On 01/24/2011 03:50 AM, Bryan Wu wrote:
>>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
>>> ---
>>>  meta-source/debian/control.common |    8 ++++++++
>>>  1 files changed, 8 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta-source/debian/control.common b/meta-source/debian/control.common
>>> index d8b7f12..be7ad0c 100644
>>> --- a/meta-source/debian/control.common
>>> +++ b/meta-source/debian/control.common
>>> @@ -5,3 +5,11 @@ Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
>>>  Standards-Version: 3.6.1
>>>  Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
>>>  Vcs-Git: http://kernel.ubuntu.com/git-repos/ubuntu/ubuntu-maverick-meta.git
>>> +
>>
>> Ok, in general. But I find the naming scheme not too intuitive:
>>> +Package: linux-tools-omap4
>>                         ^ no ti-
>>> +Architecture: armel
>>> +Section: metapackages
>>> +Depends: ${misc:Depends}, linux-ti-omap4-tools-${kernel-abi-version}
>>                                    ^ with ti- and why not
>> 				   linux-tools-(ti-)omap4-...
>>> +Description: Linux kernel versioned Tools
>>> + This package will always depend on the latest Linux kernel versioned tools
>>> + available. The Ubuntu patches have been applied.
> 
> This is because where we put names at the right hand end they are
> flavour names.  And for better or worse the flavour name here is omap4
> and not ti-omap4.
> 
> -apw
Yeah, I was more targetting the linux-ti-omap-tools name of the binary which
seemed to be odd. I thought we otherwise had been using
linux-tools-<flavour>-... but I may be remembering incorrectly.

-Stefan
Andy Whitcroft - Jan. 25, 2011, 8:51 a.m.
On Mon, Jan 24, 2011 at 04:23:36PM +0100, Stefan Bader wrote:
> On 01/24/2011 02:58 PM, Andy Whitcroft wrote:
> > On Mon, Jan 24, 2011 at 10:22:37AM +0100, Stefan Bader wrote:
> >> On 01/24/2011 03:50 AM, Bryan Wu wrote:
> >>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> >>> ---
> >>>  meta-source/debian/control.common |    8 ++++++++
> >>>  1 files changed, 8 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/meta-source/debian/control.common b/meta-source/debian/control.common
> >>> index d8b7f12..be7ad0c 100644
> >>> --- a/meta-source/debian/control.common
> >>> +++ b/meta-source/debian/control.common
> >>> @@ -5,3 +5,11 @@ Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
> >>>  Standards-Version: 3.6.1
> >>>  Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
> >>>  Vcs-Git: http://kernel.ubuntu.com/git-repos/ubuntu/ubuntu-maverick-meta.git
> >>> +
> >>
> >> Ok, in general. But I find the naming scheme not too intuitive:
> >>> +Package: linux-tools-omap4
> >>                         ^ no ti-
> >>> +Architecture: armel
> >>> +Section: metapackages
> >>> +Depends: ${misc:Depends}, linux-ti-omap4-tools-${kernel-abi-version}
> >>                                    ^ with ti- and why not
> >> 				   linux-tools-(ti-)omap4-...
> >>> +Description: Linux kernel versioned Tools
> >>> + This package will always depend on the latest Linux kernel versioned tools
> >>> + available. The Ubuntu patches have been applied.
> > 
> > This is because where we put names at the right hand end they are
> > flavour names.  And for better or worse the flavour name here is omap4
> > and not ti-omap4.
> > 
> > -apw
> Yeah, I was more targetting the linux-ti-omap-tools name of the binary which
> seemed to be odd. I thought we otherwise had been using
> linux-tools-<flavour>-... but I may be remembering incorrectly.

Currently in implementation the tools are actually architecture
specific.  Unfortuantly we only have linux-* and linux-*-flavour meta
package name spaces.  The linux-tools name already points to that coming
from the master branch.  That leaves us with only the flavour
specific name available for the ti-omap4 case.  In practice we likely
should have used -flavour for all of tools just in case flavour specific
tools come along in the future, but we have already missed that boat.

-apw

Patch

diff --git a/meta-source/debian/control.common b/meta-source/debian/control.common
index d8b7f12..be7ad0c 100644
--- a/meta-source/debian/control.common
+++ b/meta-source/debian/control.common
@@ -5,3 +5,11 @@  Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
 Standards-Version: 3.6.1
 Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
 Vcs-Git: http://kernel.ubuntu.com/git-repos/ubuntu/ubuntu-maverick-meta.git
+
+Package: linux-tools-omap4
+Architecture: armel
+Section: metapackages
+Depends: ${misc:Depends}, linux-ti-omap4-tools-${kernel-abi-version}
+Description: Linux kernel versioned Tools
+ This package will always depend on the latest Linux kernel versioned tools
+ available. The Ubuntu patches have been applied.