| Message ID | alpine.LNX.2.00.1101232315230.30955@swampdragon.chaosbits.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jesper Juhl <jj@chaosbits.net> Date: Sun, 23 Jan 2011 23:19:55 +0100 (CET) > We will leak the storage allocated by request_firmware() if the size of > the firmware is greater than KAWETH_FIRMWARE_BUF_SIZE. > This removes the leak by calling release_firmware() before we return > -ENOSPC. > > Signed-off-by: Jesper Juhl <jj@chaosbits.net> Applied, thanks Jesper. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 5e98643..7dc8497 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -406,6 +406,7 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth, if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) { err("Firmware too big: %zu", fw->size); + release_firmware(fw); return -ENOSPC; } data_len = fw->size;
We will leak the storage allocated by request_firmware() if the size of the firmware is greater than KAWETH_FIRMWARE_BUF_SIZE. This removes the leak by calling release_firmware() before we return -ENOSPC. Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- kaweth.c | 1 + 1 file changed, 1 insertion(+) Compile tested only since I do not have the hardware.