From patchwork Sun Jan 23 21:54:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 80079 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A5ABC1007D1 for ; Mon, 24 Jan 2011 08:54:40 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248Ab1AWVyj (ORCPT ); Sun, 23 Jan 2011 16:54:39 -0500 Received: from pfepb.post.tele.dk ([195.41.46.236]:53843 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204Ab1AWVyj (ORCPT ); Sun, 23 Jan 2011 16:54:39 -0500 Received: from merkur.ravnborg.org (x1-6-00-1e-2a-84-ae-3e.k225.webspeed.dk [80.163.61.94]) by pfepb.post.tele.dk (Postfix) with ESMTP id 5EAFAF84016; Sun, 23 Jan 2011 22:54:38 +0100 (CET) Date: Sun, 23 Jan 2011 22:54:38 +0100 From: Sam Ravnborg To: sparclinux , David Miller Subject: Re: [RFC PATCH 0/7] sparc32: cleanup irq + smp files Message-ID: <20110123215438.GA28153@merkur.ravnborg.org> References: <20110123213940.GA15063@merkur.ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110123213940.GA15063@merkur.ravnborg.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org On Sun, Jan 23, 2011 at 10:39:40PM +0100, Sam Ravnborg wrote: > I am slowly working towards the goal of migrating > sparc32 to genirq. > PArt of the job is to understand the current code-base. > While reading the code I was constantly distracted > by all the minor issues in these. > > So I cooked up a few patches to clean up the files. The patches survied my SPARCclassic config and defconfig. But allnoconfig bails out with an error. This is because asm-generic/tlb.h require linux/pagemap.h. The include happended implicitly before. Workaround is simple - see below. I will try to get it fixed in asm-generic for benefit of all users. Sam --- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/sparc/include/asm/tlb_32.h b/arch/sparc/include/asm/tlb_32.h index 6d02d1c..d29b2ea 100644 --- a/arch/sparc/include/asm/tlb_32.h +++ b/arch/sparc/include/asm/tlb_32.h @@ -1,6 +1,8 @@ #ifndef _SPARC_TLB_H #define _SPARC_TLB_H +#include + #define tlb_start_vma(tlb, vma) \ do { \ flush_cache_range(vma, vma->vm_start, vma->vm_end); \