[sparc-next:master,2/7] arch/sparc/kernel/head_64.S:892: Warning: .space or .fill with negative value, ignored

Submitted by Nitin Gupta on Aug. 11, 2017, 11:04 p.m.

Details

Message ID 4bca1e76-e702-45de-ad89-e1840d9b6884@oracle.com
State RFC
Delegated to: David Miller
Headers show

Commit Message

Nitin Gupta Aug. 11, 2017, 11:04 p.m.
On 8/10/17 9:09 PM, Anthony Yznaga wrote:
> 
>> On Aug 10, 2017, at 9:39 AM, David Miller <davem@davemloft.net> wrote:
>>
>> From: kbuild test robot <fengguang.wu@intel.com>
>> Date: Thu, 10 Aug 2017 14:16:16 +0800
>>
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next.git master
>>> head:   5389e239eba5ef0e1cad596dba4860890a3e6965
>>> commit: f10bb00790dd3cf550f7ae6991c4d1a128802c00 [2/7] sparc64: Add 16GB hugepage support
>>
>> Nitin, there's too much code now in head.S and the size of the initial
>> block of assembler trap handler overflows the allowed size before this
>> .skip directive which aligns things.
>>
>> Unfortunately, I'm going to revert your changes and you'll have to
>> find a way to fix this.  I did complain how huge the TSB miss page
>> table walk is getting, and I wasn't kidding ;-)
> 
> A big chunk of space can be freed up by moving the include of hvcall.S to after the trap table.
> 

Thanks Anthony for the tip. I will be merging the following patch with
16GB hugepage patch and resending for review. I hope following is okay:



--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/arch/sparc/kernel/head_64.S b/arch/sparc/kernel/head_64.S
index 78e0211..6986d07 100644
--- a/arch/sparc/kernel/head_64.S
+++ b/arch/sparc/kernel/head_64.S
@@ -881,7 +881,6 @@  sparc64_boot_end:
 #include "misctrap.S"
 #include "syscalls.S"
 #include "helpers.S"
-#include "hvcalls.S"
 #include "sun4v_tlb_miss.S"
 #include "sun4v_ivec.S"
 #include "ktlb.S"
@@ -926,6 +925,7 @@  swapper_4m_tsb:

 ! 0x0000000000428000

+#include "hvcalls.S"
 #include "systbls_64.S"

        .data