From patchwork Sun Jan 23 21:41:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [7/7] sparc32, sun4d: add comment in empty statement in sun4d_request_irq() Date: Sun, 23 Jan 2011 11:41:10 -0000 From: Sam Ravnborg X-Patchwork-Id: 80076 Message-Id: <1295818870-25450-7-git-send-email-sam@ravnborg.org> To: "David S. Miller" Cc: sparclinux , Sam Ravnborg This looked like a bug to me. Add a comment so next reader is hopefully less confused. Signed-off-by: Sam Ravnborg --- arch/sparc/kernel/sun4d_irq.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/sparc/kernel/sun4d_irq.c b/arch/sparc/kernel/sun4d_irq.c index 6db2fba..fbcbada 100644 --- a/arch/sparc/kernel/sun4d_irq.c +++ b/arch/sparc/kernel/sun4d_irq.c @@ -307,7 +307,8 @@ int sun4d_request_irq(unsigned int irq, if (action) { if ((action->flags & IRQF_SHARED) && (irqflags & IRQF_SHARED)) { - for (tmp = action; tmp->next; tmp = tmp->next); + for (tmp = action; tmp->next; tmp = tmp->next) + /* find last entry - tmp used below */; } else { ret = -EBUSY; goto out_unlock;