[ovs-dev,0/7] Add offload support for ip ttl and tcp flags

Message ID CAPWQB7GvwimSmVr2kFjvv6Y5Qo=GEsr6SV1hQhzGbu2VABMVWg@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Joe Stringer Aug. 11, 2017, 6:43 p.m.
On 8 August 2017 at 01:03, Simon Horman <simon.horman@netronome.com> wrote:
> On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote:
>> Hi,
>>
>> This series adds support for offloading ip ttl and tcp flags
>> using tc interface.
>
> This looks nice, thanks.
>
> Acked-by: Simon Horman <simon.horman@netronome.com>
>
> I'm also happy to apply this if someone else provides a review.

Thanks folks, I'll apply the series to master soon with Simon's acks
and the following style fixup.

 static const struct nl_policy tunnel_key_policy[] = {

Comments

Simon Horman Aug. 14, 2017, 8:36 a.m. | #1
On Fri, Aug 11, 2017 at 11:43:23AM -0700, Joe Stringer wrote:
> On 8 August 2017 at 01:03, Simon Horman <simon.horman@netronome.com> wrote:
> > On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote:
> >> Hi,
> >>
> >> This series adds support for offloading ip ttl and tcp flags
> >> using tc interface.
> >
> > This looks nice, thanks.
> >
> > Acked-by: Simon Horman <simon.horman@netronome.com>
> >
> > I'm also happy to apply this if someone else provides a review.
> 
> Thanks folks, I'll apply the series to master soon with Simon's acks
> and the following style fixup.

Thanks.

> diff --git a/lib/tc.c b/lib/tc.c
> index bf12a5bea494..c9cada249de3 100644
> --- a/lib/tc.c
> +++ b/lib/tc.c
> @@ -363,7 +363,6 @@ nl_parse_flower_ip(struct nlattr **attrs, struct
> tc_flower *flower) {
>          key->ip_ttl = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_IP_TTL]);
>          mask->ip_ttl = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_IP_TTL_MASK]);
>      }
> -
>  }
> 
>  static const struct nl_policy tunnel_key_policy[] = {

Patch

diff --git a/lib/tc.c b/lib/tc.c
index bf12a5bea494..c9cada249de3 100644
--- a/lib/tc.c
+++ b/lib/tc.c
@@ -363,7 +363,6 @@  nl_parse_flower_ip(struct nlattr **attrs, struct
tc_flower *flower) {
         key->ip_ttl = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_IP_TTL]);
         mask->ip_ttl = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_IP_TTL_MASK]);
     }
-
 }