From patchwork Fri Aug 11 16:56:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 800662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="Hb3NEQF3"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Hb3NEQF3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xTWQT5Hg5z9t2v for ; Sat, 12 Aug 2017 02:57:37 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbdHKQ4t (ORCPT ); Fri, 11 Aug 2017 12:56:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41080 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbdHKQ4q (ORCPT ); Fri, 11 Aug 2017 12:56:46 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 62EFA6031A; Fri, 11 Aug 2017 16:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1502470606; bh=su7nVKgaDxBU3flFXCFxvXXr2eZQ6SK3xFnGcSFtp3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hb3NEQF3B/6IqtEG8Uz3zgCu59JrrHW9SQpxB8vgvii9E/+5AidhFt3zROn6ErHLz PrwU0BT1BwH5K6XrIc1UhHXUqsKYnJUfUMKweYkmWuYzPcs7cQsw+EsghqVovArSq8 V0GhixNmnGT8DjbWoamdCwfgDA+PBuRnuxN7ZBF0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 33D97602BE; Fri, 11 Aug 2017 16:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1502470606; bh=su7nVKgaDxBU3flFXCFxvXXr2eZQ6SK3xFnGcSFtp3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hb3NEQF3B/6IqtEG8Uz3zgCu59JrrHW9SQpxB8vgvii9E/+5AidhFt3zROn6ErHLz PrwU0BT1BwH5K6XrIc1UhHXUqsKYnJUfUMKweYkmWuYzPcs7cQsw+EsghqVovArSq8 V0GhixNmnGT8DjbWoamdCwfgDA+PBuRnuxN7ZBF0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 33D97602BE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, timur@codeaurora.org, alex.williamson@redhat.com Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya , Bjorn Helgaas , linux-kernel@vger.kernel.org Subject: [PATCH V10 3/3] PCI: display not responding message while device is unreachable Date: Fri, 11 Aug 2017 12:56:36 -0400 Message-Id: <1502470596-4112-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1502470596-4112-1-git-send-email-okaya@codeaurora.org> References: <1502470596-4112-1-git-send-email-okaya@codeaurora.org> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Adding a print statement into pci_bus_wait_crs() so that user observes the progress of device polling instead of silently waiting for timeout to be reached. Signed-off-by: Sinan Kaya --- drivers/pci/probe.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index b1cb7bd..2f4cf7d 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1839,11 +1839,17 @@ bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 *l, int crs_timeout) delay *= 2; if (pci_bus_read_config_dword(bus, devfn, PCI_VENDOR_ID, l)) return false; + + if (delay >= 1000) + pr_info("pci %04x:%02x:%02x.%d: not responding since %dms still polling\n", + pci_domain_nr(bus), bus->number, + PCI_SLOT(devfn), PCI_FUNC(devfn), delay); + /* Card hasn't responded in 60 seconds? Must be stuck. */ if (delay > crs_timeout) { - printk(KERN_WARNING "pci %04x:%02x:%02x.%d: not responding\n", + pr_warn("pci %04x:%02x:%02x.%d: not responding %dms timeout reached\n", pci_domain_nr(bus), bus->number, PCI_SLOT(devfn), - PCI_FUNC(devfn)); + PCI_FUNC(devfn), crs_timeout); return false; } } while ((*l & 0xffff) == 0x0001);