[PULL,0/7] Block/Multiboot patches for 2.10.0-rc3

Message ID 20170811140536.2792-1-kwolf@redhat.com
State New
Headers show

Pull-request

git://repo.or.cz/qemu/kevin.git tags/for-upstream

Message

Kevin Wolf Aug. 11, 2017, 2:05 p.m.
The following changes since commit 95766c2cd04395e5712b4d5967b3251f35d537df:

  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-08-10 18:53:39 +0100)

are available in the git repository at:

  git://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to 8565c3ab537e78f3e69977ec2c609dc9417a806e:

  qemu-iotests: fix 185 (2017-08-11 14:44:39 +0200)

----------------------------------------------------------------
Block layer patches for 2.10.0-rc3

----------------------------------------------------------------
Eric Blake (4):
      tests/multiboot: Fix whitespace failure
      vpc: Check failure of bdrv_getlength()
      qcow2: Drop debugging dump_refcounts()
      qcow2: Check failure of bdrv_getlength()

Fam Zheng (2):
      osdep: Add runtime OFD lock detection
      file-posix: Do runtime check for ofd lock API

Vladimir Sementsov-Ogievskiy (1):
      qemu-iotests: fix 185

 include/qemu/osdep.h        |  1 +
 block/file-posix.c          | 19 ++++++-------
 block/qcow2.c               | 26 +++---------------
 block/vpc.c                 |  9 ++++++-
 util/osdep.c                | 66 ++++++++++++++++++++++++++++++++++++++-------
 tests/multiboot/run_test.sh |  2 +-
 tests/qemu-iotests/185      |  4 +++
 7 files changed, 82 insertions(+), 45 deletions(-)

Comments

Peter Maydell Aug. 11, 2017, 5:10 p.m. | #1
On 11 August 2017 at 15:05, Kevin Wolf <kwolf@redhat.com> wrote:
> The following changes since commit 95766c2cd04395e5712b4d5967b3251f35d537df:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-08-10 18:53:39 +0100)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 8565c3ab537e78f3e69977ec2c609dc9417a806e:
>
>   qemu-iotests: fix 185 (2017-08-11 14:44:39 +0200)
>
> ----------------------------------------------------------------
> Block layer patches for 2.10.0-rc3
>
> ----------------------------------------------------------------

I get an intermittent failure on aarch64 test-aio-multithread:

MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
gtester -k --verbose -m=quick tests/test-aio-multithread
TEST: tests/test-aio-multithread... (pid=19863)
  /aio/multi/lifecycle:                                                OK
  /aio/multi/schedule:                                                 OK
  /aio/multi/mutex/contended:                                          OK
  /aio/multi/mutex/handoff:                                            OK
  /aio/multi/mutex/mcs:                                                **
ERROR:/home/pm215/qemu/tests/test-aio-multithread.c:368:test_multi_fair_mutex:
assertion failed (counter == atomic_counter): (343406 == 343407)
FAIL
GTester: last random seed: R02S227b39277b8c54976c98f0e990305851
(pid=21145)
  /aio/multi/mutex/pthread:                                            OK
FAIL: tests/test-aio-multithread


but I've pushed this to master on the optimistic assumption that
it's not the fault of anything in this pullreq... (will
investigate further)

thanks
-- PMM
Peter Maydell Aug. 11, 2017, 6 p.m. | #2
On 11 August 2017 at 18:10, Peter Maydell <peter.maydell@linaro.org> wrote:
> I get an intermittent failure on aarch64 test-aio-multithread:
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> gtester -k --verbose -m=quick tests/test-aio-multithread
> TEST: tests/test-aio-multithread... (pid=19863)
>   /aio/multi/lifecycle:                                                OK
>   /aio/multi/schedule:                                                 OK
>   /aio/multi/mutex/contended:                                          OK
>   /aio/multi/mutex/handoff:                                            OK
>   /aio/multi/mutex/mcs:                                                **
> ERROR:/home/pm215/qemu/tests/test-aio-multithread.c:368:test_multi_fair_mutex:
> assertion failed (counter == atomic_counter): (343406 == 343407)
> FAIL
> GTester: last random seed: R02S227b39277b8c54976c98f0e990305851
> (pid=21145)
>   /aio/multi/mutex/pthread:                                            OK
> FAIL: tests/test-aio-multithread
>
>
> but I've pushed this to master on the optimistic assumption that
> it's not the fault of anything in this pullreq... (will
> investigate further)

I can repro this on 95766c2cd043 so it definitely isn't this patchset's
fault.

thanks
-- PMM