skip patchable_function_entry tests on ia64

Submitted by Torsten Duwe on Aug. 11, 2017, 10:34 a.m.

Details

Message ID 20170811103429.5vmf4hlpox5abxnu@suse.de
State New
Headers show

Commit Message

Torsten Duwe Aug. 11, 2017, 10:34 a.m.
As Andreas found out, patchable_function_entry tests generate false failures
on ia64. On a closer look, this feature needs some more thought on itanium:
I *could* imagine it is a good idea to generate N complete nop "bundles",
which would be properly aligned and allow for easy replacement with alternate
binary code.

But I'd rather leave this to the platform experts, or whoever comes up with
a good use case, to implement the proper cpu override hook. Meanwhile, as
long as the expected results remain undefined, disable the tests.

	Torsten


gcc/testsuite/ChangeLog
2017-08-11  Torsten Duwe  <duwe@suse.de>

	* c-c++-common/patchable_function_entry-default.c: Skip test on ia64.
	* c-c++-common/patchable_function_entry-decl.c: Likewise.
	* c-c++-common/patchable_function_entry-definition.c: Likewise.

Comments

Jim Wilson Aug. 14, 2017, 3:09 p.m.
On Fri, 2017-08-11 at 12:34 +0200, Torsten Duwe wrote:
> gcc/testsuite/ChangeLog
> 2017-08-11  Torsten Duwe  <duwe@suse.de>
> 
> 	* c-c++-common/patchable_function_entry-default.c: Skip test on
> ia64.
> 	* c-c++-common/patchable_function_entry-decl.c: Likewise.
> 	* c-c++-common/patchable_function_entry-definition.c: Likewise.

OK.

Jim

Patch hide | download patch | download mbox

diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
index 5c39a354559..e35dce4f3d8 100644
--- a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
+++ b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile { target { ! nvptx*-*-* } } } */
+/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */
 /* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
 /* { dg-final { scan-assembler-times "nop" 2 } } */
 
diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-default.c b/gcc/testsuite/c-c++-common/patchable_function_entry-default.c
index 48094f75f78..1b7e188d5f9 100644
--- a/gcc/testsuite/c-c++-common/patchable_function_entry-default.c
+++ b/gcc/testsuite/c-c++-common/patchable_function_entry-default.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile { target { ! nvptx*-*-* } } } */
+/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */
 /* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
 /* { dg-final { scan-assembler-times "nop" 3 } } */
 
diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c b/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c
index af8202f283b..33e37dbc49f 100644
--- a/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c
+++ b/gcc/testsuite/c-c++-common/patchable_function_entry-definition.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile { target { ! nvptx*-*-* } } } */
+/* { dg-skip-if "undefined padding" { "ia64*-*-*" } { "*" } { "" } } */
 /* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
 /* { dg-final { scan-assembler-times "nop" 1 } } */