[PATCHv6,1/3] ARM:dt-bindings Intel FPGA Video and Image Processing Suite

Message ID 1502434187-6407-2-git-send-email-hean.loong.ong@intel.com
State Not Applicable
Headers show

Commit Message

Hean-Loong, Ong Aug. 11, 2017, 6:49 a.m.
From: Ong Hean Loong <hean.loong.ong@intel.com>

Device tree binding for Intel FPGA Video and Image
Processing Suite. The binding involved would be generated
from the Altera (Intel) Qsys system. The bindings would
set the max width, max height, buts per pixel and memory
port width. The device tree binding only supports the Intel
Arria10 devkit and its variants. Vendor name retained as
altr.

Signed-off-by: Ong, Hean Loong <hean.loong.ong@intel.com>
---
V6:
Fix comments for description

V5:
*Fix comments on description
*remove bindings for bits per symbol as it has only one value which is 8

V4:
*Fix comments on description

V3:
*Fix comments on description

V2:
*Fix comments on description

V1:
*Fix comments on description
---
---
 .../devicetree/bindings/display/altr,vip-fb2.txt   | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/altr,vip-fb2.txt

Comments

Rob Herring Aug. 17, 2017, 3:22 p.m. | #1
On Fri, Aug 11, 2017 at 02:49:45PM +0800, Hean-Loong, Ong wrote:
> From: Ong Hean Loong <hean.loong.ong@intel.com>

"dt-bindings: display: ..." for the subject. With that,

Acked-by: Rob Herring <robh@kernel.org>

> 
> Device tree binding for Intel FPGA Video and Image
> Processing Suite. The binding involved would be generated
> from the Altera (Intel) Qsys system. The bindings would
> set the max width, max height, buts per pixel and memory
> port width. The device tree binding only supports the Intel
> Arria10 devkit and its variants. Vendor name retained as
> altr.
> 
> Signed-off-by: Ong, Hean Loong <hean.loong.ong@intel.com>
> ---
> V6:
> Fix comments for description

A completely useless version history. You should describe the diff 
between versions.

> 
> V5:
> *Fix comments on description
> *remove bindings for bits per symbol as it has only one value which is 8
> 
> V4:
> *Fix comments on description
> 
> V3:
> *Fix comments on description
> 
> V2:
> *Fix comments on description
> 
> V1:
> *Fix comments on description
> ---
> ---
>  .../devicetree/bindings/display/altr,vip-fb2.txt   | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/altr,vip-fb2.txt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hean-Loong, Ong Aug. 18, 2017, 12:56 a.m. | #2
On Thu, 2017-08-17 at 10:22 -0500, Rob Herring wrote:
> On Fri, Aug 11, 2017 at 02:49:45PM +0800, Hean-Loong, Ong wrote:

> > 

> > From: Ong Hean Loong <hean.loong.ong@intel.com>

> "dt-bindings: display: ..." for the subject. With that,

> 

> Acked-by: Rob Herring <robh@kernel.org>

> 

> > 

> > 

> > Device tree binding for Intel FPGA Video and Image

> > Processing Suite. The binding involved would be generated

> > from the Altera (Intel) Qsys system. The bindings would

> > set the max width, max height, buts per pixel and memory

> > port width. The device tree binding only supports the Intel

> > Arria10 devkit and its variants. Vendor name retained as

> > altr.

> > 

> > Signed-off-by: Ong, Hean Loong <hean.loong.ong@intel.com>

> > ---

> > V6:

> > Fix comments for description

> A completely useless version history. You should describe the diff 

> between versions.

> 

Noted. Would make the necessary changes
> > 

> > 

> > V5:

> > *Fix comments on description

> > *remove bindings for bits per symbol as it has only one value which

> > is 8

> > 

> > V4:

> > *Fix comments on description

> > 

> > V3:

> > *Fix comments on description

> > 

> > V2:

> > *Fix comments on description

> > 

> > V1:

> > *Fix comments on description

> > ---

> > ---

> >  .../devicetree/bindings/display/altr,vip-fb2.txt   | 42

> > ++++++++++++++++++++++

> >  1 file changed, 42 insertions(+)

> >  create mode 100644

> > Documentation/devicetree/bindings/display/altr,vip-fb2.txt

Patch

diff --git a/Documentation/devicetree/bindings/display/altr,vip-fb2.txt b/Documentation/devicetree/bindings/display/altr,vip-fb2.txt
new file mode 100644
index 0000000..57d8869
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/altr,vip-fb2.txt
@@ -0,0 +1,42 @@ 
+Intel Video and Image Processing(VIP) Frame Buffer II bindings
+
+Supported hardware: Intel FPGA SoC Arria10 and above with display port IP
+
+The hardware associated with this device tree is a SoC FPGA.
+Where there is an microprocessor and a FPGA device.
+The microprocessor would host the OS while the FPGA device runs
+on its individual IP firmware. The Intel VIP Frame Buffer II
+system would be driving data from the to the FPGA device
+programmed with the Frame Buffer II IP to render pixels to be streamed
+to the Display Port connector.
+
+The Frame Buffer II device is a simple frame buffer device. The device
+contains the display properties and the bridge or connector register.
+The output for this device currently is a dedicated to a single Display Port.
+Currently the max resolution supported is 1280 x 720 at 60Hz.
+
+More information the FPGA video IP component can be acquired from
+https://www.altera.com/content/dam/altera-www/global/en_US/pdfs\
+/literature/ug/ug_vip.pdf
+
+New bindings:
+=============
+Required properties:
+----------------------------
+- compatible: "altr,vip-frame-buffer-2.0"
+- reg: Physical base address and length of the framebuffer controller's
+	registers.
+- altr,max-width: The maximum width of the framebuffer in pixels.
+- altr,max-height: The maximum height of the framebuffer in pixels.
+- altr,mem-port-width: the bus width of the avalon master port
+	on the frame reader
+
+Example:
+----------------------------
+       dp_0_frame_buf: display-controller@100000280 {
+                       compatible = "altr,vip-frame-buffer-2.0";
+                       reg = <0x00000001 0x00000280 0x00000040>;
+                       altr,max-width = <1280>;
+                       altr,max-height = <720>;
+                       altr,mem-port-width = <128>;
+       };