From patchwork Fri Aug 11 05:53:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suneel Garapati X-Patchwork-Id: 800413 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ei9nlL7r"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xTDhX3p96z9t36 for ; Fri, 11 Aug 2017 15:53:48 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 3921CC21C39; Fri, 11 Aug 2017 05:53:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2461CC21CEC; Fri, 11 Aug 2017 05:53:39 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 9EBFBC21CEC; Fri, 11 Aug 2017 05:53:37 +0000 (UTC) Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by lists.denx.de (Postfix) with ESMTPS id 0BB5BC21C39 for ; Fri, 11 Aug 2017 05:53:37 +0000 (UTC) Received: by mail-pg0-f66.google.com with SMTP id y192so2373122pgd.1 for ; Thu, 10 Aug 2017 22:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=924JwvBzvQnWSN8jNnpnsuaFFySthD21HreyyEnrJD4=; b=Ei9nlL7rGDfjou1woJH6DkTrElOKFihpxJnU09EtXts9hIlSJRCiJ5wgPsaQA39Zsq 31jIqAJ7mU+CA1Om0YZHRcOYHctQq1A3MsDi1eOFN5FWI/Yl66m/FqmDwLHdBzH5RJ1N v3M78yqf6yWs8M/LAC9yI7F8mb9kQ/l/2hvhfaToyWYQZX9lDOCBgvyl9HCay6nKrxiN OyB4D7yfos116RxR6ZCFUdjRx8DhvYciYcYMf4VEfSnPG7xDFN+k4+cMFxdaVexv2B2X wLp7bgt6sgLxo7c5+hctXCtQLtT+zgYFGu+EkcX9G+K32e/20wRlZRUnD9uTwx+L6eGr WevA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=924JwvBzvQnWSN8jNnpnsuaFFySthD21HreyyEnrJD4=; b=VlCYB1uJBUCyyGmKWyIaZAAE75L9jBJ//E7pleBuU8Pc0XQvnnqchCy7KwPA0bjCLq e+ZVmKMODk7/Wnssn7y9STjHDlniu/G1DUwigenZbqBk2ZXCvsARNhEgdjr8vuP3q1yR 1Sjkoa+xeB13+VUvN/l4WyKJh/C4ODdqH5UY+oXO8dsd1G1kklxAiRNaWcnROdX8Ecwm T7OwmfkXWlesgzXpsABLYRVtL5/TqRxbaXxAD95M4y1KLMyzS+NclIRE5qbeqvJ8Oe09 DUjQecJgjcIIItWKYHex5e+9y50pQqhxI2ru/epy0w7ixcpTCKQ0ilBmcjPEZ6Gyw0BT MLPQ== X-Gm-Message-State: AHYfb5hjHl7tPwXhLqUxyiwUBRE9mEU+xRWrmNivNBDyL09Zx5W4rCbD 8I2VqNcStXIOPQ== X-Received: by 10.99.0.17 with SMTP id 17mr14170508pga.209.1502430815500; Thu, 10 Aug 2017 22:53:35 -0700 (PDT) Received: from suneel.hsd1.ca.comcast.net ([2601:646:8e00:e521:862:6a66:547b:608b]) by smtp.gmail.com with ESMTPSA id e131sm173021pgc.64.2017.08.10.22.53.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Aug 2017 22:53:34 -0700 (PDT) From: Suneel Garapati To: Stefan Roese Date: Thu, 10 Aug 2017 22:53:31 -0700 Message-Id: <1502430811-21475-1-git-send-email-suneelglinux@gmail.com> X-Mailer: git-send-email 2.7.4 Cc: u-boot@lists.denx.de, Michal Simek Subject: [U-Boot] [UBOOT] [PATCH] cmd: usb: ignore block devices under mass storage device X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" usb tree and info commands may cause crash otherwise Signed-off-by: Suneel Garapati --- cmd/usb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd/usb.c b/cmd/usb.c index 992d414..81e1a7b 100644 --- a/cmd/usb.c +++ b/cmd/usb.c @@ -415,7 +415,8 @@ static void usb_show_tree_graph(struct usb_device *dev, char *pre) udev = dev_get_parent_priv(child); /* Ignore emulators, we only want real devices */ - if (device_get_uclass_id(child) != UCLASS_USB_EMUL) { + if (device_get_uclass_id(child) != + (UCLASS_USB_EMUL | UCLASS_BLK)) { usb_show_tree_graph(udev, pre); pre[index] = 0; } @@ -605,7 +606,8 @@ static void usb_show_info(struct usb_device *udev) for (device_find_first_child(udev->dev, &child); child; device_find_next_child(&child)) { - if (device_active(child)) { + if (device_active(child) && + (device_get_uclass_id(child) != UCLASS_BLK)) { udev = dev_get_parent_priv(child); usb_show_info(udev); }