| Message ID | 1502409753-27516-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 08/11/2017 02:02 AM, William Tu wrote: > Kernel test robot reports error when running test_xdp_redirect.sh. > Check if ip tool supports xdpgeneric, if not, skip the test. > > Signed-off-by: William Tu <u9012063@gmail.com> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: John Fastabend <john.fastabend@gmail.com> > --- > tools/testing/selftests/bpf/test_xdp_redirect.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/bpf/test_xdp_redirect.sh b/tools/testing/selftests/bpf/test_xdp_redirect.sh > index d8c73ed6e040..c5a8b7173c12 100755 > --- a/tools/testing/selftests/bpf/test_xdp_redirect.sh > +++ b/tools/testing/selftests/bpf/test_xdp_redirect.sh > @@ -23,6 +23,11 @@ cleanup() > ip netns del ns2 2> /dev/null > } > > +ip link set dev lo xdpgeneric off 2>/dev/null > /dev/null > +if [ $? -ne 0 ];then > + echo "selftests: [SKIP] Could not run test without the ip xdpgeneric support" > + exit 0 Small nit: could you make that indent consistently as tabs like in your cleanup() function slightly further above? Other than that (+ subject should also be [PATCH net-next]): Acked-by: Daniel Borkmann <daniel@iogearbox.net>
thanks! I will fix it and re-submit. William On Fri, Aug 11, 2017 at 4:31 AM, Daniel Borkmann <daniel@iogearbox.net> wrote: > On 08/11/2017 02:02 AM, William Tu wrote: >> >> Kernel test robot reports error when running test_xdp_redirect.sh. >> Check if ip tool supports xdpgeneric, if not, skip the test. >> >> Signed-off-by: William Tu <u9012063@gmail.com> >> Cc: Daniel Borkmann <daniel@iogearbox.net> >> Cc: John Fastabend <john.fastabend@gmail.com> >> --- >> tools/testing/selftests/bpf/test_xdp_redirect.sh | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/tools/testing/selftests/bpf/test_xdp_redirect.sh >> b/tools/testing/selftests/bpf/test_xdp_redirect.sh >> index d8c73ed6e040..c5a8b7173c12 100755 >> --- a/tools/testing/selftests/bpf/test_xdp_redirect.sh >> +++ b/tools/testing/selftests/bpf/test_xdp_redirect.sh >> @@ -23,6 +23,11 @@ cleanup() >> ip netns del ns2 2> /dev/null >> } >> >> +ip link set dev lo xdpgeneric off 2>/dev/null > /dev/null >> +if [ $? -ne 0 ];then >> + echo "selftests: [SKIP] Could not run test without the ip >> xdpgeneric support" >> + exit 0 > > > Small nit: could you make that indent consistently as tabs > like in your cleanup() function slightly further above? > > Other than that (+ subject should also be [PATCH net-next]): > > Acked-by: Daniel Borkmann <daniel@iogearbox.net>
diff --git a/tools/testing/selftests/bpf/test_xdp_redirect.sh b/tools/testing/selftests/bpf/test_xdp_redirect.sh index d8c73ed6e040..c5a8b7173c12 100755 --- a/tools/testing/selftests/bpf/test_xdp_redirect.sh +++ b/tools/testing/selftests/bpf/test_xdp_redirect.sh @@ -23,6 +23,11 @@ cleanup() ip netns del ns2 2> /dev/null } +ip link set dev lo xdpgeneric off 2>/dev/null > /dev/null +if [ $? -ne 0 ];then + echo "selftests: [SKIP] Could not run test without the ip xdpgeneric support" + exit 0 +fi set -e ip netns add ns1
Kernel test robot reports error when running test_xdp_redirect.sh. Check if ip tool supports xdpgeneric, if not, skip the test. Signed-off-by: William Tu <u9012063@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: John Fastabend <john.fastabend@gmail.com> --- tools/testing/selftests/bpf/test_xdp_redirect.sh | 5 +++++ 1 file changed, 5 insertions(+)