[PATCH/next] get-developers: add option to get developers for files

Message ID 20170810211116.7996-1-arnout@mind.be
State Accepted
Headers show

Commit Message

Arnout Vandecappelle Aug. 10, 2017, 9:11 p.m.
The DEVELOPERS file lists file patterns, but the get-developers script
only supports getting packages and CPU architectures. Some files are
neither of those, e.g. defconfigs, support files, package infras, ...

Add a '-f' option that allows to give a list of files for which to get
the developer(s).

Note that the DEVELOPERS file contains directories as well as files,
and the directories are not expanded into individual files. Therefore,
we have to use f.startswith(devfile) to match a directory. This assumes
that the directory name ends with /, otherwise 'package/python' would
also match 'package/python-foo'. Since we make sure that directories do
end with / in the DEVELOPERS file, and since false positives are not
much of an issue in this case, this isn't a problem.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 utils/get-developers | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Thomas Petazzoni Aug. 14, 2017, 8:42 p.m. | #1
Hello,

On Thu, 10 Aug 2017 23:11:16 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> The DEVELOPERS file lists file patterns, but the get-developers script
> only supports getting packages and CPU architectures. Some files are
> neither of those, e.g. defconfigs, support files, package infras, ...
> 
> Add a '-f' option that allows to give a list of files for which to get
> the developer(s).
> 
> Note that the DEVELOPERS file contains directories as well as files,
> and the directories are not expanded into individual files. Therefore,
> we have to use f.startswith(devfile) to match a directory. This assumes
> that the directory name ends with /, otherwise 'package/python' would
> also match 'package/python-foo'. Since we make sure that directories do
> end with / in the DEVELOPERS file, and since false positives are not
> much of an issue in this case, this isn't a problem.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  utils/get-developers | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

Applied to next, thanks.

Thomas

Patch

diff --git a/utils/get-developers b/utils/get-developers
index fa6fc2fc68..6a028b4526 100755
--- a/utils/get-developers
+++ b/utils/get-developers
@@ -3,6 +3,7 @@ 
 import argparse
 import getdeveloperlib
 import sys
+import os
 
 def parse_args():
     parser = argparse.ArgumentParser()
@@ -12,6 +13,8 @@  def parse_args():
                         help='find developers in charge of this architecture')
     parser.add_argument('-p', dest='package', action='store',
                         help='find developers in charge of this package')
+    parser.add_argument('-f', dest='files', nargs='*',
+                        help='find developers in charge of these files')
     parser.add_argument('-c', dest='check', action='store_const',
                         const=True, help='list files not handled by any developer')
     return parser.parse_args()
@@ -28,6 +31,8 @@  def __main__():
         action += 1
     if args.package is not None:
         action += 1
+    if args.files:
+        action += 1
     if args.check:
         action += 1
     if len(args.patches) != 0:
@@ -59,6 +64,16 @@  def __main__():
                 print(dev.name)
         return
 
+    # Handle the files action
+    if args.files is not None:
+        args.files = [os.path.abspath(f) for f in args.files]
+        for dev in devs:
+            for devfile in dev.files:
+                commonfiles = [f for f in args.files if f.startswith(devfile)]
+                if commonfiles:
+                    print(dev.name)
+                    break
+
     # Handle the patches action
     if len(args.patches) != 0:
         (files, infras) = getdeveloperlib.analyze_patches(args.patches)