[ovs-dev,v3,3/4] netdev-dpdk: Remove useless cutlen.

Message ID 1502379486-1568-4-git-send-email-i.maximets@samsung.com
State New
Headers show

Commit Message

Ilya Maximets Aug. 10, 2017, 3:38 p.m.
Cutlen already applied while processing OVS_ACTION_ATTR_OUTPUT.

Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 lib/netdev-dpdk.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Bodireddy, Bhanuprakash Sept. 25, 2017, 3:25 p.m. | #1
>Cutlen already applied while processing OVS_ACTION_ATTR_OUTPUT.
>
>Signed-off-by: Ilya Maximets <i.maximets@samsung.com>

LGTM, 
The below redundant calls can be removed as packet cutlen is already applied in dpif layer.

-Bhanuprakash.

>---
> lib/netdev-dpdk.c | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 8e3158f..ddcc574
>100644
>--- a/lib/netdev-dpdk.c
>+++ b/lib/netdev-dpdk.c
>@@ -1819,8 +1819,6 @@ dpdk_do_tx_copy(struct netdev *netdev, int qid,
>struct dp_packet_batch *batch)
>     int newcnt = 0;
>     int i;
>
>-    dp_packet_batch_apply_cutlen(batch);
>-
>     for (i = 0; i < batch->count; i++) {
>         int size = dp_packet_size(batch->packets[i]);
>
>@@ -1879,7 +1877,6 @@ netdev_dpdk_vhost_send(struct netdev *netdev,
>int qid,
>         dpdk_do_tx_copy(netdev, qid, batch);
>         dp_packet_delete_batch(batch, true);
>     } else {
>-        dp_packet_batch_apply_cutlen(batch);
>         __netdev_dpdk_vhost_send(netdev, qid, batch->packets, batch-
>>count);
>     }
>     return 0;
>@@ -1910,8 +1907,6 @@ netdev_dpdk_send__(struct netdev_dpdk *dev, int
>qid,
>         int cnt = batch->count;
>         struct rte_mbuf **pkts = (struct rte_mbuf **) batch->packets;
>
>-        dp_packet_batch_apply_cutlen(batch);
>-
>         cnt = netdev_dpdk_filter_packet_len(dev, pkts, cnt);
>         cnt = netdev_dpdk_qos_run(dev, pkts, cnt);
>         dropped = batch->count - cnt;
>--
>2.7.4

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 8e3158f..ddcc574 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1819,8 +1819,6 @@  dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch)
     int newcnt = 0;
     int i;
 
-    dp_packet_batch_apply_cutlen(batch);
-
     for (i = 0; i < batch->count; i++) {
         int size = dp_packet_size(batch->packets[i]);
 
@@ -1879,7 +1877,6 @@  netdev_dpdk_vhost_send(struct netdev *netdev, int qid,
         dpdk_do_tx_copy(netdev, qid, batch);
         dp_packet_delete_batch(batch, true);
     } else {
-        dp_packet_batch_apply_cutlen(batch);
         __netdev_dpdk_vhost_send(netdev, qid, batch->packets, batch->count);
     }
     return 0;
@@ -1910,8 +1907,6 @@  netdev_dpdk_send__(struct netdev_dpdk *dev, int qid,
         int cnt = batch->count;
         struct rte_mbuf **pkts = (struct rte_mbuf **) batch->packets;
 
-        dp_packet_batch_apply_cutlen(batch);
-
         cnt = netdev_dpdk_filter_packet_len(dev, pkts, cnt);
         cnt = netdev_dpdk_qos_run(dev, pkts, cnt);
         dropped = batch->count - cnt;