From patchwork Thu Aug 10 06:58:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell Currey X-Patchwork-Id: 800107 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xSfC71HN6z9s7M for ; Thu, 10 Aug 2017 16:59:47 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="jFF9xHcH"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xSfC702DWzDr2q for ; Thu, 10 Aug 2017 16:59:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="jFF9xHcH"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xSfBS2ND9zDqrP for ; Thu, 10 Aug 2017 16:59:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="jFF9xHcH"; dkim-atps=neutral Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2A97921B0C; Thu, 10 Aug 2017 02:59:10 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Thu, 10 Aug 2017 02:59:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=n1mTqtHG7iQrld8m+E2y8TFKkpZmptgv/oS68w4Fw gU=; b=jFF9xHcHiB8al7Ho5cS5utbd58hY4mGVQdrEjOBD+6b+AdlZ+BLHrS+BI DONnmcRI6lKNVEB41MBMYSINQHNa7/3qmHdgVkU1pTGiB6YVwRc9VOVOhFM6mG60 DByK2j0YZmoqIdmOVHosOItgXjMzoS0dC8H4JyIChpZ7eVYMuiMz9xmrpHbZ/QDT /0BVyxX/jsBLEuRpWe9vDAcDm+Twecyl4SJ32fPKpm756EtYg4Giurxsp7PtQtoR XCBBZDo1MB4CXvkiRfPC3s14+TB2KWG1VHY2Jp1jMLWuJr9+I2KfP5cxWOdDwa6u A5iC+eZYqHIao/7hOlQv4cqedfQOQ== X-ME-Sender: X-Sasl-enc: q5CNWZwRQzKo/+ukYiHXYiFPlQbJ4cfLlryH8iOcemYI 1502348349 Received: from snap.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F9C4246D5; Thu, 10 Aug 2017 02:59:08 -0400 (EDT) From: Russell Currey To: skiboot@lists.ozlabs.org Date: Thu, 10 Aug 2017 16:58:40 +1000 Message-Id: <20170810065843.13893-3-ruscur@russell.cc> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170810065843.13893-1-ruscur@russell.cc> References: <20170810065843.13893-1-ruscur@russell.cc> Subject: [Skiboot] [PATCH 3/6] phb4: Skip attempting to fix PHBs broken on boot X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikey@neuling.org MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" If a PHB is marked broken it didn't work on boot, and if it didn't work on boot then there's no point trying to recover it later Signed-off-by: Russell Currey --- hw/phb4.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/phb4.c b/hw/phb4.c index 7e8f68bf..012a8cdc 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -2608,6 +2608,10 @@ static int64_t phb4_creset(struct pci_slot *slot) struct phb4 *p = phb_to_phb4(slot->phb); uint64_t pbcq_status, reg; + /* Don't even try fixing a broken PHB */ + if (p->state == PHB4_STATE_BROKEN) + return OPAL_HARDWARE; + switch (slot->state) { case PHB4_SLOT_NORMAL: case PHB4_SLOT_CRESET_START: