From patchwork Sun Sep 21 20:20:57 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeniy Polyakov X-Patchwork-Id: 800 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 84DC8DDEEF for ; Mon, 22 Sep 2008 06:24:47 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407AbYIUUYk (ORCPT ); Sun, 21 Sep 2008 16:24:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752413AbYIUUYj (ORCPT ); Sun, 21 Sep 2008 16:24:39 -0400 Received: from relay.2ka.mipt.ru ([194.85.80.65]:40999 "EHLO 2ka.mipt.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbYIUUYh (ORCPT ); Sun, 21 Sep 2008 16:24:37 -0400 Received: from 2ka.mipt.ru (localhost [127.0.0.1]) by 2ka.mipt.ru (8.14.1/8.14.1) with ESMTP id m8LKKwRv009341; Mon, 22 Sep 2008 00:20:58 +0400 Received: (from johnpol@localhost) by 2ka.mipt.ru (8.14.1/8.12.1/Submit) id m8LKKv7Y009328; Mon, 22 Sep 2008 00:20:57 +0400 Date: Mon, 22 Sep 2008 00:20:57 +0400 From: Evgeniy Polyakov To: Arjan van de Ven Cc: Johannes Berg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ipw2100-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org, yi.zhu@intel.com, reinette.chatre@intel.com, jgarzik@pobox.com, linville@tuxdriver.com, davem@davemloft.net Subject: Re: Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart. Message-ID: <20080921202057.GB25052@2ka.mipt.ru> References: <20080921172316.GA6306@2ka.mipt.ru> <20080921110422.1d010b96@infradead.org> <20080921182835.GA11473@2ka.mipt.ru> <20080921113513.16677c4e@infradead.org> <20080921190050.GA20484@2ka.mipt.ru> <1222024444.3023.53.camel@johannes.berg> <20080921193809.GA8735@2ka.mipt.ru> <20080921124332.67ddc13a@infradead.org> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20080921124332.67ddc13a@infradead.org> User-Agent: Mutt/1.5.9i Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Sep 21, 2008 at 12:43:32PM -0700, Arjan van de Ven (arjan@infradead.org) wrote: > > @@ -3174,6 +3176,10 @@ static void ipw2100_irq_tasklet(struct > > ipw2100_priv *priv) if (inta & IPW2100_INTA_FATAL_ERROR) { > > printk(KERN_WARNING DRV_NAME > > ": Fatal interrupt. Scheduling firmware > > restart.\n"); > > + WARN_ON(1); > > + > > + BUG_ON(ipw2100_max_fatal_ints-- <= 0); > > BUG_ON in interrupt context is just extremely hostile, since it means > the box is dead. > > also I would suggest using WARN_ON_ONCE() Well, I actually wanted to have a bug there because of it, but now I think that annoying repeated warning is enough to bring attention to the problem by putting bug information into some magic special place called kerneloops collection. Consider for inclusing for the upcoming kernel to get wider notifications. Yes, it is not a bugfix, I know. diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c index 19a401c..6599211 100644 --- a/drivers/net/wireless/ipw2100.c +++ b/drivers/net/wireless/ipw2100.c @@ -206,6 +206,9 @@ MODULE_PARM_DESC(disable, "manually disable the radio (default 0 [radio on])"); static u32 ipw2100_debug_level = IPW_DL_NONE; +static int ipw2100_max_fatal_ints = 10; +module_param(ipw2100_max_fatal_ints, int, 0644); + #ifdef CONFIG_IPW2100_DEBUG #define IPW_DEBUG(level, message...) \ do { \ @@ -3174,6 +3177,9 @@ static void ipw2100_irq_tasklet(struct ipw2100_priv *priv) if (inta & IPW2100_INTA_FATAL_ERROR) { printk(KERN_WARNING DRV_NAME ": Fatal interrupt. Scheduling firmware restart.\n"); + + WARN_ON(ipw2100_max_fatal_ints-- >= 0); + priv->inta_other++; write_register(dev, IPW_REG_INTA, IPW2100_INTA_FATAL_ERROR);