| Message ID | 3a687666c2e7972fb6d2379848f31006ac1dd59a.1502219353.git.khalid.aziz@oracle.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
From: Khalid Aziz <khalid.aziz@oracle.com> Date: Wed, 9 Aug 2017 15:26:02 -0600 > +void adi_restore_tags(struct mm_struct *mm, struct vm_area_struct *vma, > + unsigned long addr, pte_t pte) > +{ ... > + tag = tag_start(addr, tag_desc); > + paddr = pte_val(pte) & _PAGE_PADDR_4V; > + for (tmp = paddr; tmp < (paddr+PAGE_SIZE); tmp += adi_blksize()) { > + version1 = (*tag) >> 4; > + version2 = (*tag) & 0x0f; > + *tag++ = 0; > + asm volatile("stxa %0, [%1] %2\n\t" > + : > + : "r" (version1), "r" (tmp), > + "i" (ASI_MCD_REAL)); > + tmp += adi_blksize(); > + asm volatile("stxa %0, [%1] %2\n\t" > + : > + : "r" (version2), "r" (tmp), > + "i" (ASI_MCD_REAL)); > + } > + asm volatile("membar #Sync\n\t"); You do a membar here. > + for (i = pfrom; i < (pfrom + PAGE_SIZE); i += adi_blksize()) { > + asm volatile("ldxa [%1] %2, %0\n\t" > + : "=r" (adi_tag) > + : "r" (i), "i" (ASI_MCD_REAL)); > + asm volatile("stxa %0, [%1] %2\n\t" > + : > + : "r" (adi_tag), "r" (pto), > + "i" (ASI_MCD_REAL)); But not here. Is this OK? I suspect you need to add a membar this this second piece of MCD tag storing code. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/15/2017 10:58 PM, David Miller wrote: > From: Khalid Aziz <khalid.aziz@oracle.com> > Date: Wed, 9 Aug 2017 15:26:02 -0600 > >> +void adi_restore_tags(struct mm_struct *mm, struct vm_area_struct *vma, >> + unsigned long addr, pte_t pte) >> +{ > ... >> + tag = tag_start(addr, tag_desc); >> + paddr = pte_val(pte) & _PAGE_PADDR_4V; >> + for (tmp = paddr; tmp < (paddr+PAGE_SIZE); tmp += adi_blksize()) { >> + version1 = (*tag) >> 4; >> + version2 = (*tag) & 0x0f; >> + *tag++ = 0; >> + asm volatile("stxa %0, [%1] %2\n\t" >> + : >> + : "r" (version1), "r" (tmp), >> + "i" (ASI_MCD_REAL)); >> + tmp += adi_blksize(); >> + asm volatile("stxa %0, [%1] %2\n\t" >> + : >> + : "r" (version2), "r" (tmp), >> + "i" (ASI_MCD_REAL)); >> + } >> + asm volatile("membar #Sync\n\t"); > > You do a membar here. > >> + for (i = pfrom; i < (pfrom + PAGE_SIZE); i += adi_blksize()) { >> + asm volatile("ldxa [%1] %2, %0\n\t" >> + : "=r" (adi_tag) >> + : "r" (i), "i" (ASI_MCD_REAL)); >> + asm volatile("stxa %0, [%1] %2\n\t" >> + : >> + : "r" (adi_tag), "r" (pto), >> + "i" (ASI_MCD_REAL)); > > But not here. > > Is this OK? I suspect you need to add a membar this this second piece > of MCD tag storing code. Hi Dave, You are right. This tag storing code needs membar as well. I will add that. Thanks, Khalid -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On Aug 9, 2017, at 2:26 PM, Khalid Aziz <khalid.aziz@oracle.com> wrote: > > ADI is a new feature supported on SPARC M7 and newer processors to allow > hardware to catch rogue accesses to memory. ADI is supported for data > fetches only and not instruction fetches. An app can enable ADI on its > data pages, set version tags on them and use versioned addresses to > access the data pages. Upper bits of the address contain the version > tag. On M7 processors, upper four bits (bits 63-60) contain the version > tag. If a rogue app attempts to access ADI enabled data pages, its > access is blocked and processor generates an exception. Please see > Documentation/sparc/adi.txt for further details. > > This patch extends mprotect to enable ADI (TSTATE.mcde), enable/disable > MCD (Memory Corruption Detection) on selected memory ranges, enable > TTE.mcd in PTEs, return ADI parameters to userspace and save/restore ADI > version tags on page swap out/in or migration. ADI is not enabled by > default for any task. A task must explicitly enable ADI on a memory > range and set version tag for ADI to be effective for the task. > > Signed-off-by: Khalid Aziz <khalid.aziz@oracle.com> > Cc: Khalid Aziz <khalid@gonehiking.org> > --- > v7: > - Enhanced arch_validate_prot() to enable ADI only on writable > addresses backed by physical RAM > - Added support for saving/restoring ADI tags for each ADI > block size address range on a page on swap in/out > - Added code to copy ADI tags on COW > - Updated values for auxiliary vectors to not conflict with > values on other architectures to avoid conflict in glibc. glibc > consolidates all auxiliary vectors into its headers and > duplicate values in consolidated header are problematic > - Disable same page merging on ADI enabled pages since ADI tags > may not match on pages with identical data > - Broke the patch up further into smaller patches > > v6: > - Eliminated instructions to read and write PSTATE as well as > MCDPER and PMCDPER on every access to userspace addresses > by setting PSTATE and PMCDPER correctly upon entry into > kernel. PSTATE.mcde and PMCDPER are set upon entry into > kernel when running on an M7 processor. PSTATE.mcde being > set only affects memory accesses that have TTE.mcd set. > PMCDPER being set only affects writes to memory addresses > that have TTE.mcd set. This ensures any faults caused by > ADI tag mismatch on a write are exposed before kernel returns > to userspace. > > v5: > - Fixed indentation issues and instrcuctions in assembly code > - Removed CONFIG_SPARC64 from mdesc.c > - Changed to maintain state of MCDPER register in thread info > flags as opposed to in mm context. MCDPER is a per-thread > state and belongs in thread info flag as opposed to mm context > which is shared across threads. Added comments to clarify this > is a lazily maintained state and must be updated on context > switch and copy_process() > - Updated code to use the new arch_do_swap_page() and > arch_unmap_one() functions > > v4: > - Broke patch up into smaller patches > > v3: > - Removed CONFIG_SPARC_ADI > - Replaced prctl commands with mprotect > - Added auxiliary vectors for ADI parameters > - Enabled ADI for swappable pages > > v2: > - Fixed a build error > > Documentation/sparc/adi.txt | 272 +++++++++++++++++++++++++++++++ > arch/sparc/include/asm/mman.h | 72 ++++++++- > arch/sparc/include/asm/mmu_64.h | 17 ++ > arch/sparc/include/asm/mmu_context_64.h | 43 +++++ > arch/sparc/include/asm/page_64.h | 4 + > arch/sparc/include/asm/pgtable_64.h | 46 ++++++ > arch/sparc/include/asm/thread_info_64.h | 2 +- > arch/sparc/include/asm/trap_block.h | 2 + > arch/sparc/include/uapi/asm/mman.h | 2 + > arch/sparc/kernel/adi_64.c | 277 ++++++++++++++++++++++++++++++++ > arch/sparc/kernel/etrap_64.S | 28 +++- > arch/sparc/kernel/process_64.c | 25 +++ > arch/sparc/kernel/setup_64.c | 11 +- > arch/sparc/kernel/vmlinux.lds.S | 5 + > arch/sparc/mm/gup.c | 37 +++++ > arch/sparc/mm/hugetlbpage.c | 14 +- > arch/sparc/mm/init_64.c | 33 ++++ > arch/sparc/mm/tsb.c | 21 +++ > include/linux/mm.h | 3 + > mm/ksm.c | 4 + > 20 files changed, 913 insertions(+), 5 deletions(-) > create mode 100644 Documentation/sparc/adi.txt > > diff --git a/Documentation/sparc/adi.txt b/Documentation/sparc/adi.txt > new file mode 100644 > index 000000000000..383bc65fec1e > --- /dev/null > +++ b/Documentation/sparc/adi.txt > @@ -0,0 +1,272 @@ > +Application Data Integrity (ADI) > +================================ > + > +SPARC M7 processor adds the Application Data Integrity (ADI) feature. > +ADI allows a task to set version tags on any subset of its address > +space. Once ADI is enabled and version tags are set for ranges of > +address space of a task, the processor will compare the tag in pointers > +to memory in these ranges to the version set by the application > +previously. Access to memory is granted only if the tag in given pointer > +matches the tag set by the application. In case of mismatch, processor > +raises an exception. > + > +Following steps must be taken by a task to enable ADI fully: > + > +1. Set the user mode PSTATE.mcde bit. This acts as master switch for > + the task's entire address space to enable/disable ADI for the task. > + > +2. Set TTE.mcd bit on any TLB entries that correspond to the range of > + addresses ADI is being enabled on. MMU checks the version tag only > + on the pages that have TTE.mcd bit set. > + > +3. Set the version tag for virtual addresses using stxa instruction > + and one of the MCD specific ASIs. Each stxa instruction sets the > + given tag for one ADI block size number of bytes. This step must > + be repeated for entire page to set tags for entire page. > + > +ADI block size for the platform is provided by the hypervisor to kernel > +in machine description tables. Hypervisor also provides the number of > +top bits in the virtual address that specify the version tag. Once > +version tag has been set for a memory location, the tag is stored in the > +physical memory and the same tag must be present in the ADI version tag > +bits of the virtual address being presented to the MMU. For example on > +SPARC M7 processor, MMU uses bits 63-60 for version tags and ADI block > +size is same as cacheline size which is 64 bytes. A task that sets ADI > +version to, say 10, on a range of memory, must access that memory using > +virtual addresses that contain 0xa in bits 63-60. > + > +ADI is enabled on a set of pages using mprotect() with PROT_ADI flag. > +When ADI is enabled on a set of pages by a task for the first time, > +kernel sets the PSTATE.mcde bit fot the task. Version tags for memory > +addresses are set with an stxa instruction on the addresses using > +ASI_MCD_PRIMARY or ASI_MCD_ST_BLKINIT_PRIMARY. ADI block size is > +provided by the hypervisor to the kernel. Kernel returns the value of > +ADI block size to userspace using auxiliary vector along with other ADI > +info. Following auxiliary vectors are provided by the kernel: > + > + AT_ADI_BLKSZ ADI block size. This is the granularity and > + alignment, in bytes, of ADI versioning. > + AT_ADI_NBITS Number of ADI version bits in the VA The previous patch series also defined AT_ADI_UEONADI. Why was that removed? > + > + > +IMPORTANT NOTES: > + > +- Version tag values of 0x0 and 0xf are reserved. The documentation should probably state more specifically that an in-memory tag value of 0x0 or 0xf is treated as "match all" by the HW meaning that a mismatch exception will never be generated regardless of the tag bits set in the VA accessing the memory. > + > +- Version tags are set on virtual addresses from userspace even though > + tags are stored in physical memory. Tags are set on a physical page > + after it has been allocated to a task and a pte has been created for > + it. > + > +- When a task frees a memory page it had set version tags on, the page > + goes back to free page pool. When this page is re-allocated to a task, > + kernel clears the page using block initialization ASI which clears the > + version tags as well for the page. If a page allocated to a task is > + freed and allocated back to the same task, old version tags set by the > + task on that page will no longer be present. The specifics should be included here, too, so someone doesn't have to guess what's going on if they make changes and the tags are no longer cleared. The HW clears the tag for a cacheline for block initializing stores to 64-byte aligned addresses if PSTATE.mcde=0 or TTE.mcd=0. PSTATE.mce is set when executing in the kernel, but pages are cleared using kernel physical mapping VAs which are mapped with TTE.mcd=0. Another HW behavior that should be mentioned is that tag mismatches are not detected for non-faulting loads. > + > +- Kernel does not set any tags for user pages and it is entirely a > + task's responsibility to set any version tags. Kernel does ensure the > + version tags are preserved if a page is swapped out to the disk and > + swapped back in. It also preserves that version tags if a page is > + migrated. I only have a cursory understanding of how page migration works, but I could not see how the tags would be preserved if a page were migrated. I figured the place to copy the tags would be migrate_page_copy(), but I don't see changes there. > + > +- ADI works for any size pages. A userspace task need not be aware of > + page size when using ADI. It can simply select a virtual address > + range, enable ADI on the range using mprotect() and set version tags > + for the entire range. mprotect() ensures range is aligned to page size > + and is a multiple of page size. > + > + > + > +ADI related traps > +----------------- > + > +With ADI enabled, following new traps may occur: > + > +Disrupting memory corruption > + > + When a store accesses a memory localtion that has TTE.mcd=1, > + the task is running with ADI enabled (PSTATE.mcde=1), and the ADI > + tag in the address used (bits 63:60) does not match the tag set on > + the corresponding cacheline, a memory corruption trap occurs. By > + default, it is a disrupting trap and is sent to the hypervisor > + first. Hypervisor creates a sun4v error report and sends a > + resumable error (TT=0x7e) trap to the kernel. The kernel sends > + a SIGSEGV to the task that resulted in this trap with the following > + info: > + > + siginfo.si_signo = SIGSEGV; > + siginfo.errno = 0; > + siginfo.si_code = SEGV_ADIDERR; > + siginfo.si_addr = addr; /* PC where first mismatch occurred */ > + siginfo.si_trapno = 0; > + > + > +Precise memory corruption > + > + When a store accesses a memory location that has TTE.mcd=1, > + the task is running with ADI enabled (PSTATE.mcde=1), and the ADI > + tag in the address used (bits 63:60) does not match the tag set on > + the corresponding cacheline, a memory corruption trap occurs. If > + MCD precise exception is enabled (MCDPERR=1), a precise > + exception is sent to the kernel with TT=0x1a. The kernel sends > + a SIGSEGV to the task that resulted in this trap with the following > + info: > + > + siginfo.si_signo = SIGSEGV; > + siginfo.errno = 0; > + siginfo.si_code = SEGV_ADIPERR; > + siginfo.si_addr = addr; /* address that caused trap */ > + siginfo.si_trapno = 0; > + > + NOTE: ADI tag mismatch on a load always results in precise trap. > + > + > +MCD disabled > + > + When a task has not enabled ADI and attempts to set ADI version > + on a memory address, processor sends an MCD disabled trap. This > + trap is handled by hypervisor first and the hypervisor vectors this > + trap through to the kernel as Data Access Exception trap with > + fault type set to 0xa (invalid ASI). When this occurs, the kernel > + sends the task SIGSEGV signal with following info: > + > + siginfo.si_signo = SIGSEGV; > + siginfo.errno = 0; > + siginfo.si_code = SEGV_ACCADI; > + siginfo.si_addr = addr; /* address that caused trap */ > + siginfo.si_trapno = 0; > + > + > +Sample program to use ADI > +------------------------- > + > +Following sample program is meant to illustrate how to use the ADI > +functionality. > + > +#include <unistd.h> > +#include <stdio.h> > +#include <stdlib.h> > +#include <elf.h> > +#include <sys/ipc.h> > +#include <sys/shm.h> > +#include <sys/mman.h> > +#include <asm/asi.h> > + > +#ifndef AT_ADI_BLKSZ > +#define AT_ADI_BLKSZ 48 > +#endif > +#ifndef AT_ADI_NBITS > +#define AT_ADI_NBITS 49 > +#endif > + > +#ifndef PROT_ADI > +#define PROT_ADI 0x10 > +#endif > + > +#define BUFFER_SIZE 32*1024*1024UL > + > +main(int argc, char* argv[], char* envp[]) > +{ > + unsigned long i, mcde, adi_blksz, adi_nbits; > + char *shmaddr, *tmp_addr, *end, *veraddr, *clraddr; > + int shmid, version; > + Elf64_auxv_t *auxv; > + > + adi_blksz = 0; > + > + while(*envp++ != NULL); > + for (auxv = (Elf64_auxv_t *)envp; auxv->a_type != AT_NULL; auxv++) { > + switch (auxv->a_type) { > + case AT_ADI_BLKSZ: > + adi_blksz = auxv->a_un.a_val; > + break; > + case AT_ADI_NBITS: > + adi_nbits = auxv->a_un.a_val; > + break; > + } > + } > + if (adi_blksz == 0) { > + fprintf(stderr, "Oops! ADI is not supported\n"); > + exit(1); > + } > + > + printf("ADI capabilities:\n"); > + printf("\tBlock size = %ld\n", adi_blksz); > + printf("\tNumber of bits = %ld\n", adi_nbits); > + > + if ((shmid = shmget(2, BUFFER_SIZE, > + IPC_CREAT | SHM_R | SHM_W)) < 0) { > + perror("shmget failed"); > + exit(1); > + } > + > + shmaddr = shmat(shmid, NULL, 0); > + if (shmaddr == (char *)-1) { > + perror("shm attach failed"); > + shmctl(shmid, IPC_RMID, NULL); > + exit(1); > + } > + > + if (mprotect(shmaddr, BUFFER_SIZE, PROT_READ|PROT_WRITE|PROT_ADI)) { > + perror("mprotect failed"); > + goto err_out; > + } > + > + /* Set the ADI version tag on the shm segment > + */ > + version = 10; > + tmp_addr = shmaddr; > + end = shmaddr + BUFFER_SIZE; > + while (tmp_addr < end) { > + asm volatile( > + "stxa %1, [%0]0x90\n\t" > + : > + : "r" (tmp_addr), "r" (version)); > + tmp_addr += adi_blksz; > + } > + asm volatile("membar #Sync\n\t"); > + > + /* Create a versioned address from the normal address by placing > + * version tag in the upper adi_nbits bits > + */ > + tmp_addr = (void *) ((unsigned long)shmaddr << adi_nbits); > + tmp_addr = (void *) ((unsigned long)tmp_addr >> adi_nbits); > + veraddr = (void *) (((unsigned long)version << (64-adi_nbits)) > + | (unsigned long)tmp_addr); > + > + printf("Starting the writes:\n"); > + for (i = 0; i < BUFFER_SIZE; i++) { > + veraddr[i] = (char)(i); > + if (!(i % (1024 * 1024))) > + printf("."); > + } > + printf("\n"); > + > + printf("Verifying data..."); > + fflush(stdout); > + for (i = 0; i < BUFFER_SIZE; i++) > + if (veraddr[i] != (char)i) > + printf("\nIndex %lu mismatched\n", i); > + printf("Done.\n"); > + > + /* Disable ADI and clean up > + */ > + if (mprotect(shmaddr, BUFFER_SIZE, PROT_READ|PROT_WRITE)) { > + perror("mprotect failed"); > + goto err_out; > + } > + > + if (shmdt((const void *)shmaddr) != 0) > + perror("Detach failure"); > + shmctl(shmid, IPC_RMID, NULL); > + > + exit(0); > + > +err_out: > + if (shmdt((const void *)shmaddr) != 0) > + perror("Detach failure"); > + shmctl(shmid, IPC_RMID, NULL); > + exit(1); > +} > diff --git a/arch/sparc/include/asm/mman.h b/arch/sparc/include/asm/mman.h > index 59bb5938d852..b799796ad963 100644 > --- a/arch/sparc/include/asm/mman.h > +++ b/arch/sparc/include/asm/mman.h > @@ -6,5 +6,75 @@ > #ifndef __ASSEMBLY__ > #define arch_mmap_check(addr,len,flags) sparc_mmap_check(addr,len) > int sparc_mmap_check(unsigned long addr, unsigned long len); > -#endif > + > +#ifdef CONFIG_SPARC64 > +#include <asm/adi_64.h> > + > +#define arch_calc_vm_prot_bits(prot, pkey) sparc_calc_vm_prot_bits(prot) > +static inline unsigned long sparc_calc_vm_prot_bits(unsigned long prot) > +{ > + if (prot & PROT_ADI) { > + struct pt_regs *regs; > + > + if (!current->mm->context.adi) { > + regs = task_pt_regs(current); > + regs->tstate |= TSTATE_MCDE; > + current->mm->context.adi = true; If a process is multi-threaded when it enables ADI on some memory for the first time, TSTATE_MCDE will only be set for the calling thread and it will not be possible to enable it for the other threads. One possible way to handle this is to enable TSTATE_MCDE for all user threads when they are initialized if adi_capable() returns true. > + } > + return VM_SPARC_ADI; > + } else { > + return 0; > + } > +} > + > +#define arch_vm_get_page_prot(vm_flags) sparc_vm_get_page_prot(vm_flags) > +static inline pgprot_t sparc_vm_get_page_prot(unsigned long vm_flags) > +{ > + return (vm_flags & VM_SPARC_ADI) ? __pgprot(_PAGE_MCD_4V) : __pgprot(0); > +} > + > +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) > +static inline int sparc_validate_prot(unsigned long prot, unsigned long addr) > +{ > + if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_ADI)) > + return 0; > + if (prot & PROT_ADI) { > + if (!adi_capable()) > + return 0; > + > + /* ADI tags can not be set on read-only memory, so it makes > + * sense to enable ADI on writable memory only. > + */ > + if (!(prot & PROT_WRITE)) > + return 0; This prevents the use of ADI for the legitimate case where shared memory is mapped read/write for a master process but mapped read-only for a client process. The master process could set the tags and communicate the expected tag values to the client. > + > + if (addr) { > + struct vm_area_struct *vma; > + > + vma = find_vma(current->mm, addr); > + if (vma) { > + /* ADI can not be enabled on PFN > + * mapped pages > + */ > + if (vma->vm_flags & (VM_PFNMAP | VM_MIXEDMAP)) > + return 0; > + > + /* Mergeable pages can become unmergeable > + * if ADI is enabled on them even if they > + * have identical data on them. This can be > + * because ADI enabled pages with identical > + * data may still not have identical ADI > + * tags on them. Disallow ADI on mergeable > + * pages. > + */ > + if (vma->vm_flags & VM_MERGEABLE) > + return 0; > + } > + } > + } > + return 1; > +} > +#endif /* CONFIG_SPARC64 */ > + > +#endif /* __ASSEMBLY__ */ > #endif /* __SPARC_MMAN_H__ */ > diff --git a/arch/sparc/include/asm/mmu_64.h b/arch/sparc/include/asm/mmu_64.h > index 83b36a5371ff..a65d51ebe00b 100644 > --- a/arch/sparc/include/asm/mmu_64.h > +++ b/arch/sparc/include/asm/mmu_64.h > @@ -89,6 +89,20 @@ struct tsb_config { > #define MM_NUM_TSBS 1 > #endif > > +/* ADI tags are stored when a page is swapped out and the storage for > + * tags is allocated dynamically. There is a tag storage descriptor > + * associated with each set of tag storage pages. Tag storage descriptors > + * are allocated dynamically. Since kernel will allocate a full page for > + * each tag storage descriptor, we can store up to > + * PAGE_SIZE/sizeof(tag storage descriptor) descriptors on that page. > + */ > +typedef struct { > + unsigned long start; /* Start address for this tag storage */ > + unsigned long end; /* Last address for tag storage */ > + unsigned char *tags; /* Where the tags are */ > + unsigned long tag_users; /* number of references to descriptor */ > +} tag_storage_desc_t; > + > typedef struct { > spinlock_t lock; > unsigned long sparc64_ctx_val; > @@ -96,6 +110,9 @@ typedef struct { > unsigned long thp_pte_count; > struct tsb_config tsb_block[MM_NUM_TSBS]; > struct hv_tsb_descr tsb_descr[MM_NUM_TSBS]; > + bool adi; > + tag_storage_desc_t *tag_store; > + spinlock_t tag_lock; > } mm_context_t; > > #endif /* !__ASSEMBLY__ */ > diff --git a/arch/sparc/include/asm/mmu_context_64.h b/arch/sparc/include/asm/mmu_context_64.h > index 2cddcda4f85f..68de059551f9 100644 > --- a/arch/sparc/include/asm/mmu_context_64.h > +++ b/arch/sparc/include/asm/mmu_context_64.h > @@ -9,6 +9,7 @@ > #include <linux/mm_types.h> > > #include <asm/spitfire.h> > +#include <asm/adi_64.h> > #include <asm-generic/mm_hooks.h> > > static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk) > @@ -129,6 +130,48 @@ static inline void switch_mm(struct mm_struct *old_mm, struct mm_struct *mm, str > > #define deactivate_mm(tsk,mm) do { } while (0) > #define activate_mm(active_mm, mm) switch_mm(active_mm, mm, NULL) > + > +#define __HAVE_ARCH_START_CONTEXT_SWITCH > +static inline void arch_start_context_switch(struct task_struct *prev) > +{ > + /* Save the current state of MCDPER register for the process > + * we are switching from > + */ > + if (adi_capable()) { > + register unsigned long tmp_mcdper; > + > + __asm__ __volatile__( > + ".word 0x83438000\n\t" /* rd %mcdper, %g1 */ > + "mov %%g1, %0\n\t" > + : "=r" (tmp_mcdper) > + : > + : "g1"); > + if (tmp_mcdper) > + set_tsk_thread_flag(prev, TIF_MCDPER); > + else > + clear_tsk_thread_flag(prev, TIF_MCDPER); > + } > +} > + > +#define finish_arch_post_lock_switch finish_arch_post_lock_switch > +static inline void finish_arch_post_lock_switch(void) > +{ > + /* Restore the state of MCDPER register for the new process > + * just switched to. > + */ > + if (adi_capable()) { > + register unsigned long tmp_mcdper; > + > + tmp_mcdper = test_thread_flag(TIF_MCDPER); > + __asm__ __volatile__( > + "mov %0, %%g1\n\t" > + ".word 0x9d800001\n\t" /* wr %g0, %g1, %mcdper" */ > + : > + : "ir" (tmp_mcdper) > + : "g1"); > + } > +} > + > #endif /* !(__ASSEMBLY__) */ > > #endif /* !(__SPARC64_MMU_CONTEXT_H) */ > diff --git a/arch/sparc/include/asm/page_64.h b/arch/sparc/include/asm/page_64.h > index 5961b2d8398a..dc582c5611f8 100644 > --- a/arch/sparc/include/asm/page_64.h > +++ b/arch/sparc/include/asm/page_64.h > @@ -46,6 +46,10 @@ struct page; > void clear_user_page(void *addr, unsigned long vaddr, struct page *page); > #define copy_page(X,Y) memcpy((void *)(X), (void *)(Y), PAGE_SIZE) > void copy_user_page(void *to, void *from, unsigned long vaddr, struct page *topage); > +#define __HAVE_ARCH_COPY_USER_HIGHPAGE > +struct vm_area_struct; > +void copy_user_highpage(struct page *to, struct page *from, > + unsigned long vaddr, struct vm_area_struct *vma); > > /* Unlike sparc32, sparc64's parameter passing API is more > * sane in that structures which as small enough are passed > diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h > index af045061f41e..51da342c392d 100644 > --- a/arch/sparc/include/asm/pgtable_64.h > +++ b/arch/sparc/include/asm/pgtable_64.h > @@ -18,6 +18,7 @@ > #include <asm/types.h> > #include <asm/spitfire.h> > #include <asm/asi.h> > +#include <asm/adi.h> > #include <asm/page.h> > #include <asm/processor.h> > > @@ -570,6 +571,18 @@ static inline pte_t pte_mkspecial(pte_t pte) > return pte; > } > > +static inline pte_t pte_mkmcd(pte_t pte) > +{ > + pte_val(pte) |= _PAGE_MCD_4V; > + return pte; > +} > + > +static inline pte_t pte_mknotmcd(pte_t pte) > +{ > + pte_val(pte) &= ~_PAGE_MCD_4V; > + return pte; > +} > + > static inline unsigned long pte_young(pte_t pte) > { > unsigned long mask; > @@ -1001,6 +1014,39 @@ int page_in_phys_avail(unsigned long paddr); > int remap_pfn_range(struct vm_area_struct *, unsigned long, unsigned long, > unsigned long, pgprot_t); > > +void adi_restore_tags(struct mm_struct *mm, struct vm_area_struct *vma, > + unsigned long addr, pte_t pte); > + > +int adi_save_tags(struct mm_struct *mm, struct vm_area_struct *vma, > + unsigned long addr, pte_t oldpte); > + > +#define __HAVE_ARCH_DO_SWAP_PAGE > +static inline void arch_do_swap_page(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long addr, > + pte_t pte, pte_t oldpte) > +{ > + /* If this is a new page being mapped in, there can be no > + * ADI tags stored away for this page. Skip looking for > + * stored tags > + */ > + if (pte_none(oldpte)) > + return; > + > + if (adi_state.enabled && (pte_val(pte) & _PAGE_MCD_4V)) > + adi_restore_tags(mm, vma, addr, pte); > +} > + > +#define __HAVE_ARCH_UNMAP_ONE > +static inline int arch_unmap_one(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long addr, pte_t oldpte) > +{ > + if (adi_state.enabled && (pte_val(oldpte) & _PAGE_MCD_4V)) > + return adi_save_tags(mm, vma, addr, oldpte); > + return 0; > +} > + > static inline int io_remap_pfn_range(struct vm_area_struct *vma, > unsigned long from, unsigned long pfn, > unsigned long size, pgprot_t prot) > diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h > index 38a24f257b85..9c04acb1f9af 100644 > --- a/arch/sparc/include/asm/thread_info_64.h > +++ b/arch/sparc/include/asm/thread_info_64.h > @@ -190,7 +190,7 @@ register struct thread_info *current_thread_info_reg asm("g6"); > * in using in assembly, else we can't use the mask as > * an immediate value in instructions such as andcc. > */ > -/* flag bit 12 is available */ > +#define TIF_MCDPER 12 /* Precise MCD exception */ > #define TIF_MEMDIE 13 /* is terminating due to OOM killer */ > #define TIF_POLLING_NRFLAG 14 > > diff --git a/arch/sparc/include/asm/trap_block.h b/arch/sparc/include/asm/trap_block.h > index ec9c04de3664..b283e940671a 100644 > --- a/arch/sparc/include/asm/trap_block.h > +++ b/arch/sparc/include/asm/trap_block.h > @@ -72,6 +72,8 @@ struct sun4v_1insn_patch_entry { > }; > extern struct sun4v_1insn_patch_entry __sun4v_1insn_patch, > __sun4v_1insn_patch_end; > +extern struct sun4v_1insn_patch_entry __sun_m7_1insn_patch, > + __sun_m7_1insn_patch_end; > > struct sun4v_2insn_patch_entry { > unsigned int addr; > diff --git a/arch/sparc/include/uapi/asm/mman.h b/arch/sparc/include/uapi/asm/mman.h > index 9765896ecb2c..a72c03397345 100644 > --- a/arch/sparc/include/uapi/asm/mman.h > +++ b/arch/sparc/include/uapi/asm/mman.h > @@ -5,6 +5,8 @@ > > /* SunOS'ified... */ > > +#define PROT_ADI 0x10 /* ADI enabled */ > + > #define MAP_RENAME MAP_ANONYMOUS /* In SunOS terminology */ > #define MAP_NORESERVE 0x40 /* don't reserve swap pages */ > #define MAP_INHERIT 0x80 /* SunOS doesn't do this, but... */ > diff --git a/arch/sparc/kernel/adi_64.c b/arch/sparc/kernel/adi_64.c > index 9fbb5dd4a7bf..83c1e36ae5fa 100644 > --- a/arch/sparc/kernel/adi_64.c > +++ b/arch/sparc/kernel/adi_64.c > @@ -7,10 +7,24 @@ > * This work is licensed under the terms of the GNU GPL, version 2. > */ > #include <linux/init.h> > +#include <linux/slab.h> > +#include <linux/mm_types.h> > #include <asm/mdesc.h> > #include <asm/adi_64.h> > +#include <asm/mmu_64.h> > +#include <asm/pgtable_64.h> > + > +/* Each page of storage for ADI tags can accommodate tags for 128 > + * pages. When ADI enabled pages are being swapped out, it would be > + * prudent to allocate at least enough tag storage space to accommodate > + * SWAPFILE_CLUSTER number of pages. Allocate enough tag storage to > + * store tags for four SWAPFILE_CLUSTER pages to reduce need for > + * further allocations for same vma. > + */ > +#define TAG_STORAGE_PAGES 8 > > struct adi_config adi_state; > +EXPORT_SYMBOL(adi_state); > > /* mdesc_adi_init() : Parse machine description provided by the > * hypervisor to detect ADI capabilities > @@ -78,6 +92,19 @@ void __init mdesc_adi_init(void) > goto adi_not_found; > adi_state.caps.nbits = *val; > > + /* Some of the code to support swapping ADI tags is written > + * assumption that two ADI tags can fit inside one byte. If > + * this assumption is broken by a future architecture change, > + * that code will have to be revisited. If that were to happen, > + * disable ADI support so we do not get unpredictable results > + * with programs trying to use ADI and their pages getting > + * swapped out > + */ > + if (adi_state.caps.nbits > 4) { > + pr_warn("WARNING: ADI tag size >4 on this platform. Disabling AADI support\n"); > + adi_state.enabled = false; > + } > + > mdesc_release(hp); > return; > > @@ -88,3 +115,253 @@ void __init mdesc_adi_init(void) > if (hp) > mdesc_release(hp); > } > + > +tag_storage_desc_t *find_tag_store(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long addr) > +{ > + tag_storage_desc_t *tag_desc = NULL; > + unsigned long i, max_desc, flags; > + > + /* Check if this vma already has tag storage descriptor > + * allocated for it. > + */ > + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); > + if (mm->context.tag_store) { > + tag_desc = mm->context.tag_store; > + spin_lock_irqsave(&mm->context.tag_lock, flags); > + for (i = 0; i < max_desc; i++) { > + if ((addr >= tag_desc->start) && > + ((addr + PAGE_SIZE - 1) <= tag_desc->end)) > + break; > + tag_desc++; > + } > + spin_unlock_irqrestore(&mm->context.tag_lock, flags); > + > + /* If no matching entries were found, this must be a > + * freshly allocated page > + */ > + if (i >= max_desc) > + tag_desc = NULL; > + } > + > + return tag_desc; > +} > + > +tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long addr) > +{ > + unsigned char *tags; > + unsigned long i, size, max_desc, flags; > + tag_storage_desc_t *tag_desc, *open_desc; > + unsigned long end_addr, hole_start, hole_end; > + > + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); > + open_desc = NULL; > + hole_start = 0; > + hole_end = ULONG_MAX; > + end_addr = addr + PAGE_SIZE - 1; > + > + /* Check if this vma already has tag storage descriptor > + * allocated for it. > + */ > + spin_lock_irqsave(&mm->context.tag_lock, flags); > + if (mm->context.tag_store) { > + tag_desc = mm->context.tag_store; > + > + /* Look for a matching entry for this address. While doing > + * that, look for the first open slot as well and find > + * the hole in already allocated range where this request > + * will fit in. > + */ > + for (i = 0; i < max_desc; i++) { > + if (tag_desc->tag_users == 0) { > + if (open_desc == NULL) > + open_desc = tag_desc; > + } else { > + if ((addr >= tag_desc->start) && > + (tag_desc->end >= (addr + PAGE_SIZE - 1))) { > + tag_desc->tag_users++; > + goto out; > + } > + } > + if ((tag_desc->start > end_addr) && > + (tag_desc->start < hole_end)) > + hole_end = tag_desc->start; > + if ((tag_desc->end < addr) && > + (tag_desc->end > hole_start)) > + hole_start = tag_desc->end; > + tag_desc++; > + } > + > + } else { > + size = sizeof(tag_storage_desc_t)*max_desc; > + mm->context.tag_store = kzalloc(size, GFP_NOIO|__GFP_NOWARN); The spin_lock_irqsave() above means that all but level 15 interrupts will be disabled when kzalloc() is called. If kzalloc() can sleep there's a risk of deadlock. > + if (mm->context.tag_store == NULL) { > + tag_desc = NULL; > + goto out; > + } > + tag_desc = mm->context.tag_store; > + for (i = 0; i < max_desc; i++, tag_desc++) > + tag_desc->tag_users = 0; > + open_desc = mm->context.tag_store; > + i = 0; > + } > + > + /* Check if we ran out of tag storage descriptors */ > + if (open_desc == NULL) { > + tag_desc = NULL; > + goto out; > + } > + > + /* Mark this tag descriptor slot in use and then initialize it */ > + tag_desc = open_desc; > + tag_desc->tag_users = 1; > + > + /* Tag storage has not been allocated for this vma and space > + * is available in tag storage descriptor. Since this page is > + * being swapped out, there is high probability subsequent pages > + * in the VMA will be swapped out as well. Allocates pages to > + * store tags for as many pages in this vma as possible but not > + * more than TAG_STORAGE_PAGES. Each byte in tag space holds > + * two ADI tags since each ADI tag is 4 bits. Each ADI tag > + * covers adi_blksize() worth of addresses. Check if the hole is > + * big enough to accommodate full address range for using > + * TAG_STORAGE_PAGES number of tag pages. > + */ > + size = TAG_STORAGE_PAGES * PAGE_SIZE; > + end_addr = addr + (size*2*adi_blksize()) - 1; Since size > PAGE_SIZE, end_addr could theoretically overflow. > + if (hole_end < end_addr) { > + /* Available hole is too small on the upper end of > + * address. Can we expand the range towards the lower > + * address and maximize use of this slot? > + */ > + unsigned long tmp_addr; > + > + end_addr = hole_end - 1; > + tmp_addr = end_addr - (size*2*adi_blksize()) + 1; Similarily, tmp_addr may underflow. > + if (tmp_addr < hole_start) { > + /* Available hole is restricted on lower address > + * end as well > + */ > + tmp_addr = hole_start + 1; > + } > + addr = tmp_addr; > + size = (end_addr + 1 - addr)/(2*adi_blksize()); > + size = (size + (PAGE_SIZE-adi_blksize()))/PAGE_SIZE; > + size = size * PAGE_SIZE; > + } > + tags = kzalloc(size, GFP_NOIO|__GFP_NOWARN); Potential deadlock due to PIL=14? > + if (tags == NULL) { > + tag_desc->tag_users = 0; > + tag_desc = NULL; > + goto out; > + } > + tag_desc->start = addr; > + tag_desc->tags = tags; > + tag_desc->end = end_addr; > + > +out: > + spin_unlock_irqrestore(&mm->context.tag_lock, flags); > + return tag_desc; > +} > + > +void del_tag_store(tag_storage_desc_t *tag_desc, struct mm_struct *mm) > +{ > + unsigned long flags; > + unsigned char *tags = NULL; > + > + spin_lock_irqsave(&mm->context.tag_lock, flags); > + tag_desc->tag_users--; > + if (tag_desc->tag_users == 0) { > + tag_desc->start = tag_desc->end = 0; > + /* Do not free up the tag storage space allocated > + * by the first descriptor. This is persistent > + * emergency tag storage space for the task. > + */ > + if (tag_desc != mm->context.tag_store) { > + tags = tag_desc->tags; > + tag_desc->tags = NULL; > + } > + } > + spin_unlock_irqrestore(&mm->context.tag_lock, flags); > + kfree(tags); > +} > + > +#define tag_start(addr, tag_desc) \ > + ((tag_desc)->tags + ((addr - (tag_desc)->start)/(2*adi_blksize()))) > + > +/* Retrieve any saved ADI tags for the page being swapped back in and > + * restore these tags to the newly allocated physical page. > + */ > +void adi_restore_tags(struct mm_struct *mm, struct vm_area_struct *vma, > + unsigned long addr, pte_t pte) > +{ > + unsigned char *tag; > + tag_storage_desc_t *tag_desc; > + unsigned long paddr, tmp, version1, version2; > + > + /* Check if the swapped out page has an ADI version > + * saved. If yes, restore version tag to the newly > + * allocated page. > + */ > + tag_desc = find_tag_store(mm, vma, addr); > + if (tag_desc == NULL) > + return; > + > + tag = tag_start(addr, tag_desc); > + paddr = pte_val(pte) & _PAGE_PADDR_4V; > + for (tmp = paddr; tmp < (paddr+PAGE_SIZE); tmp += adi_blksize()) { > + version1 = (*tag) >> 4; > + version2 = (*tag) & 0x0f; > + *tag++ = 0; > + asm volatile("stxa %0, [%1] %2\n\t" > + : > + : "r" (version1), "r" (tmp), > + "i" (ASI_MCD_REAL)); > + tmp += adi_blksize(); > + asm volatile("stxa %0, [%1] %2\n\t" > + : > + : "r" (version2), "r" (tmp), > + "i" (ASI_MCD_REAL)); > + } > + asm volatile("membar #Sync\n\t"); > + > + /* Check and mark this tag space for release later if > + * the swapped in page was the last user of tag space > + */ > + del_tag_store(tag_desc, mm); > +} > + > +/* A page is about to be swapped out. Save any ADI tags associated with > + * this physical page so they can be restored later when the page is swapped > + * back in. > + */ > +int adi_save_tags(struct mm_struct *mm, struct vm_area_struct *vma, > + unsigned long addr, pte_t oldpte) > +{ > + unsigned char *tag; > + tag_storage_desc_t *tag_desc; > + unsigned long version1, version2, paddr, tmp; > + > + tag_desc = alloc_tag_store(mm, vma, addr); > + if (tag_desc == NULL) > + return -1; > + > + tag = tag_start(addr, tag_desc); > + paddr = pte_val(oldpte) & _PAGE_PADDR_4V; > + for (tmp = paddr; tmp < (paddr+PAGE_SIZE); tmp += adi_blksize()) { > + asm volatile("ldxa [%1] %2, %0\n\t" > + : "=r" (version1) > + : "r" (tmp), "i" (ASI_MCD_REAL)); > + tmp += adi_blksize(); > + asm volatile("ldxa [%1] %2, %0\n\t" > + : "=r" (version2) > + : "r" (tmp), "i" (ASI_MCD_REAL)); > + *tag = (version1 << 4) | version2; > + tag++; > + } > + > + return 0; > +} > diff --git a/arch/sparc/kernel/etrap_64.S b/arch/sparc/kernel/etrap_64.S > index 1276ca2567ba..7be33bf45cff 100644 > --- a/arch/sparc/kernel/etrap_64.S > +++ b/arch/sparc/kernel/etrap_64.S > @@ -132,7 +132,33 @@ etrap_save: save %g2, -STACK_BIAS, %sp > stx %g6, [%sp + PTREGS_OFF + PT_V9_G6] > stx %g7, [%sp + PTREGS_OFF + PT_V9_G7] > or %l7, %l0, %l7 > - sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 > +661: sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 > + /* > + * If userspace is using ADI, it could potentially pass > + * a pointer with version tag embedded in it. To maintain > + * the ADI security, we must enable PSTATE.mcde. Userspace > + * would have already set TTE.mcd in an earlier call to > + * kernel and set the version tag for the address being > + * dereferenced. Setting PSTATE.mcde would ensure any > + * access to userspace data through a system call honors > + * ADI and does not allow a rogue app to bypass ADI by > + * using system calls. Setting PSTATE.mcde only affects > + * accesses to virtual addresses that have TTE.mcd set. > + * Set PMCDPER to ensure any exceptions caused by ADI > + * version tag mismatch are exposed before system call > + * returns to userspace. Setting PMCDPER affects only > + * writes to virtual addresses that have TTE.mcd set and > + * have a version tag set as well. > + */ > + .section .sun_m7_1insn_patch, "ax" > + .word 661b > + sethi %hi(TSTATE_TSO | TSTATE_PEF | TSTATE_MCDE), %l0 > + .previous > +661: nop > + .section .sun_m7_1insn_patch, "ax" > + .word 661b > + .word 0xaf902001 /* wrpr %g0, 1, %pmcdper */ I commented on this on the last patch series revision. PMCDPER could be set once when each CPU is configured rather than every time the kernel is entered. Since it's never cleared, setting it repeatedly unnecessarily impacts the performance of etrap. Also, there are places in rtrap where PSTATE is set before continuing execution in the kernel. These should also be patched to set TSTATE_MCDE. > + .previous > or %l7, %l0, %l7 > wrpr %l2, %tnpc > wrpr %l7, (TSTATE_PRIV | TSTATE_IE), %tstate > diff --git a/arch/sparc/kernel/process_64.c b/arch/sparc/kernel/process_64.c > index b96104da5bd6..defa5723dfa6 100644 > --- a/arch/sparc/kernel/process_64.c > +++ b/arch/sparc/kernel/process_64.c > @@ -664,6 +664,31 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, > return 0; > } > > +/* TIF_MCDPER in thread info flags for current task is updated lazily upon > + * a context switch. Update the this flag in current task's thread flags > + * before dup so the dup'd task will inherit the current TIF_MCDPER flag. > + */ > +int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src) > +{ > + if (adi_capable()) { > + register unsigned long tmp_mcdper; > + > + __asm__ __volatile__( > + ".word 0x83438000\n\t" /* rd %mcdper, %g1 */ > + "mov %%g1, %0\n\t" > + : "=r" (tmp_mcdper) > + : > + : "g1"); > + if (tmp_mcdper) > + set_thread_flag(TIF_MCDPER); > + else > + clear_thread_flag(TIF_MCDPER); > + } > + > + *dst = *src; > + return 0; > +} > + > typedef struct { > union { > unsigned int pr_regs[32]; > diff --git a/arch/sparc/kernel/setup_64.c b/arch/sparc/kernel/setup_64.c > index 422b17880955..a9da205da394 100644 > --- a/arch/sparc/kernel/setup_64.c > +++ b/arch/sparc/kernel/setup_64.c > @@ -240,6 +240,12 @@ void sun4v_patch_1insn_range(struct sun4v_1insn_patch_entry *start, > } > } > > +void sun_m7_patch_1insn_range(struct sun4v_1insn_patch_entry *start, > + struct sun4v_1insn_patch_entry *end) > +{ > + sun4v_patch_1insn_range(start, end); > +} > + > void sun4v_patch_2insn_range(struct sun4v_2insn_patch_entry *start, > struct sun4v_2insn_patch_entry *end) > { > @@ -289,9 +295,12 @@ static void __init sun4v_patch(void) > sun4v_patch_2insn_range(&__sun4v_2insn_patch, > &__sun4v_2insn_patch_end); > if (sun4v_chip_type == SUN4V_CHIP_SPARC_M7 || > - sun4v_chip_type == SUN4V_CHIP_SPARC_SN) > + sun4v_chip_type == SUN4V_CHIP_SPARC_SN) { > + sun_m7_patch_1insn_range(&__sun_m7_1insn_patch, > + &__sun_m7_1insn_patch_end); > sun_m7_patch_2insn_range(&__sun_m7_2insn_patch, > &__sun_m7_2insn_patch_end); Why not call sun4v_patch_1insn_range() and sun4v_patch_2insn_range() here instead of adding new functions that just call these functions? Anthony > + } > > sun4v_hvapi_init(); > } > diff --git a/arch/sparc/kernel/vmlinux.lds.S b/arch/sparc/kernel/vmlinux.lds.S > index 572db686f845..20a70682cce7 100644 > --- a/arch/sparc/kernel/vmlinux.lds.S > +++ b/arch/sparc/kernel/vmlinux.lds.S > @@ -144,6 +144,11 @@ SECTIONS > *(.pause_3insn_patch) > __pause_3insn_patch_end = .; > } > + .sun_m7_1insn_patch : { > + __sun_m7_1insn_patch = .; > + *(.sun_m7_1insn_patch) > + __sun_m7_1insn_patch_end = .; > + } > .sun_m7_2insn_patch : { > __sun_m7_2insn_patch = .; > *(.sun_m7_2insn_patch) > diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c > index cd0e32bbcb1d..579f7ae75b35 100644 > --- a/arch/sparc/mm/gup.c > +++ b/arch/sparc/mm/gup.c > @@ -11,6 +11,7 @@ > #include <linux/pagemap.h> > #include <linux/rwsem.h> > #include <asm/pgtable.h> > +#include <asm/adi.h> > > /* > * The performance critical leaf functions are made noinline otherwise gcc > @@ -157,6 +158,24 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write, > pgd_t *pgdp; > int nr = 0; > > +#ifdef CONFIG_SPARC64 > + if (adi_capable()) { > + long addr = start; > + > + /* If userspace has passed a versioned address, kernel > + * will not find it in the VMAs since it does not store > + * the version tags in the list of VMAs. Storing version > + * tags in list of VMAs is impractical since they can be > + * changed any time from userspace without dropping into > + * kernel. Any address search in VMAs will be done with > + * non-versioned addresses. Ensure the ADI version bits > + * are dropped here by sign extending the last bit before > + * ADI bits. IOMMU does not implement version tags. > + */ > + addr = (addr << (long)adi_nbits()) >> (long)adi_nbits(); > + start = addr; > + } > +#endif > start &= PAGE_MASK; > addr = start; > len = (unsigned long) nr_pages << PAGE_SHIFT; > @@ -187,6 +206,24 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, > pgd_t *pgdp; > int nr = 0; > > +#ifdef CONFIG_SPARC64 > + if (adi_capable()) { > + long addr = start; > + > + /* If userspace has passed a versioned address, kernel > + * will not find it in the VMAs since it does not store > + * the version tags in the list of VMAs. Storing version > + * tags in list of VMAs is impractical since they can be > + * changed any time from userspace without dropping into > + * kernel. Any address search in VMAs will be done with > + * non-versioned addresses. Ensure the ADI version bits > + * are dropped here by sign extending the last bit before > + * ADI bits. IOMMU does not implements version tags, > + */ > + addr = (addr << (long)adi_nbits()) >> (long)adi_nbits(); > + start = addr; > + } > +#endif > start &= PAGE_MASK; > addr = start; > len = (unsigned long) nr_pages << PAGE_SHIFT; > diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c > index 88855e383b34..487ed1f1ce86 100644 > --- a/arch/sparc/mm/hugetlbpage.c > +++ b/arch/sparc/mm/hugetlbpage.c > @@ -177,8 +177,20 @@ pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma, > struct page *page, int writeable) > { > unsigned int shift = huge_page_shift(hstate_vma(vma)); > + pte_t pte; > > - return hugepage_shift_to_tte(entry, shift); > + pte = hugepage_shift_to_tte(entry, shift); > + > +#ifdef CONFIG_SPARC64 > + /* If this vma has ADI enabled on it, turn on TTE.mcd > + */ > + if (vma->vm_flags & VM_SPARC_ADI) > + return pte_mkmcd(pte); > + else > + return pte_mknotmcd(pte); > +#else > + return pte; > +#endif > } > > static unsigned int sun4v_huge_tte_to_shift(pte_t entry) > diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c > index 3c40ebd50f92..94854e7e833e 100644 > --- a/arch/sparc/mm/init_64.c > +++ b/arch/sparc/mm/init_64.c > @@ -3087,3 +3087,36 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) > do_flush_tlb_kernel_range(start, end); > } > } > + > +void copy_user_highpage(struct page *to, struct page *from, > + unsigned long vaddr, struct vm_area_struct *vma) > +{ > + char *vfrom, *vto; > + > + vfrom = kmap_atomic(from); > + vto = kmap_atomic(to); > + copy_user_page(vto, vfrom, vaddr, to); > + kunmap_atomic(vto); > + kunmap_atomic(vfrom); > + > + /* If this page has ADI enabled, copy over any ADI tags > + * as well > + */ > + if (vma->vm_flags & VM_SPARC_ADI) { > + unsigned long pfrom, pto, i, adi_tag; > + > + pfrom = page_to_phys(from); > + pto = page_to_phys(to); > + > + for (i = pfrom; i < (pfrom + PAGE_SIZE); i += adi_blksize()) { > + asm volatile("ldxa [%1] %2, %0\n\t" > + : "=r" (adi_tag) > + : "r" (i), "i" (ASI_MCD_REAL)); > + asm volatile("stxa %0, [%1] %2\n\t" > + : > + : "r" (adi_tag), "r" (pto), > + "i" (ASI_MCD_REAL)); > + pto += adi_blksize(); > + } > + } > +} > diff --git a/arch/sparc/mm/tsb.c b/arch/sparc/mm/tsb.c > index 0d4b998c7d7b..6518cc42056b 100644 > --- a/arch/sparc/mm/tsb.c > +++ b/arch/sparc/mm/tsb.c > @@ -545,6 +545,9 @@ int init_new_context(struct task_struct *tsk, struct mm_struct *mm) > > mm->context.sparc64_ctx_val = 0UL; > > + mm->context.tag_store = NULL; > + spin_lock_init(&mm->context.tag_lock); > + > #if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE) > /* We reset them to zero because the fork() page copying > * will re-increment the counters as the parent PTEs are > @@ -610,4 +613,22 @@ void destroy_context(struct mm_struct *mm) > } > > spin_unlock_irqrestore(&ctx_alloc_lock, flags); > + > + /* If ADI tag storage was allocated for this task, free it */ > + if (mm->context.tag_store) { > + tag_storage_desc_t *tag_desc; > + unsigned long max_desc; > + unsigned char *tags; > + > + tag_desc = mm->context.tag_store; > + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); > + for (i = 0; i < max_desc; i++) { > + tags = tag_desc->tags; > + tag_desc->tags = NULL; > + kfree(tags); > + tag_desc++; > + } > + kfree(mm->context.tag_store); > + mm->context.tag_store = NULL; > + } > } > diff --git a/include/linux/mm.h b/include/linux/mm.h > index b7aa3932e6d4..c0972114036f 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -231,6 +231,9 @@ extern unsigned int kobjsize(const void *objp); > # define VM_GROWSUP VM_ARCH_1 > #elif defined(CONFIG_IA64) > # define VM_GROWSUP VM_ARCH_1 > +#elif defined(CONFIG_SPARC64) > +# define VM_SPARC_ADI VM_ARCH_1 /* Uses ADI tag for access control */ > +# define VM_ARCH_CLEAR VM_SPARC_ADI > #elif !defined(CONFIG_MMU) > # define VM_MAPPED_COPY VM_ARCH_1 /* T if mapped copy of data (nommu mmap) */ > #endif > diff --git a/mm/ksm.c b/mm/ksm.c > index 216184af0e19..bb82399816ef 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1797,6 +1797,10 @@ int ksm_madvise(struct vm_area_struct *vma, unsigned long start, > if (*vm_flags & VM_SAO) > return 0; > #endif > +#ifdef VM_SPARC_ADI > + if (*vm_flags & VM_SPARC_ADI) > + return 0; > +#endif > > if (!test_bit(MMF_VM_MERGEABLE, &mm->flags)) { > err = __ksm_enter(mm); > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe sparclinux" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Anthony, Thanks for taking the time to provide feedback. My comments inline below. On 08/25/2017 04:31 PM, Anthony Yznaga wrote: > >> On Aug 9, 2017, at 2:26 PM, Khalid Aziz <khalid.aziz@oracle.com> wrote: >> ......deleted...... >> +provided by the hypervisor to the kernel. Kernel returns the value of >> +ADI block size to userspace using auxiliary vector along with other ADI >> +info. Following auxiliary vectors are provided by the kernel: >> + >> + AT_ADI_BLKSZ ADI block size. This is the granularity and >> + alignment, in bytes, of ADI versioning. >> + AT_ADI_NBITS Number of ADI version bits in the VA > > The previous patch series also defined AT_ADI_UEONADI. Why was that > removed? This was based upon a conversation we had when you mentioned future processors may not implement this or change the way this is interpreted and any applications depending upon this value would break at that point. I removed it to eliminate building an unreliable dependency. If I misunderstood what you said, please let me know. > >> + >> + >> +IMPORTANT NOTES: >> + >> +- Version tag values of 0x0 and 0xf are reserved. > > The documentation should probably state more specifically that an > in-memory tag value of 0x0 or 0xf is treated as "match all" by the HW > meaning that a mismatch exception will never be generated regardless > of the tag bits set in the VA accessing the memory. Will do. > >> + >> +- Version tags are set on virtual addresses from userspace even though >> + tags are stored in physical memory. Tags are set on a physical page >> + after it has been allocated to a task and a pte has been created for >> + it. >> + >> +- When a task frees a memory page it had set version tags on, the page >> + goes back to free page pool. When this page is re-allocated to a task, >> + kernel clears the page using block initialization ASI which clears the >> + version tags as well for the page. If a page allocated to a task is >> + freed and allocated back to the same task, old version tags set by the >> + task on that page will no longer be present. > > The specifics should be included here, too, so someone doesn't have > to guess what's going on if they make changes and the tags are no longer > cleared. The HW clears the tag for a cacheline for block initializing > stores to 64-byte aligned addresses if PSTATE.mcde=0 or TTE.mcd=0. > PSTATE.mce is set when executing in the kernel, but pages are cleared > using kernel physical mapping VAs which are mapped with TTE.mcd=0. > > Another HW behavior that should be mentioned is that tag mismatches > are not detected for non-faulting loads. Sure, I can add that. > >> + >> +- Kernel does not set any tags for user pages and it is entirely a >> + task's responsibility to set any version tags. Kernel does ensure the >> + version tags are preserved if a page is swapped out to the disk and >> + swapped back in. It also preserves that version tags if a page is >> + migrated. > > I only have a cursory understanding of how page migration works, but > I could not see how the tags would be preserved if a page were migrated. > I figured the place to copy the tags would be migrate_page_copy(), but > I don't see changes there. > > For migrating user pages, the way I understand the code works is if the page is mapped (which is the only time ADI tags are even in place), try_to_unmap() is called with TTU_MIGRATION flag set. try_to_unmap() will call arch_unmap_one() which saves the tags from currently mapped page. When the new page has been allocated, contents of the old page are faulted in through do_swap_page() which will call arch_do_swap_page(). arch_do_swap_page() then restores the ADI tags. >> diff --git a/arch/sparc/include/asm/mman.h b/arch/sparc/include/asm/mman.h >> index 59bb5938d852..b799796ad963 100644 >> --- a/arch/sparc/include/asm/mman.h >> +++ b/arch/sparc/include/asm/mman.h >> @@ -6,5 +6,75 @@ >> #ifndef __ASSEMBLY__ >> #define arch_mmap_check(addr,len,flags) sparc_mmap_check(addr,len) >> int sparc_mmap_check(unsigned long addr, unsigned long len); >> -#endif >> + >> +#ifdef CONFIG_SPARC64 >> +#include <asm/adi_64.h> >> + >> +#define arch_calc_vm_prot_bits(prot, pkey) sparc_calc_vm_prot_bits(prot) >> +static inline unsigned long sparc_calc_vm_prot_bits(unsigned long prot) >> +{ >> + if (prot & PROT_ADI) { >> + struct pt_regs *regs; >> + >> + if (!current->mm->context.adi) { >> + regs = task_pt_regs(current); >> + regs->tstate |= TSTATE_MCDE; >> + current->mm->context.adi = true; > > If a process is multi-threaded when it enables ADI on some memory for > the first time, TSTATE_MCDE will only be set for the calling thread > and it will not be possible to enable it for the other threads. > One possible way to handle this is to enable TSTATE_MCDE for all user > threads when they are initialized if adi_capable() returns true. > Or set TSTATE_MCDE unconditionally here by removing "if (!current->mm->context.adi)"? > >> + } >> + return VM_SPARC_ADI; >> + } else { >> + return 0; >> + } >> +} >> + >> +#define arch_vm_get_page_prot(vm_flags) sparc_vm_get_page_prot(vm_flags) >> +static inline pgprot_t sparc_vm_get_page_prot(unsigned long vm_flags) >> +{ >> + return (vm_flags & VM_SPARC_ADI) ? __pgprot(_PAGE_MCD_4V) : __pgprot(0); >> +} >> + >> +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) >> +static inline int sparc_validate_prot(unsigned long prot, unsigned long addr) >> +{ >> + if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_ADI)) >> + return 0; >> + if (prot & PROT_ADI) { >> + if (!adi_capable()) >> + return 0; >> + >> + /* ADI tags can not be set on read-only memory, so it makes >> + * sense to enable ADI on writable memory only. >> + */ >> + if (!(prot & PROT_WRITE)) >> + return 0; > > This prevents the use of ADI for the legitimate case where shared memory > is mapped read/write for a master process but mapped read-only for a > client process. The master process could set the tags and communicate > the expected tag values to the client. A non-writable mapping can access the shared memory using non-ADI tagged addresses if it does not enable ADI on its mappings, so it is superfluous to even allow enabling ADI. I can remove this if that helps any use cases that wouldn't work with above condition. >> +tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm, >> + struct vm_area_struct *vma, >> + unsigned long addr) >> +{ >> + unsigned char *tags; >> + unsigned long i, size, max_desc, flags; >> + tag_storage_desc_t *tag_desc, *open_desc; >> + unsigned long end_addr, hole_start, hole_end; >> + >> + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); >> + open_desc = NULL; >> + hole_start = 0; >> + hole_end = ULONG_MAX; >> + end_addr = addr + PAGE_SIZE - 1; >> + >> + /* Check if this vma already has tag storage descriptor >> + * allocated for it. >> + */ >> + spin_lock_irqsave(&mm->context.tag_lock, flags); >> + if (mm->context.tag_store) { >> + tag_desc = mm->context.tag_store; >> + >> + /* Look for a matching entry for this address. While doing >> + * that, look for the first open slot as well and find >> + * the hole in already allocated range where this request >> + * will fit in. >> + */ >> + for (i = 0; i < max_desc; i++) { >> + if (tag_desc->tag_users == 0) { >> + if (open_desc == NULL) >> + open_desc = tag_desc; >> + } else { >> + if ((addr >= tag_desc->start) && >> + (tag_desc->end >= (addr + PAGE_SIZE - 1))) { >> + tag_desc->tag_users++; >> + goto out; >> + } >> + } >> + if ((tag_desc->start > end_addr) && >> + (tag_desc->start < hole_end)) >> + hole_end = tag_desc->start; >> + if ((tag_desc->end < addr) && >> + (tag_desc->end > hole_start)) >> + hole_start = tag_desc->end; >> + tag_desc++; >> + } >> + >> + } else { >> + size = sizeof(tag_storage_desc_t)*max_desc; >> + mm->context.tag_store = kzalloc(size, GFP_NOIO|__GFP_NOWARN); > > The spin_lock_irqsave() above means that all but level 15 interrupts > will be disabled when kzalloc() is called. If kzalloc() can sleep > there's a risk of deadlock. I could call kzalloc() with GFP_NOWAIT instead of GFP_NOIO. Would that address the risk of deadlock? > > >> + if (mm->context.tag_store == NULL) { >> + tag_desc = NULL; >> + goto out; >> + } >> + tag_desc = mm->context.tag_store; >> + for (i = 0; i < max_desc; i++, tag_desc++) >> + tag_desc->tag_users = 0; >> + open_desc = mm->context.tag_store; >> + i = 0; >> + } >> + >> + /* Check if we ran out of tag storage descriptors */ >> + if (open_desc == NULL) { >> + tag_desc = NULL; >> + goto out; >> + } >> + >> + /* Mark this tag descriptor slot in use and then initialize it */ >> + tag_desc = open_desc; >> + tag_desc->tag_users = 1; >> + >> + /* Tag storage has not been allocated for this vma and space >> + * is available in tag storage descriptor. Since this page is >> + * being swapped out, there is high probability subsequent pages >> + * in the VMA will be swapped out as well. Allocates pages to >> + * store tags for as many pages in this vma as possible but not >> + * more than TAG_STORAGE_PAGES. Each byte in tag space holds >> + * two ADI tags since each ADI tag is 4 bits. Each ADI tag >> + * covers adi_blksize() worth of addresses. Check if the hole is >> + * big enough to accommodate full address range for using >> + * TAG_STORAGE_PAGES number of tag pages. >> + */ >> + size = TAG_STORAGE_PAGES * PAGE_SIZE; >> + end_addr = addr + (size*2*adi_blksize()) - 1; > > Since size > PAGE_SIZE, end_addr could theoretically overflow > > >> + if (hole_end < end_addr) { >> + /* Available hole is too small on the upper end of >> + * address. Can we expand the range towards the lower >> + * address and maximize use of this slot? >> + */ >> + unsigned long tmp_addr; >> + >> + end_addr = hole_end - 1; >> + tmp_addr = end_addr - (size*2*adi_blksize()) + 1; > > Similarily, tmp_addr may underflow. I will add checks for these two. > >> + if (tmp_addr < hole_start) { >> + /* Available hole is restricted on lower address >> + * end as well >> + */ >> + tmp_addr = hole_start + 1; >> + } >> + addr = tmp_addr; >> + size = (end_addr + 1 - addr)/(2*adi_blksize()); >> + size = (size + (PAGE_SIZE-adi_blksize()))/PAGE_SIZE; >> + size = size * PAGE_SIZE; >> + } >> + tags = kzalloc(size, GFP_NOIO|__GFP_NOWARN); > > Potential deadlock due to PIL=14? Same as above - call kzalloc() with GFP_NOWAIT? >> diff --git a/arch/sparc/kernel/etrap_64.S b/arch/sparc/kernel/etrap_64.S >> index 1276ca2567ba..7be33bf45cff 100644 >> --- a/arch/sparc/kernel/etrap_64.S >> +++ b/arch/sparc/kernel/etrap_64.S >> @@ -132,7 +132,33 @@ etrap_save: save %g2, -STACK_BIAS, %sp >> stx %g6, [%sp + PTREGS_OFF + PT_V9_G6] >> stx %g7, [%sp + PTREGS_OFF + PT_V9_G7] >> or %l7, %l0, %l7 >> - sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 >> +661: sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 >> + /* >> + * If userspace is using ADI, it could potentially pass >> + * a pointer with version tag embedded in it. To maintain >> + * the ADI security, we must enable PSTATE.mcde. Userspace >> + * would have already set TTE.mcd in an earlier call to >> + * kernel and set the version tag for the address being >> + * dereferenced. Setting PSTATE.mcde would ensure any >> + * access to userspace data through a system call honors >> + * ADI and does not allow a rogue app to bypass ADI by >> + * using system calls. Setting PSTATE.mcde only affects >> + * accesses to virtual addresses that have TTE.mcd set. >> + * Set PMCDPER to ensure any exceptions caused by ADI >> + * version tag mismatch are exposed before system call >> + * returns to userspace. Setting PMCDPER affects only >> + * writes to virtual addresses that have TTE.mcd set and >> + * have a version tag set as well. >> + */ >> + .section .sun_m7_1insn_patch, "ax" >> + .word 661b >> + sethi %hi(TSTATE_TSO | TSTATE_PEF | TSTATE_MCDE), %l0 >> + .previous >> +661: nop >> + .section .sun_m7_1insn_patch, "ax" >> + .word 661b >> + .word 0xaf902001 /* wrpr %g0, 1, %pmcdper */ > > I commented on this on the last patch series revision. PMCDPER could be > set once when each CPU is configured rather than every time the kernel > is entered. Since it's never cleared, setting it repeatedly unnecessarily > impacts the performance of etrap. Yes, you did and I thought I had addressed it in that thread: ">> I considered that possibility. What made me uncomfortable with that is there is no way to prevent a driver/module or future code elsewhere in kernel from clearing PMCDPER with possibly good reason. If that were to happen, setting PMCDPER here ensures kernel will always see consistent behavior with system calls. It does come at a cost. Is that cost unacceptable to ensure consistent behavior? > > Aren't you still at risk if the thread relinquishes the CPU while in the kernel and is then rescheduled on a CPU where PMCDPER has erroneously been left cleared? You may need to save and restore PMCDPER as well as MCDPER on context switch, but I don't know if that will cover you completely. > " I should add setting PMCDPER to 1 in finish_arch_post_lock_switch() to address the possibility you had mentioned. > > Also, there are places in rtrap where PSTATE is set before continuing > execution in the kernel. These should also be patched to set TSTATE_MCDE. > I will find and fix those. >> diff --git a/arch/sparc/kernel/setup_64.c b/arch/sparc/kernel/setup_64.c >> index 422b17880955..a9da205da394 100644 >> --- a/arch/sparc/kernel/setup_64.c >> +++ b/arch/sparc/kernel/setup_64.c >> @@ -240,6 +240,12 @@ void sun4v_patch_1insn_range(struct sun4v_1insn_patch_entry *start, >> } >> } >> >> +void sun_m7_patch_1insn_range(struct sun4v_1insn_patch_entry *start, >> + struct sun4v_1insn_patch_entry *end) >> +{ >> + sun4v_patch_1insn_range(start, end); >> +} >> + >> void sun4v_patch_2insn_range(struct sun4v_2insn_patch_entry *start, >> struct sun4v_2insn_patch_entry *end) >> { >> @@ -289,9 +295,12 @@ static void __init sun4v_patch(void) >> sun4v_patch_2insn_range(&__sun4v_2insn_patch, >> &__sun4v_2insn_patch_end); >> if (sun4v_chip_type == SUN4V_CHIP_SPARC_M7 || >> - sun4v_chip_type == SUN4V_CHIP_SPARC_SN) >> + sun4v_chip_type == SUN4V_CHIP_SPARC_SN) { >> + sun_m7_patch_1insn_range(&__sun_m7_1insn_patch, >> + &__sun_m7_1insn_patch_end); >> sun_m7_patch_2insn_range(&__sun_m7_2insn_patch, >> &__sun_m7_2insn_patch_end); > > Why not call sun4v_patch_1insn_range() and sun4v_patch_2insn_range() > here instead of adding new functions that just call these functions? Sounds reasonable, I can change that. Thanks, Khalid -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Khalid Aziz <khalid.aziz@oracle.com> Date: Wed, 30 Aug 2017 16:27:54 -0600 >>> +#define arch_calc_vm_prot_bits(prot, pkey) >>> sparc_calc_vm_prot_bits(prot) >>> +static inline unsigned long sparc_calc_vm_prot_bits(unsigned long >>> prot) >>> +{ >>> + if (prot & PROT_ADI) { >>> + struct pt_regs *regs; >>> + >>> + if (!current->mm->context.adi) { >>> + regs = task_pt_regs(current); >>> + regs->tstate |= TSTATE_MCDE; >>> + current->mm->context.adi = true; >> If a process is multi-threaded when it enables ADI on some memory for >> the first time, TSTATE_MCDE will only be set for the calling thread >> and it will not be possible to enable it for the other threads. >> One possible way to handle this is to enable TSTATE_MCDE for all user >> threads when they are initialized if adi_capable() returns true. >> > > Or set TSTATE_MCDE unconditionally here by removing "if > (!current->mm->context.adi)"? I think you have to make "ADI enabled" a property of the mm_struct. Then you can broadcast to mm->cpu_vm_mask a per-cpu interrupt that updates regs->tstate of a thread using 'mm' is currently executing. And in the context switch code you set TSTATE_MCDE if it's not set already. That should cover all threaded case. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/30/2017 04:38 PM, David Miller wrote: > From: Khalid Aziz <khalid.aziz@oracle.com> > Date: Wed, 30 Aug 2017 16:27:54 -0600 > >>>> +#define arch_calc_vm_prot_bits(prot, pkey) >>>> sparc_calc_vm_prot_bits(prot) >>>> +static inline unsigned long sparc_calc_vm_prot_bits(unsigned long >>>> prot) >>>> +{ >>>> + if (prot & PROT_ADI) { >>>> + struct pt_regs *regs; >>>> + >>>> + if (!current->mm->context.adi) { >>>> + regs = task_pt_regs(current); >>>> + regs->tstate |= TSTATE_MCDE; >>>> + current->mm->context.adi = true; >>> If a process is multi-threaded when it enables ADI on some memory for >>> the first time, TSTATE_MCDE will only be set for the calling thread >>> and it will not be possible to enable it for the other threads. >>> One possible way to handle this is to enable TSTATE_MCDE for all user >>> threads when they are initialized if adi_capable() returns true. >>> >> >> Or set TSTATE_MCDE unconditionally here by removing "if >> (!current->mm->context.adi)"? > > I think you have to make "ADI enabled" a property of the mm_struct. > > Then you can broadcast to mm->cpu_vm_mask a per-cpu interrupt that > updates regs->tstate of a thread using 'mm' is currently executing. > > And in the context switch code you set TSTATE_MCDE if it's not set > already. > > That should cover all threaded case. That is an interesting idea. This would enable TSTATE_MCDE on all threads of a process as soon as one thread enables it. If we consider the case where the parent creates a shared memory area and spawns a bunch of threads. These threads access the shared memory without ADI enabled. Now one of the threads decides to enable ADI on the shared memory. As soon as it does that, we enable TSTATE_MCDE across all threads and since threads are all using the same TTE for the shared memory, every thread becomes subject to ADI verification. If one of the other threads was in the middle of accessing the shared memory, it will get a sigsegv. If we did not enable TSTATE_MCDE across all threads, it could have continued execution without fault. In other words, updating TSTATE_MCDE across all threads will eliminate the option of running some threads with ADI enabled and some not while accessing the same shared memory. This could be necessary at least for short periods of time before threads can communicate with each other and all switch to accessing shared memory with ADI enabled using same tag. Does that sound like a valid use case or am I off in the weeds here? Thanks, Khalid -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Khalid Aziz <khalid.aziz@oracle.com> Date: Wed, 30 Aug 2017 17:23:37 -0600 > That is an interesting idea. This would enable TSTATE_MCDE on all > threads of a process as soon as one thread enables it. If we consider > the case where the parent creates a shared memory area and spawns a > bunch of threads. These threads access the shared memory without ADI > enabled. Now one of the threads decides to enable ADI on the shared > memory. As soon as it does that, we enable TSTATE_MCDE across all > threads and since threads are all using the same TTE for the shared > memory, every thread becomes subject to ADI verification. If one of > the other threads was in the middle of accessing the shared memory, it > will get a sigsegv. If we did not enable TSTATE_MCDE across all > threads, it could have continued execution without fault. In other > words, updating TSTATE_MCDE across all threads will eliminate the > option of running some threads with ADI enabled and some not while > accessing the same shared memory. This could be necessary at least for > short periods of time before threads can communicate with each other > and all switch to accessing shared memory with ADI enabled using same > tag. Does that sound like a valid use case or am I off in the weeds > here? A threaded application needs to synchronize and properly orchestrate access to shared memory. When a change is made to a mappping, in this case setting ADI attributes, it's being done for the address space not the thread. And the address space is shared amongst threads. Therefore ADI is not really a per-thread property but rather a per-address-space property. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/30/2017 06:09 PM, David Miller wrote: > From: Khalid Aziz <khalid.aziz@oracle.com> > Date: Wed, 30 Aug 2017 17:23:37 -0600 > >> That is an interesting idea. This would enable TSTATE_MCDE on all >> threads of a process as soon as one thread enables it. If we consider >> the case where the parent creates a shared memory area and spawns a >> bunch of threads. These threads access the shared memory without ADI >> enabled. Now one of the threads decides to enable ADI on the shared >> memory. As soon as it does that, we enable TSTATE_MCDE across all >> threads and since threads are all using the same TTE for the shared >> memory, every thread becomes subject to ADI verification. If one of >> the other threads was in the middle of accessing the shared memory, it >> will get a sigsegv. If we did not enable TSTATE_MCDE across all >> threads, it could have continued execution without fault. In other >> words, updating TSTATE_MCDE across all threads will eliminate the >> option of running some threads with ADI enabled and some not while >> accessing the same shared memory. This could be necessary at least for >> short periods of time before threads can communicate with each other >> and all switch to accessing shared memory with ADI enabled using same >> tag. Does that sound like a valid use case or am I off in the weeds >> here? > > A threaded application needs to synchronize and properly orchestrate > access to shared memory. > > When a change is made to a mappping, in this case setting ADI > attributes, it's being done for the address space not the thread. > > And the address space is shared amongst threads. > > Therefore ADI is not really a per-thread property but rather > a per-address-space property. > That does make sense. Thanks, Khalid -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Khalid, > On Aug 30, 2017, at 3:27 PM, Khalid Aziz <khalid.aziz@Oracle.com> wrote: > > Hi Anthony, > > Thanks for taking the time to provide feedback. My comments inline below. > > On 08/25/2017 04:31 PM, Anthony Yznaga wrote: >>> On Aug 9, 2017, at 2:26 PM, Khalid Aziz <khalid.aziz@oracle.com> wrote: >>> ......deleted...... >>> +provided by the hypervisor to the kernel. Kernel returns the value of >>> +ADI block size to userspace using auxiliary vector along with other ADI >>> +info. Following auxiliary vectors are provided by the kernel: >>> + >>> + AT_ADI_BLKSZ ADI block size. This is the granularity and >>> + alignment, in bytes, of ADI versioning. >>> + AT_ADI_NBITS Number of ADI version bits in the VA >> The previous patch series also defined AT_ADI_UEONADI. Why was that >> removed? > > This was based upon a conversation we had when you mentioned future processors may not implement this or change the way this is interpreted and any applications depending upon this value would break at that point. I removed it to eliminate building an unreliable dependency. If I misunderstood what you said, please let me know. On M7 there is an array of versions maintained for cachelines in the L2 cache. If a UE is detected in this array it results in the flush of all eight ways of the array. Clean lines go away, but dirty lines are written back to memory with the version forced to 0xE. The ue-on-adp MD property communicates this tag value that may result from a UE in order to give the guest the opportunity to avoid using the tag value. An application that intentionally used ADI in a way that relied on ADI exceptions for its functionality may not want to have to consider whether the mismatch was legitimate or due to a UE. On M8 the HW implementation is changed and a tag value will never be forced to another value. That said, I think the ue-on-adp property value was unfortunately inadvertently carried forward to M8. It could probably be argued that the likelihood of seeing the UE is so low that SW can ignore the possibility, but including the information in an auxvec shouldn't break anything. > >>> + >>> + >>> +IMPORTANT NOTES: >>> + >>> +- Version tag values of 0x0 and 0xf are reserved. >> The documentation should probably state more specifically that an >> in-memory tag value of 0x0 or 0xf is treated as "match all" by the HW >> meaning that a mismatch exception will never be generated regardless >> of the tag bits set in the VA accessing the memory. > > Will do. > >>> + >>> +- Version tags are set on virtual addresses from userspace even though >>> + tags are stored in physical memory. Tags are set on a physical page >>> + after it has been allocated to a task and a pte has been created for >>> + it. >>> + >>> +- When a task frees a memory page it had set version tags on, the page >>> + goes back to free page pool. When this page is re-allocated to a task, >>> + kernel clears the page using block initialization ASI which clears the >>> + version tags as well for the page. If a page allocated to a task is >>> + freed and allocated back to the same task, old version tags set by the >>> + task on that page will no longer be present. >> The specifics should be included here, too, so someone doesn't have >> to guess what's going on if they make changes and the tags are no longer >> cleared. The HW clears the tag for a cacheline for block initializing >> stores to 64-byte aligned addresses if PSTATE.mcde=0 or TTE.mcd=0. >> PSTATE.mce is set when executing in the kernel, but pages are cleared >> using kernel physical mapping VAs which are mapped with TTE.mcd=0. >> Another HW behavior that should be mentioned is that tag mismatches >> are not detected for non-faulting loads. > > Sure, I can add that. > >>> + >>> +- Kernel does not set any tags for user pages and it is entirely a >>> + task's responsibility to set any version tags. Kernel does ensure the >>> + version tags are preserved if a page is swapped out to the disk and >>> + swapped back in. It also preserves that version tags if a page is >>> + migrated. >> I only have a cursory understanding of how page migration works, but >> I could not see how the tags would be preserved if a page were migrated. >> I figured the place to copy the tags would be migrate_page_copy(), but >> I don't see changes there. > > For migrating user pages, the way I understand the code works is if the page is mapped (which is the only time ADI tags are even in place), try_to_unmap() is called with TTU_MIGRATION flag set. try_to_unmap() will call arch_unmap_one() which saves the tags from currently mapped page. When the new page has been allocated, contents of the old page are faulted in through do_swap_page() which will call arch_do_swap_page(). arch_do_swap_page() then restores the ADI tags. My understanding from reading the code is that __unmap_and_move() calls try_to_unmap() which unmaps the page and installs a migration pte. move_to_new_page() is then called which copies the data. Finally, remove_migration_ptes() is called which removes the migration pte and installs an updated regular pte. If a fault on the page happens while the migration pte is installed, do_swap_page() is called and the faulting thread waits for the migration to complete before proceeding. However, if no fault happens before the migration completes, a regular pte will be found by the next fault and do_swap_page() will not be called. > > >>> diff --git a/arch/sparc/include/asm/mman.h b/arch/sparc/include/asm/mman.h >>> index 59bb5938d852..b799796ad963 100644 >>> --- a/arch/sparc/include/asm/mman.h >>> +++ b/arch/sparc/include/asm/mman.h >>> @@ -6,5 +6,75 @@ >>> #ifndef __ASSEMBLY__ >>> #define arch_mmap_check(addr,len,flags) sparc_mmap_check(addr,len) >>> int sparc_mmap_check(unsigned long addr, unsigned long len); >>> -#endif >>> + >>> +#ifdef CONFIG_SPARC64 >>> +#include <asm/adi_64.h> >>> + >>> +#define arch_calc_vm_prot_bits(prot, pkey) sparc_calc_vm_prot_bits(prot) >>> +static inline unsigned long sparc_calc_vm_prot_bits(unsigned long prot) >>> +{ >>> + if (prot & PROT_ADI) { >>> + struct pt_regs *regs; >>> + >>> + if (!current->mm->context.adi) { >>> + regs = task_pt_regs(current); >>> + regs->tstate |= TSTATE_MCDE; >>> + current->mm->context.adi = true; >> If a process is multi-threaded when it enables ADI on some memory for >> the first time, TSTATE_MCDE will only be set for the calling thread >> and it will not be possible to enable it for the other threads. >> One possible way to handle this is to enable TSTATE_MCDE for all user >> threads when they are initialized if adi_capable() returns true. > > Or set TSTATE_MCDE unconditionally here by removing "if (!current->mm->context.adi)"? > >>> + } >>> + return VM_SPARC_ADI; >>> + } else { >>> + return 0; >>> + } >>> +} >>> + >>> +#define arch_vm_get_page_prot(vm_flags) sparc_vm_get_page_prot(vm_flags) >>> +static inline pgprot_t sparc_vm_get_page_prot(unsigned long vm_flags) >>> +{ >>> + return (vm_flags & VM_SPARC_ADI) ? __pgprot(_PAGE_MCD_4V) : __pgprot(0); >>> +} >>> + >>> +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) >>> +static inline int sparc_validate_prot(unsigned long prot, unsigned long addr) >>> +{ >>> + if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_ADI)) >>> + return 0; >>> + if (prot & PROT_ADI) { >>> + if (!adi_capable()) >>> + return 0; >>> + >>> + /* ADI tags can not be set on read-only memory, so it makes >>> + * sense to enable ADI on writable memory only. >>> + */ >>> + if (!(prot & PROT_WRITE)) >>> + return 0; >> This prevents the use of ADI for the legitimate case where shared memory >> is mapped read/write for a master process but mapped read-only for a >> client process. The master process could set the tags and communicate >> the expected tag values to the client. > > A non-writable mapping can access the shared memory using non-ADI tagged addresses if it does not enable ADI on its mappings, so it is superfluous to even allow enabling ADI. I can remove this if that helps any use cases that wouldn't work with above condition. Allowing ADI to be enabled on read-only shared memory leaves the option open to set up ADI in a way to detect unintended accesses that might otherwise be missed. > >>> +tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm, >>> + struct vm_area_struct *vma, >>> + unsigned long addr) >>> +{ >>> + unsigned char *tags; >>> + unsigned long i, size, max_desc, flags; >>> + tag_storage_desc_t *tag_desc, *open_desc; >>> + unsigned long end_addr, hole_start, hole_end; >>> + >>> + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); >>> + open_desc = NULL; >>> + hole_start = 0; >>> + hole_end = ULONG_MAX; >>> + end_addr = addr + PAGE_SIZE - 1; >>> + >>> + /* Check if this vma already has tag storage descriptor >>> + * allocated for it. >>> + */ >>> + spin_lock_irqsave(&mm->context.tag_lock, flags); >>> + if (mm->context.tag_store) { >>> + tag_desc = mm->context.tag_store; >>> + >>> + /* Look for a matching entry for this address. While doing >>> + * that, look for the first open slot as well and find >>> + * the hole in already allocated range where this request >>> + * will fit in. >>> + */ >>> + for (i = 0; i < max_desc; i++) { >>> + if (tag_desc->tag_users == 0) { >>> + if (open_desc == NULL) >>> + open_desc = tag_desc; >>> + } else { >>> + if ((addr >= tag_desc->start) && >>> + (tag_desc->end >= (addr + PAGE_SIZE - 1))) { >>> + tag_desc->tag_users++; >>> + goto out; >>> + } >>> + } >>> + if ((tag_desc->start > end_addr) && >>> + (tag_desc->start < hole_end)) >>> + hole_end = tag_desc->start; >>> + if ((tag_desc->end < addr) && >>> + (tag_desc->end > hole_start)) >>> + hole_start = tag_desc->end; >>> + tag_desc++; >>> + } >>> + >>> + } else { >>> + size = sizeof(tag_storage_desc_t)*max_desc; >>> + mm->context.tag_store = kzalloc(size, GFP_NOIO|__GFP_NOWARN); >> The spin_lock_irqsave() above means that all but level 15 interrupts >> will be disabled when kzalloc() is called. If kzalloc() can sleep >> there's a risk of deadlock. > > I could call kzalloc() with GFP_NOWAIT instead of GFP_NOIO. Would that address the risk of deadlock? I think so. It may also mean that allocation failures are likely to be seen since available memory is low enough to cause swapping in the first place. > >>> + if (mm->context.tag_store == NULL) { >>> + tag_desc = NULL; >>> + goto out; >>> + } >>> + tag_desc = mm->context.tag_store; >>> + for (i = 0; i < max_desc; i++, tag_desc++) >>> + tag_desc->tag_users = 0; >>> + open_desc = mm->context.tag_store; >>> + i = 0; >>> + } >>> + >>> + /* Check if we ran out of tag storage descriptors */ >>> + if (open_desc == NULL) { >>> + tag_desc = NULL; >>> + goto out; >>> + } >>> + >>> + /* Mark this tag descriptor slot in use and then initialize it */ >>> + tag_desc = open_desc; >>> + tag_desc->tag_users = 1; >>> + >>> + /* Tag storage has not been allocated for this vma and space >>> + * is available in tag storage descriptor. Since this page is >>> + * being swapped out, there is high probability subsequent pages >>> + * in the VMA will be swapped out as well. Allocates pages to >>> + * store tags for as many pages in this vma as possible but not >>> + * more than TAG_STORAGE_PAGES. Each byte in tag space holds >>> + * two ADI tags since each ADI tag is 4 bits. Each ADI tag >>> + * covers adi_blksize() worth of addresses. Check if the hole is >>> + * big enough to accommodate full address range for using >>> + * TAG_STORAGE_PAGES number of tag pages. >>> + */ >>> + size = TAG_STORAGE_PAGES * PAGE_SIZE; >>> + end_addr = addr + (size*2*adi_blksize()) - 1; >> Since size > PAGE_SIZE, end_addr could theoretically overflow > >>> + if (hole_end < end_addr) { >>> + /* Available hole is too small on the upper end of >>> + * address. Can we expand the range towards the lower >>> + * address and maximize use of this slot? >>> + */ >>> + unsigned long tmp_addr; >>> + >>> + end_addr = hole_end - 1; >>> + tmp_addr = end_addr - (size*2*adi_blksize()) + 1; >> Similarily, tmp_addr may underflow. > > I will add checks for these two. > >>> + if (tmp_addr < hole_start) { >>> + /* Available hole is restricted on lower address >>> + * end as well >>> + */ >>> + tmp_addr = hole_start + 1; >>> + } >>> + addr = tmp_addr; >>> + size = (end_addr + 1 - addr)/(2*adi_blksize()); >>> + size = (size + (PAGE_SIZE-adi_blksize()))/PAGE_SIZE; >>> + size = size * PAGE_SIZE; >>> + } >>> + tags = kzalloc(size, GFP_NOIO|__GFP_NOWARN); >> Potential deadlock due to PIL=14? > > Same as above - call kzalloc() with GFP_NOWAIT? > >>> diff --git a/arch/sparc/kernel/etrap_64.S b/arch/sparc/kernel/etrap_64.S >>> index 1276ca2567ba..7be33bf45cff 100644 >>> --- a/arch/sparc/kernel/etrap_64.S >>> +++ b/arch/sparc/kernel/etrap_64.S >>> @@ -132,7 +132,33 @@ etrap_save: save %g2, -STACK_BIAS, %sp >>> stx %g6, [%sp + PTREGS_OFF + PT_V9_G6] >>> stx %g7, [%sp + PTREGS_OFF + PT_V9_G7] >>> or %l7, %l0, %l7 >>> - sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 >>> +661: sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 >>> + /* >>> + * If userspace is using ADI, it could potentially pass >>> + * a pointer with version tag embedded in it. To maintain >>> + * the ADI security, we must enable PSTATE.mcde. Userspace >>> + * would have already set TTE.mcd in an earlier call to >>> + * kernel and set the version tag for the address being >>> + * dereferenced. Setting PSTATE.mcde would ensure any >>> + * access to userspace data through a system call honors >>> + * ADI and does not allow a rogue app to bypass ADI by >>> + * using system calls. Setting PSTATE.mcde only affects >>> + * accesses to virtual addresses that have TTE.mcd set. >>> + * Set PMCDPER to ensure any exceptions caused by ADI >>> + * version tag mismatch are exposed before system call >>> + * returns to userspace. Setting PMCDPER affects only >>> + * writes to virtual addresses that have TTE.mcd set and >>> + * have a version tag set as well. >>> + */ >>> + .section .sun_m7_1insn_patch, "ax" >>> + .word 661b >>> + sethi %hi(TSTATE_TSO | TSTATE_PEF | TSTATE_MCDE), %l0 >>> + .previous >>> +661: nop >>> + .section .sun_m7_1insn_patch, "ax" >>> + .word 661b >>> + .word 0xaf902001 /* wrpr %g0, 1, %pmcdper */ >> I commented on this on the last patch series revision. PMCDPER could be >> set once when each CPU is configured rather than every time the kernel >> is entered. Since it's never cleared, setting it repeatedly unnecessarily >> impacts the performance of etrap. > > Yes, you did and I thought I had addressed it in that thread: > > ">> I considered that possibility. What made me uncomfortable with that is there is no way to prevent a driver/module or future code elsewhere in kernel from clearing PMCDPER with possibly good reason. If that were to happen, setting PMCDPER here ensures kernel will always see consistent behavior with system calls. It does come at a cost. Is that cost unacceptable to ensure consistent behavior? Any driver/module has the ability to cause problems by writing any privileged register of its choice. It would be a bug to clear PMCDPER and not restore it, and the consequence is that a mismatch detected in privileged mode would result in a disrupting exception instead of a precise exception. Perhaps a warning could be logged if this unexpected case occurs. Anthony >> Aren't you still at risk if the thread relinquishes the CPU while in the kernel and is then rescheduled on a CPU where PMCDPER has erroneously been left cleared? You may need to save and restore PMCDPER as well as MCDPER on context switch, but I don't know if that will cover you completely. >> " > > I should add setting PMCDPER to 1 in finish_arch_post_lock_switch() to address the possibility you had mentioned. > >> Also, there are places in rtrap where PSTATE is set before continuing >> execution in the kernel. These should also be patched to set TSTATE_MCDE. > > I will find and fix those. > >>> diff --git a/arch/sparc/kernel/setup_64.c b/arch/sparc/kernel/setup_64.c >>> index 422b17880955..a9da205da394 100644 >>> --- a/arch/sparc/kernel/setup_64.c >>> +++ b/arch/sparc/kernel/setup_64.c >>> @@ -240,6 +240,12 @@ void sun4v_patch_1insn_range(struct sun4v_1insn_patch_entry *start, >>> } >>> } >>> >>> +void sun_m7_patch_1insn_range(struct sun4v_1insn_patch_entry *start, >>> + struct sun4v_1insn_patch_entry *end) >>> +{ >>> + sun4v_patch_1insn_range(start, end); >>> +} >>> + >>> void sun4v_patch_2insn_range(struct sun4v_2insn_patch_entry *start, >>> struct sun4v_2insn_patch_entry *end) >>> { >>> @@ -289,9 +295,12 @@ static void __init sun4v_patch(void) >>> sun4v_patch_2insn_range(&__sun4v_2insn_patch, >>> &__sun4v_2insn_patch_end); >>> if (sun4v_chip_type == SUN4V_CHIP_SPARC_M7 || >>> - sun4v_chip_type == SUN4V_CHIP_SPARC_SN) >>> + sun4v_chip_type == SUN4V_CHIP_SPARC_SN) { >>> + sun_m7_patch_1insn_range(&__sun_m7_1insn_patch, >>> + &__sun_m7_1insn_patch_end); >>> sun_m7_patch_2insn_range(&__sun_m7_2insn_patch, >>> &__sun_m7_2insn_patch_end); >> Why not call sun4v_patch_1insn_range() and sun4v_patch_2insn_range() >> here instead of adding new functions that just call these functions? > > Sounds reasonable, I can change that. > > Thanks, > Khalid > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi! > ADI is a new feature supported on SPARC M7 and newer processors to allow > hardware to catch rogue accesses to memory. ADI is supported for data > fetches only and not instruction fetches. An app can enable ADI on its > data pages, set version tags on them and use versioned addresses to > access the data pages. Upper bits of the address contain the version > tag. On M7 processors, upper four bits (bits 63-60) contain the version > tag. If a rogue app attempts to access ADI enabled data pages, its > access is blocked and processor generates an exception. Please see > Documentation/sparc/adi.txt for further details. I'm afraid I still don't understand what this is meant to prevent. IOMMU ignores these, so this is not to prevent rogue DMA from doing bad stuff. Will gcc be able to compile code that uses these automatically? That does not sound easy to me. Can libc automatically use this in malloc() to prevent accessing freed data when buffers are overrun? Is this for benefit of JITs? Thanks, Pavel
From: Pavel Machek <pavel@ucw.cz> Date: Mon, 4 Sep 2017 18:25:30 +0200 > Will gcc be able to compile code that uses these automatically? That > does not sound easy to me. Can libc automatically use this in malloc() > to prevent accessing freed data when buffers are overrun? > > Is this for benefit of JITs? Anything that can control mappings and the virtual address used to access memory can use ADI. malloc() is of course one such case. It can map memory with ADI enabled, and return buffer addresses to malloc() callers with the proper virtual address bits set to satisfy the ADI key checks. And by induction anything using malloc() for it's memory allocation gets ADI protection as well. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/04/2017 10:25 AM, Pavel Machek wrote: > Hi! > >> ADI is a new feature supported on SPARC M7 and newer processors to allow >> hardware to catch rogue accesses to memory. ADI is supported for data >> fetches only and not instruction fetches. An app can enable ADI on its >> data pages, set version tags on them and use versioned addresses to >> access the data pages. Upper bits of the address contain the version >> tag. On M7 processors, upper four bits (bits 63-60) contain the version >> tag. If a rogue app attempts to access ADI enabled data pages, its >> access is blocked and processor generates an exception. Please see >> Documentation/sparc/adi.txt for further details. > > I'm afraid I still don't understand what this is meant to prevent. > > IOMMU ignores these, so this is not to prevent rogue DMA from doing > bad stuff. > > Will gcc be able to compile code that uses these automatically? That > does not sound easy to me. Can libc automatically use this in malloc() > to prevent accessing freed data when buffers are overrun? > > Is this for benefit of JITs? > David explained it well. Yes, preventing buffer overflow is one of the uses of ADI. Protecting critical data from wild writes caused by programming errors is another use. ADI can be used for debugging as well during development. Thanks, Khalid -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue 2017-09-05 14:44:56, David Miller wrote: > From: Pavel Machek <pavel@ucw.cz> > Date: Mon, 4 Sep 2017 18:25:30 +0200 > > > Will gcc be able to compile code that uses these automatically? That > > does not sound easy to me. Can libc automatically use this in malloc() > > to prevent accessing freed data when buffers are overrun? > > > > Is this for benefit of JITs? > > Anything that can control mappings and the virtual address used to > access memory can use ADI. > > malloc() is of course one such case. It can map memory with ADI > enabled, and return buffer addresses to malloc() callers with the > proper virtual address bits set to satisfy the ADI key checks. > > And by induction anything using malloc() for it's memory allocation > gets ADI protection as well. I see; that's actually quite a nice trick. I guess it does not protect against stack-based overflows, but should help against heap-based overflows, so it improves security a bit, too. Nice, thanks for explanation. Pavel
On 9/6/2017 6:32 PM, Pavel Machek wrote: > On Tue 2017-09-05 14:44:56, David Miller wrote: >> From: Pavel Machek <pavel@ucw.cz> >> Date: Mon, 4 Sep 2017 18:25:30 +0200 >> >>> Will gcc be able to compile code that uses these automatically? That >>> does not sound easy to me. Can libc automatically use this in malloc() >>> to prevent accessing freed data when buffers are overrun? >>> >>> Is this for benefit of JITs? >> >> Anything that can control mappings and the virtual address used to >> access memory can use ADI. >> >> malloc() is of course one such case. It can map memory with ADI >> enabled, and return buffer addresses to malloc() callers with the >> proper virtual address bits set to satisfy the ADI key checks. >> >> And by induction anything using malloc() for it's memory allocation >> gets ADI protection as well. > > I see; that's actually quite a nice trick. > > I guess it does not protect against stack-based overflows, but should > help against heap-based overflows, so it improves security a bit, too. > > Nice, thanks for explanation. ADI can also be used to protect the stack. Modify ADI versions for a 64B aligned portion of the register save area in the kernel spill and fill handlers, and accidental or malicious access to the area from userland will trap. Other data on the stack can be corrupted, but one cannot linearly overflow into the next stack frame without tripping over the ADI canary. There are a few other details to handle, such as setjmp/longjmp and JITs that modify the stack, but that is the gist. This is not part of the current patch, but has been implemented on Solaris. ADI could protect other data on the stack, but that requires compiler code generation changes. - Steve -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/sparc/adi.txt b/Documentation/sparc/adi.txt new file mode 100644 index 000000000000..383bc65fec1e --- /dev/null +++ b/Documentation/sparc/adi.txt @@ -0,0 +1,272 @@ +Application Data Integrity (ADI) +================================ + +SPARC M7 processor adds the Application Data Integrity (ADI) feature. +ADI allows a task to set version tags on any subset of its address +space. Once ADI is enabled and version tags are set for ranges of +address space of a task, the processor will compare the tag in pointers +to memory in these ranges to the version set by the application +previously. Access to memory is granted only if the tag in given pointer +matches the tag set by the application. In case of mismatch, processor +raises an exception. + +Following steps must be taken by a task to enable ADI fully: + +1. Set the user mode PSTATE.mcde bit. This acts as master switch for + the task's entire address space to enable/disable ADI for the task. + +2. Set TTE.mcd bit on any TLB entries that correspond to the range of + addresses ADI is being enabled on. MMU checks the version tag only + on the pages that have TTE.mcd bit set. + +3. Set the version tag for virtual addresses using stxa instruction + and one of the MCD specific ASIs. Each stxa instruction sets the + given tag for one ADI block size number of bytes. This step must + be repeated for entire page to set tags for entire page. + +ADI block size for the platform is provided by the hypervisor to kernel +in machine description tables. Hypervisor also provides the number of +top bits in the virtual address that specify the version tag. Once +version tag has been set for a memory location, the tag is stored in the +physical memory and the same tag must be present in the ADI version tag +bits of the virtual address being presented to the MMU. For example on +SPARC M7 processor, MMU uses bits 63-60 for version tags and ADI block +size is same as cacheline size which is 64 bytes. A task that sets ADI +version to, say 10, on a range of memory, must access that memory using +virtual addresses that contain 0xa in bits 63-60. + +ADI is enabled on a set of pages using mprotect() with PROT_ADI flag. +When ADI is enabled on a set of pages by a task for the first time, +kernel sets the PSTATE.mcde bit fot the task. Version tags for memory +addresses are set with an stxa instruction on the addresses using +ASI_MCD_PRIMARY or ASI_MCD_ST_BLKINIT_PRIMARY. ADI block size is +provided by the hypervisor to the kernel. Kernel returns the value of +ADI block size to userspace using auxiliary vector along with other ADI +info. Following auxiliary vectors are provided by the kernel: + + AT_ADI_BLKSZ ADI block size. This is the granularity and + alignment, in bytes, of ADI versioning. + AT_ADI_NBITS Number of ADI version bits in the VA + + +IMPORTANT NOTES: + +- Version tag values of 0x0 and 0xf are reserved. + +- Version tags are set on virtual addresses from userspace even though + tags are stored in physical memory. Tags are set on a physical page + after it has been allocated to a task and a pte has been created for + it. + +- When a task frees a memory page it had set version tags on, the page + goes back to free page pool. When this page is re-allocated to a task, + kernel clears the page using block initialization ASI which clears the + version tags as well for the page. If a page allocated to a task is + freed and allocated back to the same task, old version tags set by the + task on that page will no longer be present. + +- Kernel does not set any tags for user pages and it is entirely a + task's responsibility to set any version tags. Kernel does ensure the + version tags are preserved if a page is swapped out to the disk and + swapped back in. It also preserves that version tags if a page is + migrated. + +- ADI works for any size pages. A userspace task need not be aware of + page size when using ADI. It can simply select a virtual address + range, enable ADI on the range using mprotect() and set version tags + for the entire range. mprotect() ensures range is aligned to page size + and is a multiple of page size. + + + +ADI related traps +----------------- + +With ADI enabled, following new traps may occur: + +Disrupting memory corruption + + When a store accesses a memory localtion that has TTE.mcd=1, + the task is running with ADI enabled (PSTATE.mcde=1), and the ADI + tag in the address used (bits 63:60) does not match the tag set on + the corresponding cacheline, a memory corruption trap occurs. By + default, it is a disrupting trap and is sent to the hypervisor + first. Hypervisor creates a sun4v error report and sends a + resumable error (TT=0x7e) trap to the kernel. The kernel sends + a SIGSEGV to the task that resulted in this trap with the following + info: + + siginfo.si_signo = SIGSEGV; + siginfo.errno = 0; + siginfo.si_code = SEGV_ADIDERR; + siginfo.si_addr = addr; /* PC where first mismatch occurred */ + siginfo.si_trapno = 0; + + +Precise memory corruption + + When a store accesses a memory location that has TTE.mcd=1, + the task is running with ADI enabled (PSTATE.mcde=1), and the ADI + tag in the address used (bits 63:60) does not match the tag set on + the corresponding cacheline, a memory corruption trap occurs. If + MCD precise exception is enabled (MCDPERR=1), a precise + exception is sent to the kernel with TT=0x1a. The kernel sends + a SIGSEGV to the task that resulted in this trap with the following + info: + + siginfo.si_signo = SIGSEGV; + siginfo.errno = 0; + siginfo.si_code = SEGV_ADIPERR; + siginfo.si_addr = addr; /* address that caused trap */ + siginfo.si_trapno = 0; + + NOTE: ADI tag mismatch on a load always results in precise trap. + + +MCD disabled + + When a task has not enabled ADI and attempts to set ADI version + on a memory address, processor sends an MCD disabled trap. This + trap is handled by hypervisor first and the hypervisor vectors this + trap through to the kernel as Data Access Exception trap with + fault type set to 0xa (invalid ASI). When this occurs, the kernel + sends the task SIGSEGV signal with following info: + + siginfo.si_signo = SIGSEGV; + siginfo.errno = 0; + siginfo.si_code = SEGV_ACCADI; + siginfo.si_addr = addr; /* address that caused trap */ + siginfo.si_trapno = 0; + + +Sample program to use ADI +------------------------- + +Following sample program is meant to illustrate how to use the ADI +functionality. + +#include <unistd.h> +#include <stdio.h> +#include <stdlib.h> +#include <elf.h> +#include <sys/ipc.h> +#include <sys/shm.h> +#include <sys/mman.h> +#include <asm/asi.h> + +#ifndef AT_ADI_BLKSZ +#define AT_ADI_BLKSZ 48 +#endif +#ifndef AT_ADI_NBITS +#define AT_ADI_NBITS 49 +#endif + +#ifndef PROT_ADI +#define PROT_ADI 0x10 +#endif + +#define BUFFER_SIZE 32*1024*1024UL + +main(int argc, char* argv[], char* envp[]) +{ + unsigned long i, mcde, adi_blksz, adi_nbits; + char *shmaddr, *tmp_addr, *end, *veraddr, *clraddr; + int shmid, version; + Elf64_auxv_t *auxv; + + adi_blksz = 0; + + while(*envp++ != NULL); + for (auxv = (Elf64_auxv_t *)envp; auxv->a_type != AT_NULL; auxv++) { + switch (auxv->a_type) { + case AT_ADI_BLKSZ: + adi_blksz = auxv->a_un.a_val; + break; + case AT_ADI_NBITS: + adi_nbits = auxv->a_un.a_val; + break; + } + } + if (adi_blksz == 0) { + fprintf(stderr, "Oops! ADI is not supported\n"); + exit(1); + } + + printf("ADI capabilities:\n"); + printf("\tBlock size = %ld\n", adi_blksz); + printf("\tNumber of bits = %ld\n", adi_nbits); + + if ((shmid = shmget(2, BUFFER_SIZE, + IPC_CREAT | SHM_R | SHM_W)) < 0) { + perror("shmget failed"); + exit(1); + } + + shmaddr = shmat(shmid, NULL, 0); + if (shmaddr == (char *)-1) { + perror("shm attach failed"); + shmctl(shmid, IPC_RMID, NULL); + exit(1); + } + + if (mprotect(shmaddr, BUFFER_SIZE, PROT_READ|PROT_WRITE|PROT_ADI)) { + perror("mprotect failed"); + goto err_out; + } + + /* Set the ADI version tag on the shm segment + */ + version = 10; + tmp_addr = shmaddr; + end = shmaddr + BUFFER_SIZE; + while (tmp_addr < end) { + asm volatile( + "stxa %1, [%0]0x90\n\t" + : + : "r" (tmp_addr), "r" (version)); + tmp_addr += adi_blksz; + } + asm volatile("membar #Sync\n\t"); + + /* Create a versioned address from the normal address by placing + * version tag in the upper adi_nbits bits + */ + tmp_addr = (void *) ((unsigned long)shmaddr << adi_nbits); + tmp_addr = (void *) ((unsigned long)tmp_addr >> adi_nbits); + veraddr = (void *) (((unsigned long)version << (64-adi_nbits)) + | (unsigned long)tmp_addr); + + printf("Starting the writes:\n"); + for (i = 0; i < BUFFER_SIZE; i++) { + veraddr[i] = (char)(i); + if (!(i % (1024 * 1024))) + printf("."); + } + printf("\n"); + + printf("Verifying data..."); + fflush(stdout); + for (i = 0; i < BUFFER_SIZE; i++) + if (veraddr[i] != (char)i) + printf("\nIndex %lu mismatched\n", i); + printf("Done.\n"); + + /* Disable ADI and clean up + */ + if (mprotect(shmaddr, BUFFER_SIZE, PROT_READ|PROT_WRITE)) { + perror("mprotect failed"); + goto err_out; + } + + if (shmdt((const void *)shmaddr) != 0) + perror("Detach failure"); + shmctl(shmid, IPC_RMID, NULL); + + exit(0); + +err_out: + if (shmdt((const void *)shmaddr) != 0) + perror("Detach failure"); + shmctl(shmid, IPC_RMID, NULL); + exit(1); +} diff --git a/arch/sparc/include/asm/mman.h b/arch/sparc/include/asm/mman.h index 59bb5938d852..b799796ad963 100644 --- a/arch/sparc/include/asm/mman.h +++ b/arch/sparc/include/asm/mman.h @@ -6,5 +6,75 @@ #ifndef __ASSEMBLY__ #define arch_mmap_check(addr,len,flags) sparc_mmap_check(addr,len) int sparc_mmap_check(unsigned long addr, unsigned long len); -#endif + +#ifdef CONFIG_SPARC64 +#include <asm/adi_64.h> + +#define arch_calc_vm_prot_bits(prot, pkey) sparc_calc_vm_prot_bits(prot) +static inline unsigned long sparc_calc_vm_prot_bits(unsigned long prot) +{ + if (prot & PROT_ADI) { + struct pt_regs *regs; + + if (!current->mm->context.adi) { + regs = task_pt_regs(current); + regs->tstate |= TSTATE_MCDE; + current->mm->context.adi = true; + } + return VM_SPARC_ADI; + } else { + return 0; + } +} + +#define arch_vm_get_page_prot(vm_flags) sparc_vm_get_page_prot(vm_flags) +static inline pgprot_t sparc_vm_get_page_prot(unsigned long vm_flags) +{ + return (vm_flags & VM_SPARC_ADI) ? __pgprot(_PAGE_MCD_4V) : __pgprot(0); +} + +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) +static inline int sparc_validate_prot(unsigned long prot, unsigned long addr) +{ + if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_ADI)) + return 0; + if (prot & PROT_ADI) { + if (!adi_capable()) + return 0; + + /* ADI tags can not be set on read-only memory, so it makes + * sense to enable ADI on writable memory only. + */ + if (!(prot & PROT_WRITE)) + return 0; + + if (addr) { + struct vm_area_struct *vma; + + vma = find_vma(current->mm, addr); + if (vma) { + /* ADI can not be enabled on PFN + * mapped pages + */ + if (vma->vm_flags & (VM_PFNMAP | VM_MIXEDMAP)) + return 0; + + /* Mergeable pages can become unmergeable + * if ADI is enabled on them even if they + * have identical data on them. This can be + * because ADI enabled pages with identical + * data may still not have identical ADI + * tags on them. Disallow ADI on mergeable + * pages. + */ + if (vma->vm_flags & VM_MERGEABLE) + return 0; + } + } + } + return 1; +} +#endif /* CONFIG_SPARC64 */ + +#endif /* __ASSEMBLY__ */ #endif /* __SPARC_MMAN_H__ */ diff --git a/arch/sparc/include/asm/mmu_64.h b/arch/sparc/include/asm/mmu_64.h index 83b36a5371ff..a65d51ebe00b 100644 --- a/arch/sparc/include/asm/mmu_64.h +++ b/arch/sparc/include/asm/mmu_64.h @@ -89,6 +89,20 @@ struct tsb_config { #define MM_NUM_TSBS 1 #endif +/* ADI tags are stored when a page is swapped out and the storage for + * tags is allocated dynamically. There is a tag storage descriptor + * associated with each set of tag storage pages. Tag storage descriptors + * are allocated dynamically. Since kernel will allocate a full page for + * each tag storage descriptor, we can store up to + * PAGE_SIZE/sizeof(tag storage descriptor) descriptors on that page. + */ +typedef struct { + unsigned long start; /* Start address for this tag storage */ + unsigned long end; /* Last address for tag storage */ + unsigned char *tags; /* Where the tags are */ + unsigned long tag_users; /* number of references to descriptor */ +} tag_storage_desc_t; + typedef struct { spinlock_t lock; unsigned long sparc64_ctx_val; @@ -96,6 +110,9 @@ typedef struct { unsigned long thp_pte_count; struct tsb_config tsb_block[MM_NUM_TSBS]; struct hv_tsb_descr tsb_descr[MM_NUM_TSBS]; + bool adi; + tag_storage_desc_t *tag_store; + spinlock_t tag_lock; } mm_context_t; #endif /* !__ASSEMBLY__ */ diff --git a/arch/sparc/include/asm/mmu_context_64.h b/arch/sparc/include/asm/mmu_context_64.h index 2cddcda4f85f..68de059551f9 100644 --- a/arch/sparc/include/asm/mmu_context_64.h +++ b/arch/sparc/include/asm/mmu_context_64.h @@ -9,6 +9,7 @@ #include <linux/mm_types.h> #include <asm/spitfire.h> +#include <asm/adi_64.h> #include <asm-generic/mm_hooks.h> static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk) @@ -129,6 +130,48 @@ static inline void switch_mm(struct mm_struct *old_mm, struct mm_struct *mm, str #define deactivate_mm(tsk,mm) do { } while (0) #define activate_mm(active_mm, mm) switch_mm(active_mm, mm, NULL) + +#define __HAVE_ARCH_START_CONTEXT_SWITCH +static inline void arch_start_context_switch(struct task_struct *prev) +{ + /* Save the current state of MCDPER register for the process + * we are switching from + */ + if (adi_capable()) { + register unsigned long tmp_mcdper; + + __asm__ __volatile__( + ".word 0x83438000\n\t" /* rd %mcdper, %g1 */ + "mov %%g1, %0\n\t" + : "=r" (tmp_mcdper) + : + : "g1"); + if (tmp_mcdper) + set_tsk_thread_flag(prev, TIF_MCDPER); + else + clear_tsk_thread_flag(prev, TIF_MCDPER); + } +} + +#define finish_arch_post_lock_switch finish_arch_post_lock_switch +static inline void finish_arch_post_lock_switch(void) +{ + /* Restore the state of MCDPER register for the new process + * just switched to. + */ + if (adi_capable()) { + register unsigned long tmp_mcdper; + + tmp_mcdper = test_thread_flag(TIF_MCDPER); + __asm__ __volatile__( + "mov %0, %%g1\n\t" + ".word 0x9d800001\n\t" /* wr %g0, %g1, %mcdper" */ + : + : "ir" (tmp_mcdper) + : "g1"); + } +} + #endif /* !(__ASSEMBLY__) */ #endif /* !(__SPARC64_MMU_CONTEXT_H) */ diff --git a/arch/sparc/include/asm/page_64.h b/arch/sparc/include/asm/page_64.h index 5961b2d8398a..dc582c5611f8 100644 --- a/arch/sparc/include/asm/page_64.h +++ b/arch/sparc/include/asm/page_64.h @@ -46,6 +46,10 @@ struct page; void clear_user_page(void *addr, unsigned long vaddr, struct page *page); #define copy_page(X,Y) memcpy((void *)(X), (void *)(Y), PAGE_SIZE) void copy_user_page(void *to, void *from, unsigned long vaddr, struct page *topage); +#define __HAVE_ARCH_COPY_USER_HIGHPAGE +struct vm_area_struct; +void copy_user_highpage(struct page *to, struct page *from, + unsigned long vaddr, struct vm_area_struct *vma); /* Unlike sparc32, sparc64's parameter passing API is more * sane in that structures which as small enough are passed diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index af045061f41e..51da342c392d 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -18,6 +18,7 @@ #include <asm/types.h> #include <asm/spitfire.h> #include <asm/asi.h> +#include <asm/adi.h> #include <asm/page.h> #include <asm/processor.h> @@ -570,6 +571,18 @@ static inline pte_t pte_mkspecial(pte_t pte) return pte; } +static inline pte_t pte_mkmcd(pte_t pte) +{ + pte_val(pte) |= _PAGE_MCD_4V; + return pte; +} + +static inline pte_t pte_mknotmcd(pte_t pte) +{ + pte_val(pte) &= ~_PAGE_MCD_4V; + return pte; +} + static inline unsigned long pte_young(pte_t pte) { unsigned long mask; @@ -1001,6 +1014,39 @@ int page_in_phys_avail(unsigned long paddr); int remap_pfn_range(struct vm_area_struct *, unsigned long, unsigned long, unsigned long, pgprot_t); +void adi_restore_tags(struct mm_struct *mm, struct vm_area_struct *vma, + unsigned long addr, pte_t pte); + +int adi_save_tags(struct mm_struct *mm, struct vm_area_struct *vma, + unsigned long addr, pte_t oldpte); + +#define __HAVE_ARCH_DO_SWAP_PAGE +static inline void arch_do_swap_page(struct mm_struct *mm, + struct vm_area_struct *vma, + unsigned long addr, + pte_t pte, pte_t oldpte) +{ + /* If this is a new page being mapped in, there can be no + * ADI tags stored away for this page. Skip looking for + * stored tags + */ + if (pte_none(oldpte)) + return; + + if (adi_state.enabled && (pte_val(pte) & _PAGE_MCD_4V)) + adi_restore_tags(mm, vma, addr, pte); +} + +#define __HAVE_ARCH_UNMAP_ONE +static inline int arch_unmap_one(struct mm_struct *mm, + struct vm_area_struct *vma, + unsigned long addr, pte_t oldpte) +{ + if (adi_state.enabled && (pte_val(oldpte) & _PAGE_MCD_4V)) + return adi_save_tags(mm, vma, addr, oldpte); + return 0; +} + static inline int io_remap_pfn_range(struct vm_area_struct *vma, unsigned long from, unsigned long pfn, unsigned long size, pgprot_t prot) diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h index 38a24f257b85..9c04acb1f9af 100644 --- a/arch/sparc/include/asm/thread_info_64.h +++ b/arch/sparc/include/asm/thread_info_64.h @@ -190,7 +190,7 @@ register struct thread_info *current_thread_info_reg asm("g6"); * in using in assembly, else we can't use the mask as * an immediate value in instructions such as andcc. */ -/* flag bit 12 is available */ +#define TIF_MCDPER 12 /* Precise MCD exception */ #define TIF_MEMDIE 13 /* is terminating due to OOM killer */ #define TIF_POLLING_NRFLAG 14 diff --git a/arch/sparc/include/asm/trap_block.h b/arch/sparc/include/asm/trap_block.h index ec9c04de3664..b283e940671a 100644 --- a/arch/sparc/include/asm/trap_block.h +++ b/arch/sparc/include/asm/trap_block.h @@ -72,6 +72,8 @@ struct sun4v_1insn_patch_entry { }; extern struct sun4v_1insn_patch_entry __sun4v_1insn_patch, __sun4v_1insn_patch_end; +extern struct sun4v_1insn_patch_entry __sun_m7_1insn_patch, + __sun_m7_1insn_patch_end; struct sun4v_2insn_patch_entry { unsigned int addr; diff --git a/arch/sparc/include/uapi/asm/mman.h b/arch/sparc/include/uapi/asm/mman.h index 9765896ecb2c..a72c03397345 100644 --- a/arch/sparc/include/uapi/asm/mman.h +++ b/arch/sparc/include/uapi/asm/mman.h @@ -5,6 +5,8 @@ /* SunOS'ified... */ +#define PROT_ADI 0x10 /* ADI enabled */ + #define MAP_RENAME MAP_ANONYMOUS /* In SunOS terminology */ #define MAP_NORESERVE 0x40 /* don't reserve swap pages */ #define MAP_INHERIT 0x80 /* SunOS doesn't do this, but... */ diff --git a/arch/sparc/kernel/adi_64.c b/arch/sparc/kernel/adi_64.c index 9fbb5dd4a7bf..83c1e36ae5fa 100644 --- a/arch/sparc/kernel/adi_64.c +++ b/arch/sparc/kernel/adi_64.c @@ -7,10 +7,24 @@ * This work is licensed under the terms of the GNU GPL, version 2. */ #include <linux/init.h> +#include <linux/slab.h> +#include <linux/mm_types.h> #include <asm/mdesc.h> #include <asm/adi_64.h> +#include <asm/mmu_64.h> +#include <asm/pgtable_64.h> + +/* Each page of storage for ADI tags can accommodate tags for 128 + * pages. When ADI enabled pages are being swapped out, it would be + * prudent to allocate at least enough tag storage space to accommodate + * SWAPFILE_CLUSTER number of pages. Allocate enough tag storage to + * store tags for four SWAPFILE_CLUSTER pages to reduce need for + * further allocations for same vma. + */ +#define TAG_STORAGE_PAGES 8 struct adi_config adi_state; +EXPORT_SYMBOL(adi_state); /* mdesc_adi_init() : Parse machine description provided by the * hypervisor to detect ADI capabilities @@ -78,6 +92,19 @@ void __init mdesc_adi_init(void) goto adi_not_found; adi_state.caps.nbits = *val; + /* Some of the code to support swapping ADI tags is written + * assumption that two ADI tags can fit inside one byte. If + * this assumption is broken by a future architecture change, + * that code will have to be revisited. If that were to happen, + * disable ADI support so we do not get unpredictable results + * with programs trying to use ADI and their pages getting + * swapped out + */ + if (adi_state.caps.nbits > 4) { + pr_warn("WARNING: ADI tag size >4 on this platform. Disabling AADI support\n"); + adi_state.enabled = false; + } + mdesc_release(hp); return; @@ -88,3 +115,253 @@ void __init mdesc_adi_init(void) if (hp) mdesc_release(hp); } + +tag_storage_desc_t *find_tag_store(struct mm_struct *mm, + struct vm_area_struct *vma, + unsigned long addr) +{ + tag_storage_desc_t *tag_desc = NULL; + unsigned long i, max_desc, flags; + + /* Check if this vma already has tag storage descriptor + * allocated for it. + */ + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); + if (mm->context.tag_store) { + tag_desc = mm->context.tag_store; + spin_lock_irqsave(&mm->context.tag_lock, flags); + for (i = 0; i < max_desc; i++) { + if ((addr >= tag_desc->start) && + ((addr + PAGE_SIZE - 1) <= tag_desc->end)) + break; + tag_desc++; + } + spin_unlock_irqrestore(&mm->context.tag_lock, flags); + + /* If no matching entries were found, this must be a + * freshly allocated page + */ + if (i >= max_desc) + tag_desc = NULL; + } + + return tag_desc; +} + +tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm, + struct vm_area_struct *vma, + unsigned long addr) +{ + unsigned char *tags; + unsigned long i, size, max_desc, flags; + tag_storage_desc_t *tag_desc, *open_desc; + unsigned long end_addr, hole_start, hole_end; + + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); + open_desc = NULL; + hole_start = 0; + hole_end = ULONG_MAX; + end_addr = addr + PAGE_SIZE - 1; + + /* Check if this vma already has tag storage descriptor + * allocated for it. + */ + spin_lock_irqsave(&mm->context.tag_lock, flags); + if (mm->context.tag_store) { + tag_desc = mm->context.tag_store; + + /* Look for a matching entry for this address. While doing + * that, look for the first open slot as well and find + * the hole in already allocated range where this request + * will fit in. + */ + for (i = 0; i < max_desc; i++) { + if (tag_desc->tag_users == 0) { + if (open_desc == NULL) + open_desc = tag_desc; + } else { + if ((addr >= tag_desc->start) && + (tag_desc->end >= (addr + PAGE_SIZE - 1))) { + tag_desc->tag_users++; + goto out; + } + } + if ((tag_desc->start > end_addr) && + (tag_desc->start < hole_end)) + hole_end = tag_desc->start; + if ((tag_desc->end < addr) && + (tag_desc->end > hole_start)) + hole_start = tag_desc->end; + tag_desc++; + } + + } else { + size = sizeof(tag_storage_desc_t)*max_desc; + mm->context.tag_store = kzalloc(size, GFP_NOIO|__GFP_NOWARN); + if (mm->context.tag_store == NULL) { + tag_desc = NULL; + goto out; + } + tag_desc = mm->context.tag_store; + for (i = 0; i < max_desc; i++, tag_desc++) + tag_desc->tag_users = 0; + open_desc = mm->context.tag_store; + i = 0; + } + + /* Check if we ran out of tag storage descriptors */ + if (open_desc == NULL) { + tag_desc = NULL; + goto out; + } + + /* Mark this tag descriptor slot in use and then initialize it */ + tag_desc = open_desc; + tag_desc->tag_users = 1; + + /* Tag storage has not been allocated for this vma and space + * is available in tag storage descriptor. Since this page is + * being swapped out, there is high probability subsequent pages + * in the VMA will be swapped out as well. Allocates pages to + * store tags for as many pages in this vma as possible but not + * more than TAG_STORAGE_PAGES. Each byte in tag space holds + * two ADI tags since each ADI tag is 4 bits. Each ADI tag + * covers adi_blksize() worth of addresses. Check if the hole is + * big enough to accommodate full address range for using + * TAG_STORAGE_PAGES number of tag pages. + */ + size = TAG_STORAGE_PAGES * PAGE_SIZE; + end_addr = addr + (size*2*adi_blksize()) - 1; + if (hole_end < end_addr) { + /* Available hole is too small on the upper end of + * address. Can we expand the range towards the lower + * address and maximize use of this slot? + */ + unsigned long tmp_addr; + + end_addr = hole_end - 1; + tmp_addr = end_addr - (size*2*adi_blksize()) + 1; + if (tmp_addr < hole_start) { + /* Available hole is restricted on lower address + * end as well + */ + tmp_addr = hole_start + 1; + } + addr = tmp_addr; + size = (end_addr + 1 - addr)/(2*adi_blksize()); + size = (size + (PAGE_SIZE-adi_blksize()))/PAGE_SIZE; + size = size * PAGE_SIZE; + } + tags = kzalloc(size, GFP_NOIO|__GFP_NOWARN); + if (tags == NULL) { + tag_desc->tag_users = 0; + tag_desc = NULL; + goto out; + } + tag_desc->start = addr; + tag_desc->tags = tags; + tag_desc->end = end_addr; + +out: + spin_unlock_irqrestore(&mm->context.tag_lock, flags); + return tag_desc; +} + +void del_tag_store(tag_storage_desc_t *tag_desc, struct mm_struct *mm) +{ + unsigned long flags; + unsigned char *tags = NULL; + + spin_lock_irqsave(&mm->context.tag_lock, flags); + tag_desc->tag_users--; + if (tag_desc->tag_users == 0) { + tag_desc->start = tag_desc->end = 0; + /* Do not free up the tag storage space allocated + * by the first descriptor. This is persistent + * emergency tag storage space for the task. + */ + if (tag_desc != mm->context.tag_store) { + tags = tag_desc->tags; + tag_desc->tags = NULL; + } + } + spin_unlock_irqrestore(&mm->context.tag_lock, flags); + kfree(tags); +} + +#define tag_start(addr, tag_desc) \ + ((tag_desc)->tags + ((addr - (tag_desc)->start)/(2*adi_blksize()))) + +/* Retrieve any saved ADI tags for the page being swapped back in and + * restore these tags to the newly allocated physical page. + */ +void adi_restore_tags(struct mm_struct *mm, struct vm_area_struct *vma, + unsigned long addr, pte_t pte) +{ + unsigned char *tag; + tag_storage_desc_t *tag_desc; + unsigned long paddr, tmp, version1, version2; + + /* Check if the swapped out page has an ADI version + * saved. If yes, restore version tag to the newly + * allocated page. + */ + tag_desc = find_tag_store(mm, vma, addr); + if (tag_desc == NULL) + return; + + tag = tag_start(addr, tag_desc); + paddr = pte_val(pte) & _PAGE_PADDR_4V; + for (tmp = paddr; tmp < (paddr+PAGE_SIZE); tmp += adi_blksize()) { + version1 = (*tag) >> 4; + version2 = (*tag) & 0x0f; + *tag++ = 0; + asm volatile("stxa %0, [%1] %2\n\t" + : + : "r" (version1), "r" (tmp), + "i" (ASI_MCD_REAL)); + tmp += adi_blksize(); + asm volatile("stxa %0, [%1] %2\n\t" + : + : "r" (version2), "r" (tmp), + "i" (ASI_MCD_REAL)); + } + asm volatile("membar #Sync\n\t"); + + /* Check and mark this tag space for release later if + * the swapped in page was the last user of tag space + */ + del_tag_store(tag_desc, mm); +} + +/* A page is about to be swapped out. Save any ADI tags associated with + * this physical page so they can be restored later when the page is swapped + * back in. + */ +int adi_save_tags(struct mm_struct *mm, struct vm_area_struct *vma, + unsigned long addr, pte_t oldpte) +{ + unsigned char *tag; + tag_storage_desc_t *tag_desc; + unsigned long version1, version2, paddr, tmp; + + tag_desc = alloc_tag_store(mm, vma, addr); + if (tag_desc == NULL) + return -1; + + tag = tag_start(addr, tag_desc); + paddr = pte_val(oldpte) & _PAGE_PADDR_4V; + for (tmp = paddr; tmp < (paddr+PAGE_SIZE); tmp += adi_blksize()) { + asm volatile("ldxa [%1] %2, %0\n\t" + : "=r" (version1) + : "r" (tmp), "i" (ASI_MCD_REAL)); + tmp += adi_blksize(); + asm volatile("ldxa [%1] %2, %0\n\t" + : "=r" (version2) + : "r" (tmp), "i" (ASI_MCD_REAL)); + *tag = (version1 << 4) | version2; + tag++; + } + + return 0; +} diff --git a/arch/sparc/kernel/etrap_64.S b/arch/sparc/kernel/etrap_64.S index 1276ca2567ba..7be33bf45cff 100644 --- a/arch/sparc/kernel/etrap_64.S +++ b/arch/sparc/kernel/etrap_64.S @@ -132,7 +132,33 @@ etrap_save: save %g2, -STACK_BIAS, %sp stx %g6, [%sp + PTREGS_OFF + PT_V9_G6] stx %g7, [%sp + PTREGS_OFF + PT_V9_G7] or %l7, %l0, %l7 - sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 +661: sethi %hi(TSTATE_TSO | TSTATE_PEF), %l0 + /* + * If userspace is using ADI, it could potentially pass + * a pointer with version tag embedded in it. To maintain + * the ADI security, we must enable PSTATE.mcde. Userspace + * would have already set TTE.mcd in an earlier call to + * kernel and set the version tag for the address being + * dereferenced. Setting PSTATE.mcde would ensure any + * access to userspace data through a system call honors + * ADI and does not allow a rogue app to bypass ADI by + * using system calls. Setting PSTATE.mcde only affects + * accesses to virtual addresses that have TTE.mcd set. + * Set PMCDPER to ensure any exceptions caused by ADI + * version tag mismatch are exposed before system call + * returns to userspace. Setting PMCDPER affects only + * writes to virtual addresses that have TTE.mcd set and + * have a version tag set as well. + */ + .section .sun_m7_1insn_patch, "ax" + .word 661b + sethi %hi(TSTATE_TSO | TSTATE_PEF | TSTATE_MCDE), %l0 + .previous +661: nop + .section .sun_m7_1insn_patch, "ax" + .word 661b + .word 0xaf902001 /* wrpr %g0, 1, %pmcdper */ + .previous or %l7, %l0, %l7 wrpr %l2, %tnpc wrpr %l7, (TSTATE_PRIV | TSTATE_IE), %tstate diff --git a/arch/sparc/kernel/process_64.c b/arch/sparc/kernel/process_64.c index b96104da5bd6..defa5723dfa6 100644 --- a/arch/sparc/kernel/process_64.c +++ b/arch/sparc/kernel/process_64.c @@ -664,6 +664,31 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, return 0; } +/* TIF_MCDPER in thread info flags for current task is updated lazily upon + * a context switch. Update the this flag in current task's thread flags + * before dup so the dup'd task will inherit the current TIF_MCDPER flag. + */ +int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src) +{ + if (adi_capable()) { + register unsigned long tmp_mcdper; + + __asm__ __volatile__( + ".word 0x83438000\n\t" /* rd %mcdper, %g1 */ + "mov %%g1, %0\n\t" + : "=r" (tmp_mcdper) + : + : "g1"); + if (tmp_mcdper) + set_thread_flag(TIF_MCDPER); + else + clear_thread_flag(TIF_MCDPER); + } + + *dst = *src; + return 0; +} + typedef struct { union { unsigned int pr_regs[32]; diff --git a/arch/sparc/kernel/setup_64.c b/arch/sparc/kernel/setup_64.c index 422b17880955..a9da205da394 100644 --- a/arch/sparc/kernel/setup_64.c +++ b/arch/sparc/kernel/setup_64.c @@ -240,6 +240,12 @@ void sun4v_patch_1insn_range(struct sun4v_1insn_patch_entry *start, } } +void sun_m7_patch_1insn_range(struct sun4v_1insn_patch_entry *start, + struct sun4v_1insn_patch_entry *end) +{ + sun4v_patch_1insn_range(start, end); +} + void sun4v_patch_2insn_range(struct sun4v_2insn_patch_entry *start, struct sun4v_2insn_patch_entry *end) { @@ -289,9 +295,12 @@ static void __init sun4v_patch(void) sun4v_patch_2insn_range(&__sun4v_2insn_patch, &__sun4v_2insn_patch_end); if (sun4v_chip_type == SUN4V_CHIP_SPARC_M7 || - sun4v_chip_type == SUN4V_CHIP_SPARC_SN) + sun4v_chip_type == SUN4V_CHIP_SPARC_SN) { + sun_m7_patch_1insn_range(&__sun_m7_1insn_patch, + &__sun_m7_1insn_patch_end); sun_m7_patch_2insn_range(&__sun_m7_2insn_patch, &__sun_m7_2insn_patch_end); + } sun4v_hvapi_init(); } diff --git a/arch/sparc/kernel/vmlinux.lds.S b/arch/sparc/kernel/vmlinux.lds.S index 572db686f845..20a70682cce7 100644 --- a/arch/sparc/kernel/vmlinux.lds.S +++ b/arch/sparc/kernel/vmlinux.lds.S @@ -144,6 +144,11 @@ SECTIONS *(.pause_3insn_patch) __pause_3insn_patch_end = .; } + .sun_m7_1insn_patch : { + __sun_m7_1insn_patch = .; + *(.sun_m7_1insn_patch) + __sun_m7_1insn_patch_end = .; + } .sun_m7_2insn_patch : { __sun_m7_2insn_patch = .; *(.sun_m7_2insn_patch) diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c index cd0e32bbcb1d..579f7ae75b35 100644 --- a/arch/sparc/mm/gup.c +++ b/arch/sparc/mm/gup.c @@ -11,6 +11,7 @@ #include <linux/pagemap.h> #include <linux/rwsem.h> #include <asm/pgtable.h> +#include <asm/adi.h> /* * The performance critical leaf functions are made noinline otherwise gcc @@ -157,6 +158,24 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write, pgd_t *pgdp; int nr = 0; +#ifdef CONFIG_SPARC64 + if (adi_capable()) { + long addr = start; + + /* If userspace has passed a versioned address, kernel + * will not find it in the VMAs since it does not store + * the version tags in the list of VMAs. Storing version + * tags in list of VMAs is impractical since they can be + * changed any time from userspace without dropping into + * kernel. Any address search in VMAs will be done with + * non-versioned addresses. Ensure the ADI version bits + * are dropped here by sign extending the last bit before + * ADI bits. IOMMU does not implement version tags. + */ + addr = (addr << (long)adi_nbits()) >> (long)adi_nbits(); + start = addr; + } +#endif start &= PAGE_MASK; addr = start; len = (unsigned long) nr_pages << PAGE_SHIFT; @@ -187,6 +206,24 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, pgd_t *pgdp; int nr = 0; +#ifdef CONFIG_SPARC64 + if (adi_capable()) { + long addr = start; + + /* If userspace has passed a versioned address, kernel + * will not find it in the VMAs since it does not store + * the version tags in the list of VMAs. Storing version + * tags in list of VMAs is impractical since they can be + * changed any time from userspace without dropping into + * kernel. Any address search in VMAs will be done with + * non-versioned addresses. Ensure the ADI version bits + * are dropped here by sign extending the last bit before + * ADI bits. IOMMU does not implements version tags, + */ + addr = (addr << (long)adi_nbits()) >> (long)adi_nbits(); + start = addr; + } +#endif start &= PAGE_MASK; addr = start; len = (unsigned long) nr_pages << PAGE_SHIFT; diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c index 88855e383b34..487ed1f1ce86 100644 --- a/arch/sparc/mm/hugetlbpage.c +++ b/arch/sparc/mm/hugetlbpage.c @@ -177,8 +177,20 @@ pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma, struct page *page, int writeable) { unsigned int shift = huge_page_shift(hstate_vma(vma)); + pte_t pte; - return hugepage_shift_to_tte(entry, shift); + pte = hugepage_shift_to_tte(entry, shift); + +#ifdef CONFIG_SPARC64 + /* If this vma has ADI enabled on it, turn on TTE.mcd + */ + if (vma->vm_flags & VM_SPARC_ADI) + return pte_mkmcd(pte); + else + return pte_mknotmcd(pte); +#else + return pte; +#endif } static unsigned int sun4v_huge_tte_to_shift(pte_t entry) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 3c40ebd50f92..94854e7e833e 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -3087,3 +3087,36 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) do_flush_tlb_kernel_range(start, end); } } + +void copy_user_highpage(struct page *to, struct page *from, + unsigned long vaddr, struct vm_area_struct *vma) +{ + char *vfrom, *vto; + + vfrom = kmap_atomic(from); + vto = kmap_atomic(to); + copy_user_page(vto, vfrom, vaddr, to); + kunmap_atomic(vto); + kunmap_atomic(vfrom); + + /* If this page has ADI enabled, copy over any ADI tags + * as well + */ + if (vma->vm_flags & VM_SPARC_ADI) { + unsigned long pfrom, pto, i, adi_tag; + + pfrom = page_to_phys(from); + pto = page_to_phys(to); + + for (i = pfrom; i < (pfrom + PAGE_SIZE); i += adi_blksize()) { + asm volatile("ldxa [%1] %2, %0\n\t" + : "=r" (adi_tag) + : "r" (i), "i" (ASI_MCD_REAL)); + asm volatile("stxa %0, [%1] %2\n\t" + : + : "r" (adi_tag), "r" (pto), + "i" (ASI_MCD_REAL)); + pto += adi_blksize(); + } + } +} diff --git a/arch/sparc/mm/tsb.c b/arch/sparc/mm/tsb.c index 0d4b998c7d7b..6518cc42056b 100644 --- a/arch/sparc/mm/tsb.c +++ b/arch/sparc/mm/tsb.c @@ -545,6 +545,9 @@ int init_new_context(struct task_struct *tsk, struct mm_struct *mm) mm->context.sparc64_ctx_val = 0UL; + mm->context.tag_store = NULL; + spin_lock_init(&mm->context.tag_lock); + #if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE) /* We reset them to zero because the fork() page copying * will re-increment the counters as the parent PTEs are @@ -610,4 +613,22 @@ void destroy_context(struct mm_struct *mm) } spin_unlock_irqrestore(&ctx_alloc_lock, flags); + + /* If ADI tag storage was allocated for this task, free it */ + if (mm->context.tag_store) { + tag_storage_desc_t *tag_desc; + unsigned long max_desc; + unsigned char *tags; + + tag_desc = mm->context.tag_store; + max_desc = PAGE_SIZE/sizeof(tag_storage_desc_t); + for (i = 0; i < max_desc; i++) { + tags = tag_desc->tags; + tag_desc->tags = NULL; + kfree(tags); + tag_desc++; + } + kfree(mm->context.tag_store); + mm->context.tag_store = NULL; + } } diff --git a/include/linux/mm.h b/include/linux/mm.h index b7aa3932e6d4..c0972114036f 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -231,6 +231,9 @@ extern unsigned int kobjsize(const void *objp); # define VM_GROWSUP VM_ARCH_1 #elif defined(CONFIG_IA64) # define VM_GROWSUP VM_ARCH_1 +#elif defined(CONFIG_SPARC64) +# define VM_SPARC_ADI VM_ARCH_1 /* Uses ADI tag for access control */ +# define VM_ARCH_CLEAR VM_SPARC_ADI #elif !defined(CONFIG_MMU) # define VM_MAPPED_COPY VM_ARCH_1 /* T if mapped copy of data (nommu mmap) */ #endif diff --git a/mm/ksm.c b/mm/ksm.c index 216184af0e19..bb82399816ef 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1797,6 +1797,10 @@ int ksm_madvise(struct vm_area_struct *vma, unsigned long start, if (*vm_flags & VM_SAO) return 0; #endif +#ifdef VM_SPARC_ADI + if (*vm_flags & VM_SPARC_ADI) + return 0; +#endif if (!test_bit(MMF_VM_MERGEABLE, &mm->flags)) { err = __ksm_enter(mm);
ADI is a new feature supported on SPARC M7 and newer processors to allow hardware to catch rogue accesses to memory. ADI is supported for data fetches only and not instruction fetches. An app can enable ADI on its data pages, set version tags on them and use versioned addresses to access the data pages. Upper bits of the address contain the version tag. On M7 processors, upper four bits (bits 63-60) contain the version tag. If a rogue app attempts to access ADI enabled data pages, its access is blocked and processor generates an exception. Please see Documentation/sparc/adi.txt for further details. This patch extends mprotect to enable ADI (TSTATE.mcde), enable/disable MCD (Memory Corruption Detection) on selected memory ranges, enable TTE.mcd in PTEs, return ADI parameters to userspace and save/restore ADI version tags on page swap out/in or migration. ADI is not enabled by default for any task. A task must explicitly enable ADI on a memory range and set version tag for ADI to be effective for the task. Signed-off-by: Khalid Aziz <khalid.aziz@oracle.com> Cc: Khalid Aziz <khalid@gonehiking.org> --- v7: - Enhanced arch_validate_prot() to enable ADI only on writable addresses backed by physical RAM - Added support for saving/restoring ADI tags for each ADI block size address range on a page on swap in/out - Added code to copy ADI tags on COW - Updated values for auxiliary vectors to not conflict with values on other architectures to avoid conflict in glibc. glibc consolidates all auxiliary vectors into its headers and duplicate values in consolidated header are problematic - Disable same page merging on ADI enabled pages since ADI tags may not match on pages with identical data - Broke the patch up further into smaller patches v6: - Eliminated instructions to read and write PSTATE as well as MCDPER and PMCDPER on every access to userspace addresses by setting PSTATE and PMCDPER correctly upon entry into kernel. PSTATE.mcde and PMCDPER are set upon entry into kernel when running on an M7 processor. PSTATE.mcde being set only affects memory accesses that have TTE.mcd set. PMCDPER being set only affects writes to memory addresses that have TTE.mcd set. This ensures any faults caused by ADI tag mismatch on a write are exposed before kernel returns to userspace. v5: - Fixed indentation issues and instrcuctions in assembly code - Removed CONFIG_SPARC64 from mdesc.c - Changed to maintain state of MCDPER register in thread info flags as opposed to in mm context. MCDPER is a per-thread state and belongs in thread info flag as opposed to mm context which is shared across threads. Added comments to clarify this is a lazily maintained state and must be updated on context switch and copy_process() - Updated code to use the new arch_do_swap_page() and arch_unmap_one() functions v4: - Broke patch up into smaller patches v3: - Removed CONFIG_SPARC_ADI - Replaced prctl commands with mprotect - Added auxiliary vectors for ADI parameters - Enabled ADI for swappable pages v2: - Fixed a build error Documentation/sparc/adi.txt | 272 +++++++++++++++++++++++++++++++ arch/sparc/include/asm/mman.h | 72 ++++++++- arch/sparc/include/asm/mmu_64.h | 17 ++ arch/sparc/include/asm/mmu_context_64.h | 43 +++++ arch/sparc/include/asm/page_64.h | 4 + arch/sparc/include/asm/pgtable_64.h | 46 ++++++ arch/sparc/include/asm/thread_info_64.h | 2 +- arch/sparc/include/asm/trap_block.h | 2 + arch/sparc/include/uapi/asm/mman.h | 2 + arch/sparc/kernel/adi_64.c | 277 ++++++++++++++++++++++++++++++++ arch/sparc/kernel/etrap_64.S | 28 +++- arch/sparc/kernel/process_64.c | 25 +++ arch/sparc/kernel/setup_64.c | 11 +- arch/sparc/kernel/vmlinux.lds.S | 5 + arch/sparc/mm/gup.c | 37 +++++ arch/sparc/mm/hugetlbpage.c | 14 +- arch/sparc/mm/init_64.c | 33 ++++ arch/sparc/mm/tsb.c | 21 +++ include/linux/mm.h | 3 + mm/ksm.c | 4 + 20 files changed, 913 insertions(+), 5 deletions(-) create mode 100644 Documentation/sparc/adi.txt