Message ID | 20170809202804.GA1238@felix-thinkpad.cavium.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="QMcmRD8F"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xSN7s4ygFz9s65 for <patchwork-incoming@ozlabs.org>; Thu, 10 Aug 2017 06:26:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbdHIUZ7 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Wed, 9 Aug 2017 16:25:59 -0400 Received: from mail-by2nam03on0059.outbound.protection.outlook.com ([104.47.42.59]:5345 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752047AbdHIUZ5 (ORCPT <rfc822;netdev@vger.kernel.org>); Wed, 9 Aug 2017 16:25:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SR2tlVrobVgZZ760yh5zTk1AsW4e3n7YnfIWgn0tKd0=; b=QMcmRD8F/wdfJ8m93lViqCIOD42bf4s3fKo7pacViKQAei2l8xO+DVIDjfvgdo/iSW0AeGDVGrsWckHlKx8q2OZJie93g/NxvBQ9MbyMkZTyhIPA2NT7ek6EB9UfItBJrXzHe/ZVwq28ieFzK2yHNsbLMNWqiWHuBnRLTVd8Xpg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; Received: from localhost (50.233.148.156) by CY4PR07MB3175.namprd07.prod.outlook.com (10.172.115.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Wed, 9 Aug 2017 20:25:56 +0000 Date: Wed, 9 Aug 2017 13:28:04 -0700 From: Felix Manlunas <felix.manlunas@cavium.com> To: davem@davemloft.net Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com, intiyaz.basha@cavium.com Subject: [PATCH net-next] liquidio: removed check for queue size alignment Message-ID: <20170809202804.GA1238@felix-thinkpad.cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR21CA0063.namprd21.prod.outlook.com (10.172.93.153) To CY4PR07MB3175.namprd07.prod.outlook.com (10.172.115.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 382de646-df8b-4bc2-f03e-08d4df64d703 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3175; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 3:/H9A19aWEycf1jWEsR248GPKdnZWkP9tNlaWu6uVDj80YnVtYIYoqaSbbDA/EtAkfDaADcfmecJDMAdXJZEoM5XH5cz/MvW4F6ZyknbZ76eH3HNEAit6hxAdPZ5L+VD4nQpy7gI2/5EHCma+ZmtxAp4nEX0GI8vKbeoHEMFg51EogY9WpCv5YDbchjGf6u4n8wrBxw5xD2DRgadE8y0fizALnKdc1weadS1axBarVOnJxZAcd4XEfkHdYE0/lmLI; 25:Pa3fbv5eKN1mv5dCRCoHFiNdhfbBPxcZOOG/dKJm3pormK3NvXN3Km+sXgqf6mTvWlPba2y3lIA9DOU06M1n+aQzfrJhEAu7zNA8lx+s6lbi4px0+kdEwQgf0RyoIrEZL+l8AeGLVkmCFNVfr+m/rQiDInHm7V/Xp2VmkBVVHMq/EyWcMQb7nJ1JsDbc0/xsMXf5NLuYzAyhxXUeFpv36OgkcwiDTT4zIW2SoymU+7QPQyiJESJ3RXFou/3WixyjwaALjWmWPaHTJsO1qCe+pOKXLYX/KYZXiyyvGKdARgpflOYlVHyUr9JbUzP0uMyG+h3nX+JAejPZ7Bk8xnvg+w==; 31:sCaRcp4KzCXhPJXtBAGak9CAERbqyu8e0TbhqCT70skzEeYaNehFCr78XHbB9RWY7kqs71MUdHIgK9mcUWT4XcxLYoUz1vp9x3KI42IgCN+cAfj0z/0Fta63lZiWQa2l8AJY2nSY8nBe73qQhf+nRhsyvltRXFODrBIg3kQipAKZ2AdCTQQLyREJjVLhrizfJAJXc4CLESQkuPsBOxDtxF4I5W5RMiGdu4uJ49jFSTE= X-MS-TrafficTypeDiagnostic: CY4PR07MB3175: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 20:KmhEM421/fFK/bofyzNYqWwJ+wBsPgPfQw7ZbYAyBUyxin0lKQqOzHpvn44Q49juiQZKnNlndr/i1zYgn3nFDPV+4g1Fhm5u4X3FtkzhpRFlTguInzunoc4P4QS2cd4TrlJ3sW4E5k+PAjaQdl3X7/X5xIXcB62+GbnJmKBSeI/BzPzR9/6G2jzg48lrltC2AnljrdJ9k+OD8N7Y3SabER7nHKe0zUwNwql31/bcSKRxp8ZG7DMSs66hkwQaFrYq75/0EYDXNQTGDmIIC9WjqZQ0BipD82ujOfeqeJkFuT3DhS9RrQR2d3iFjwU8jQahiXg2hqkR/edX70x2eT1JVM7wWsKt90JAfQyCnEdcv/LUOMBagBO1/rdOVISi/eZnA1B0vLLD972boxr9iCcF2T85vZnA+DSpKT7YSvJaniKebvta9N0I1Gk8+uotrF6MJWIymOVygbn1DCXd3rVC3J7USG9Z5eQavVTLSy1X7MIEQUkHLuFaNQ5p4TNaBO2I; 4:1oZet2fTIhMp+rBPpO1Y57urcfwyvQTJobANX16W/CBSRHod79dQlPgZBQ/tMZ1ABPD40wWZzdKkLO0Ju/xBUo9bmCHMt7Gq9j5McmAit/GXpvCzxR6ucZKmzTj9ChgbUyDLijCWROAktnpmBdSgLVCHNURmhkS05hkxML+zzTJaxX9HH/CwLHlD+hocgQaUgORLATkm2a9v6meq3quAedPHVb2btPxa8WhYInWmdGHybQsa/oYLgJ4ax019UerY X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: <CY4PR07MB317541BDBDBE2A1D3D2C1FF6E78B0@CY4PR07MB3175.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3175; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3175; X-Forefront-PRVS: 0394259C80 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6069001)(6009001)(39410400002)(39850400002)(39450400003)(39840400002)(39400400002)(189002)(199003)(101416001)(33656002)(47776003)(66066001)(1076002)(6116002)(23726003)(3846002)(7350300001)(54356999)(50986999)(42186005)(8676002)(81156014)(81166006)(25786009)(53936002)(110136004)(6496005)(107886003)(38730400002)(106356001)(478600001)(2361001)(2351001)(305945005)(7736002)(4326008)(76506005)(105586002)(189998001)(83506001)(6666003)(97736004)(68736007)(86362001)(4001350100001)(6916009)(5660300001)(50466002)(2906002)(72206003)(6486002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3175; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3175; 23:afD6aewH2aUltMlRlZpcpDrbo0qJx5ZGyXVYac+LY?= =?us-ascii?Q?Yj6KuyH9/QMDW9/i8QgDTWi3hNiWiJbItFW5miZxZjJrlbtuuxDo3hdp+Tdk?= =?us-ascii?Q?W2mPUBGXWnXew1ZSADQNA04ZJfFkaG0WRg35vIko+6LqEd65pWX/QzLgjVrS?= =?us-ascii?Q?djnIAxBU7l8B7N3Ql8CZ0Nlv78FFVdo+IxQ/3V9pvZ5Ju7wbaZCRgMyeJFNl?= =?us-ascii?Q?IUPEUrcznc69/cJ4Gg9DpcumBhxN/EXRKBiAFHXSFBsoF5KSi5ZpAzRmxsbi?= =?us-ascii?Q?pIuG0SQ+dLCc0pA54WGK/0VkTZhs1c5fnziS6a0LmA3lCgCeqa2Ohk+eii8l?= =?us-ascii?Q?dQOKM5aRSZ97m+zYytWU9WorWe5bJzFYVmz4Urc9rZId2rgF9Nwx1SWCb8T/?= =?us-ascii?Q?B8XizUx9cynlIsffwClL+EUrPpuQ/fNqDiT8h1BSD4ay6My0GcZmztH5mvfL?= =?us-ascii?Q?Py5v+B5ntCC/LB/ecD2gBMpH0m8DdsDCwCi0YqSWUtgRlFk1uh+Ot4HTPpwr?= =?us-ascii?Q?1tpSECjvwcs9yNZzXKSKVfcB+0x/Ev2b98gpCmqMKrUrr/iJHYfN+1j3H3vc?= =?us-ascii?Q?2WvKyF6zwVFOd/vxxyfWaAt0eldphfkQrTC/V43Y6iI5nNXfyowviRiVKJzb?= =?us-ascii?Q?zOPCghrdwxzdDPWRJjcyje71xdz2Y2l9hTer/GoeLBKy190XlcP3n1dtZrAS?= =?us-ascii?Q?7GeUvT05KCdgQ2YjxHOFKh4H58dYIIfFYsXPw8W+3PTNKowoKOdUgOBwkzcK?= =?us-ascii?Q?JM++7SetixbHg4g/hm0DSOzS8DszJeIJNqde4RkMD2UlH7FDxb6I30aOakVN?= =?us-ascii?Q?GIj2LddNE5YIdxiJK0DrSYQZDH+BmbbYgjoYob6+SLMS7vTNSUkaaR0YYFEz?= =?us-ascii?Q?6sf0h7Gwubvy8uNXQl4dfklj+00Q8kNWVfimPlCR/hrApskOyoPA+LnDIWqS?= =?us-ascii?Q?tU/ZuiRJsdF3/G8eCgJJwp42yhmZ6XjJpDpCAk7Sutcs8YuDQpfq4tlP6ODS?= =?us-ascii?Q?L5X2v9U/NPfUBuomE3Y4nD7Zf9yd7OZqC0Co0I5zv3a3FfaQ8gsMbKZp7BcY?= =?us-ascii?Q?umfC1vLW6SWF1NkiLEHTPrh3Uy8yN2ljfXmf4y95PUPWYGP+xYlwzcSRYUYg?= =?us-ascii?Q?tElsrre5SqUcWMbTUL1W1HoQRjoQJDDzioK1vzr/jMcivjdiSEo6s0EQQQnt?= =?us-ascii?Q?0T0uJ5wmyzIqsxwXIIdHY5P2Nv8JyT5FW/NKWIpkNud7F0YeT8mL/FbaaNKZ?= =?us-ascii?Q?TbBNGGxoQVeUTeTJbrvAv1SSFZjL4b/yyUO7sYMGeS22PMlitoyNlRZq7O9J?= =?us-ascii?Q?xSF3X8V/ci+EdVaEaDCBeozyPPceBmOD/mQWd3D4Tng?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3175; 6:D11CZ5dSGyTGmCBXNSJubdlzCXT7hB57rKt9NQNHSdg+yge3vn9dvJ0r2hDiqswI91v7Oyo8vitnDcuxZGsUWfNsgAgr+6v3ndp27//XN1erX3eI251U4udrcQQl/JxEzrNQ0Py2Ls2o8SV7dwaIpVH9bm141EqYM2xUoQOXK2M8KOxV2Y7/aW1fB4z3nVzo0lr6jZyk8ix31BnEYL1uZ6npMo2Cjh255avadxrnQTdFIU7dNWDuy0p50En/bSX8dzZHu4g7896TQ9kuzVLcNVTFy93qyncH6cRqyskEnJM4dFaPNCc/4XkMgh5/RThb9ksFhFbOwE9duG32NgSYoQ==; 5:FlqvOhwJjerEg6Tp+jhKaHEQBDiVca/p6p6hNlpKM4Ptnn243Pq3p0TkbjttqGTfWkdeAVHa270d1wk+ownvjH9QAUZmHrTkGMgGOhKlfF+/6aSGX6CGlgg6o/6fQB4YfE4wFwQOvAgujfNX8Tim9g==; 24:zUrv5S6+6eaXaaIQaYSG4WBL7kN6FczDWhZFc7h0KU8/4HGYambj243YA944Mps6ZepFMCP4I97Xxp0v6oKQcGH9ql5OgNBSFMYmIe5+uWw=; 7:MhsxuDsSObNji99OtiTqRYXH+vDdTsn5yzj1TmeBrGf88e4k2BJwsjBYx38aA8ZJG6QX1a7s/BCtGkFYsgabFrBiTKOVtDJ7NK3i8b0fZL9JcWGpd69/zudW+sZY4ypMvEnFbhIa2JRmLx00iMPQZDDgqjl7fbMSJ4Ri2YikrL+xGVtmPAsAaEiU+5O1qw47C3NFXFGvYTsOoWu/wNJjHCLF+L+FhEnpFAEYya7qItg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2017 20:25:56.2072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3175 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
From: Felix Manlunas <felix.manlunas@cavium.com> Date: Wed, 9 Aug 2017 13:28:04 -0700 > From: Intiyaz Basha <intiyaz.basha@cavium.com> > > There is no restriction on queue size alignment. Hence removing check for > valid queue size. > > Signed-off-by: Intiyaz Basha <intiyaz.basha@cavium.com> > Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com> Applied.
diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c index 7b297f1..770281f 100644 --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c @@ -77,13 +77,6 @@ int octeon_init_instr_queue(struct octeon_device *oct, return 1; } - if (num_descs & (num_descs - 1)) { - dev_err(&oct->pci_dev->dev, - "Number of descriptors for instr queue %d not in power of 2.\n", - iq_no); - return 1; - } - q_size = (u32)conf->instr_type * num_descs; iq = oct->instr_queue[iq_no];