diff mbox

[net-next] liquidio: removed check for queue size alignment

Message ID 20170809202804.GA1238@felix-thinkpad.cavium.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Manlunas, Felix Aug. 9, 2017, 8:28 p.m. UTC 
From: Intiyaz Basha <intiyaz.basha@cavium.com>

There is no restriction on queue size alignment.  Hence removing check for
valid queue size.

Signed-off-by: Intiyaz Basha <intiyaz.basha@cavium.com>
Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
---
 drivers/net/ethernet/cavium/liquidio/request_manager.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

David Miller Aug. 11, 2017, 8:56 p.m. UTC | #1 
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Wed, 9 Aug 2017 13:28:04 -0700

> From: Intiyaz Basha <intiyaz.basha@cavium.com>
> 
> There is no restriction on queue size alignment.  Hence removing check for
> valid queue size.
> 
> Signed-off-by: Intiyaz Basha <intiyaz.basha@cavium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>

Applied.
diff mbox

Patch

diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
index 7b297f1..770281f 100644
--- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
+++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
@@ -77,13 +77,6 @@  int octeon_init_instr_queue(struct octeon_device *oct,
 		return 1;
 	}
 
-	if (num_descs & (num_descs - 1)) {
-		dev_err(&oct->pci_dev->dev,
-			"Number of descriptors for instr queue %d not in power of 2.\n",
-			iq_no);
-		return 1;
-	}
-
 	q_size = (u32)conf->instr_type * num_descs;
 
 	iq = oct->instr_queue[iq_no];