| Message ID | 1502295823-20824-3-git-send-email-arvind.yadav.cs@gmail.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Aug 9, 2017 at 9:23 AM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by <linux/usb.h> work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2: > Re-submitting wireless separately. > > drivers/net/wireless/ath/ath6kl/usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c > index 9da3594..4defb7a 100644 > --- a/drivers/net/wireless/ath/ath6kl/usb.c > +++ b/drivers/net/wireless/ath/ath6kl/usb.c > @@ -1201,7 +1201,7 @@ static int ath6kl_usb_pm_resume(struct usb_interface *interface) > #endif > > /* table of devices that work with this driver */ > -static struct usb_device_id ath6kl_usb_ids[] = { > +static const struct usb_device_id ath6kl_usb_ids[] = { > {USB_DEVICE(0x0cf3, 0x9375)}, > {USB_DEVICE(0x0cf3, 0x9374)}, > { /* Terminating entry */ }, > -- > 2.7.4 > Looks good. Also builds and works properly. Reviewed-by: Steve deRosier <derosier@gmail.com> Tested-by: Steve deRosier <derosier@gmail.com> - Steve
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by <linux/usb.h> work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > Reviewed-by: Steve deRosier <derosier@gmail.com> > Tested-by: Steve deRosier <derosier@gmail.com> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> 2 patches applied to ath-next branch of ath.git, thanks. e881a6584941 ath6kl: constify usb_device_id 76b07b30c46b ath9k: constify usb_device_id
diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c index 9da3594..4defb7a 100644 --- a/drivers/net/wireless/ath/ath6kl/usb.c +++ b/drivers/net/wireless/ath/ath6kl/usb.c @@ -1201,7 +1201,7 @@ static int ath6kl_usb_pm_resume(struct usb_interface *interface) #endif /* table of devices that work with this driver */ -static struct usb_device_id ath6kl_usb_ids[] = { +static const struct usb_device_id ath6kl_usb_ids[] = { {USB_DEVICE(0x0cf3, 0x9375)}, {USB_DEVICE(0x0cf3, 0x9374)}, { /* Terminating entry */ },
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by <linux/usb.h> work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: Re-submitting wireless separately. drivers/net/wireless/ath/ath6kl/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)