[1/2,v2] PCI: v3: Update the device tree bindings

Message ID 20170809141455.22220-1-linus.walleij@linaro.org
State Changes Requested
Headers show

Commit Message

Linus Walleij Aug. 9, 2017, 2:14 p.m.
The bindings for the V3 Semiconductor PCI bridge are a tad bit outdated
and predates the more formal format we have adopted for the bindings.
Update them a bit so it is easier to read, and add the Integrator AP-
specific compatible so we can detect that we are running on that specific
platform.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Added Rob's ACK.

Bjorn: please merge this when you feel confident with it.
---
 .../devicetree/bindings/pci/v3-v360epc-pci.txt        | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Bjorn Helgaas Aug. 22, 2017, 7:09 p.m. | #1
On Wed, Aug 09, 2017 at 04:14:54PM +0200, Linus Walleij wrote:
> The bindings for the V3 Semiconductor PCI bridge are a tad bit outdated
> and predates the more formal format we have adopted for the bindings.
> Update them a bit so it is easier to read, and add the Integrator AP-
> specific compatible so we can detect that we are running on that specific
> platform.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Added Rob's ACK.
> 
> Bjorn: please merge this when you feel confident with it.
> ---
>  .../devicetree/bindings/pci/v3-v360epc-pci.txt        | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt b/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt
> index 30b364e504ba..bcc5fe2a74cb 100644
> --- a/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt
> @@ -2,14 +2,15 @@ V3 Semiconductor V360 EPC PCI bridge
>  
>  This bridge is found in the ARM Integrator/AP (Application Platform)
>  
> -Integrator-specific notes:
> -
> -- syscon: should contain a link to the syscon device node (since
> -  on the Integrator, some registers in the syscon are required to
> -  operate the V3).
> -
> -V360 EPC specific notes:
> -
> -- reg: should contain the base address of the V3 adapter.
> +Required properties:
> +- compatible: should be one of:
> +  "v3,v360epc-pci"
> +  "arm,integrator-ap-pci", "v3,v360epc-pci"
> +- reg: should contain the base address of the V3 host bridge.

Does this need some sort of comment about how the non-pref and pref mem
windows need to be 256Mb and adjacent?  I think the driver makes some
unverified assumptions about them.

>  - interrupts: should contain a reference to the V3 error interrupt
>    as routed on the system.
> +
> +Integrator-specific required properties:
> +- syscon: should contain a link to the syscon device node, since
> +  on the Integrator, some registers in the syscon are required to
> +  operate the V3 host bridge.
> -- 
> 2.9.4
>
Linus Walleij Sept. 1, 2017, 12:06 p.m. | #2
On Tue, Aug 22, 2017 at 9:09 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:

> On Wed, Aug 09, 2017 at 04:14:54PM +0200, Linus Walleij wrote:
>> The bindings for the V3 Semiconductor PCI bridge are a tad bit outdated
>> and predates the more formal format we have adopted for the bindings.
>> Update them a bit so it is easier to read, and add the Integrator AP-
>> specific compatible so we can detect that we are running on that specific
>> platform.
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
(...)
>> -- reg: should contain the base address of the V3 adapter.
>> +Required properties:
>> +- compatible: should be one of:
>> +  "v3,v360epc-pci"
>> +  "arm,integrator-ap-pci", "v3,v360epc-pci"
>> +- reg: should contain the base address of the V3 host bridge.
>
> Does this need some sort of comment about how the non-pref and pref mem
> windows need to be 256Mb and adjacent?  I think the driver makes some
> unverified assumptions about them.

Yeah that is how I understand that it works as well. I will document
this in the binding.

Yours,
Linus Walleij

Patch

diff --git a/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt b/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt
index 30b364e504ba..bcc5fe2a74cb 100644
--- a/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt
+++ b/Documentation/devicetree/bindings/pci/v3-v360epc-pci.txt
@@ -2,14 +2,15 @@  V3 Semiconductor V360 EPC PCI bridge
 
 This bridge is found in the ARM Integrator/AP (Application Platform)
 
-Integrator-specific notes:
-
-- syscon: should contain a link to the syscon device node (since
-  on the Integrator, some registers in the syscon are required to
-  operate the V3).
-
-V360 EPC specific notes:
-
-- reg: should contain the base address of the V3 adapter.
+Required properties:
+- compatible: should be one of:
+  "v3,v360epc-pci"
+  "arm,integrator-ap-pci", "v3,v360epc-pci"
+- reg: should contain the base address of the V3 host bridge.
 - interrupts: should contain a reference to the V3 error interrupt
   as routed on the system.
+
+Integrator-specific required properties:
+- syscon: should contain a link to the syscon device node, since
+  on the Integrator, some registers in the syscon are required to
+  operate the V3 host bridge.