Patchwork ppc: Fix BookE tlb entry reads

login
register
mail settings
Submitter Edgar Iglesias
Date Jan. 21, 2011, 10:43 p.m.
Message ID <20110121224347.GA21090@laped.lan>
Download mbox | patch
Permalink /patch/79960/
State New
Headers show

Comments

Edgar Iglesias - Jan. 21, 2011, 10:43 p.m.
commit 5823947f9f1e55fb6599c9ed769ce25cdec38355
Author: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Date:   Fri Jan 21 23:12:42 2011 +0100

    ppc: Correct BookE tlb reads
    
    Call the tlb read helper (and not the write helper) for tlb
    reads.
    
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Alexander Graf - Jan. 21, 2011, 10:49 p.m.
On 21.01.2011, at 23:43, Edgar E. Iglesias wrote:

> commit 5823947f9f1e55fb6599c9ed769ce25cdec38355
> Author: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Date:   Fri Jan 21 23:12:42 2011 +0100
> 
>    ppc: Correct BookE tlb reads
> 
>    Call the tlb read helper (and not the write helper) for tlb
>    reads.
> 
>    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

Acked-by: Alexander Graf <agraf@suse.de>


Alex
Edgar Iglesias - Jan. 21, 2011, 10:57 p.m.
On Fri, Jan 21, 2011 at 11:49:41PM +0100, Alexander Graf wrote:
> 
> On 21.01.2011, at 23:43, Edgar E. Iglesias wrote:
> 
> > commit 5823947f9f1e55fb6599c9ed769ce25cdec38355
> > Author: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> > Date:   Fri Jan 21 23:12:42 2011 +0100
> > 
> >    ppc: Correct BookE tlb reads
> > 
> >    Call the tlb read helper (and not the write helper) for tlb
> >    reads.
> > 
> >    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> 
> Acked-by: Alexander Graf <agraf@suse.de>

Thanks for the quick ack. Applied.

Cheers

Patch

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 74e06d7..89413c5 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -5874,7 +5874,7 @@  static void gen_tlbre_440(DisasContext *ctx)
     case 2:
         {
             TCGv_i32 t0 = tcg_const_i32(rB(ctx->opcode));
-            gen_helper_440_tlbwe(t0, cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]);
+            gen_helper_440_tlbre(cpu_gpr[rD(ctx->opcode)], t0, cpu_gpr[rA(ctx->opcode)]);
             tcg_temp_free_i32(t0);
         }
         break;