| Message ID | 1502270183-15960-8-git-send-email-peng.fan@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
> -----Original Message----- > From: Peng Fan > Sent: Wednesday, August 09, 2017 5:16 PM > To: sbabic@denx.de > Cc: van.freenix@gmail.com; u-boot@lists.denx.de; Peng Fan > <peng.fan@nxp.com>; Simon Glass <sjg@chromium.org> > Subject: [PATCH 07/12] scripts: spl: Disable DM MMC when SPL DM not > enabled > > Disable DM MMC when SPL DM not enabled. Missed to note that this patch depends on https://patchwork.ozlabs.org/patch/798992/ Thanks, Peng. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Simon Glass <sjg@chromium.org> > --- > scripts/Makefile.uncmd_spl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/Makefile.uncmd_spl b/scripts/Makefile.uncmd_spl index > b399411..983686f 100644 > --- a/scripts/Makefile.uncmd_spl > +++ b/scripts/Makefile.uncmd_spl > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO= > CONFIG_DM_I2C= > CONFIG_DM_SPI= > CONFIG_DM_SPI_FLASH= > +CONFIG_DM_MMC= > endif > > endif > -- > 2.6.2
Hi Peng, On 9 August 2017 at 03:16, Peng Fan <peng.fan@nxp.com> wrote: > Disable DM MMC when SPL DM not enabled. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Simon Glass <sjg@chromium.org> > --- > scripts/Makefile.uncmd_spl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/Makefile.uncmd_spl b/scripts/Makefile.uncmd_spl > index b399411..983686f 100644 > --- a/scripts/Makefile.uncmd_spl > +++ b/scripts/Makefile.uncmd_spl > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO= > CONFIG_DM_I2C= > CONFIG_DM_SPI= > CONFIG_DM_SPI_FLASH= > +CONFIG_DM_MMC= We already have CONFIG_SPL_DM_MMC - can we use that instead? > endif > > endif > -- > 2.6.2 > Regards, Simon
> -----Original Message----- > From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass > Sent: Monday, August 14, 2017 5:37 AM > To: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de>; Peng Fan <van.freenix@gmail.com>; U- > Boot Mailing List <u-boot@lists.denx.de> > Subject: Re: [PATCH 07/12] scripts: spl: Disable DM MMC when SPL DM not > enabled > > Hi Peng, > > On 9 August 2017 at 03:16, Peng Fan <peng.fan@nxp.com> wrote: > > Disable DM MMC when SPL DM not enabled. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > Cc: Stefano Babic <sbabic@denx.de> > > Cc: Simon Glass <sjg@chromium.org> > > --- > > scripts/Makefile.uncmd_spl | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/Makefile.uncmd_spl b/scripts/Makefile.uncmd_spl > > index b399411..983686f 100644 > > --- a/scripts/Makefile.uncmd_spl > > +++ b/scripts/Makefile.uncmd_spl > > @@ -12,6 +12,7 @@ CONFIG_DM_GPIO= > > CONFIG_DM_I2C= > > CONFIG_DM_SPI= > > CONFIG_DM_SPI_FLASH= > > +CONFIG_DM_MMC= > > We already have CONFIG_SPL_DM_MMC - can we use that instead? Yeah. This patch could be removed. Thanks, Peng. > > > endif > > > > endif > > -- > > 2.6.2 > > > > Regards, > Simon
diff --git a/scripts/Makefile.uncmd_spl b/scripts/Makefile.uncmd_spl index b399411..983686f 100644 --- a/scripts/Makefile.uncmd_spl +++ b/scripts/Makefile.uncmd_spl @@ -12,6 +12,7 @@ CONFIG_DM_GPIO= CONFIG_DM_I2C= CONFIG_DM_SPI= CONFIG_DM_SPI_FLASH= +CONFIG_DM_MMC= endif endif
Disable DM MMC when SPL DM not enabled. Signed-off-by: Peng Fan <peng.fan@nxp.com> Cc: Stefano Babic <sbabic@denx.de> Cc: Simon Glass <sjg@chromium.org> --- scripts/Makefile.uncmd_spl | 1 + 1 file changed, 1 insertion(+)