diff mbox

[U-Boot] mmc: Support generic PCI SD host controller

Message ID 1502263260-14580-1-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit a191ccaf12fb4fadedcd3c76df6327e2bb0f182b
Delegated to: Jaehoon Chung
Headers show

Commit Message

Bin Meng Aug. 9, 2017, 7:21 a.m. UTC
This changes pci_mmc driver to use PCI_CLASS_SYSTEM_SDHCI instead of
individual vendor id & device id pair to support generic PCI SD host
controller.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/mmc/pci_mmc.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Bin Meng Aug. 14, 2017, 3:06 p.m. UTC | #1
Hi Jaehoon, Tom,

On Wed, Aug 9, 2017 at 3:21 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> This changes pci_mmc driver to use PCI_CLASS_SYSTEM_SDHCI instead of
> individual vendor id & device id pair to support generic PCI SD host
> controller.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  drivers/mmc/pci_mmc.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>

Who is going to review and take this patch?

Regards,
Bin
Tom Rini Aug. 14, 2017, 4:01 p.m. UTC | #2
On Mon, Aug 14, 2017 at 11:06:32PM +0800, Bin Meng wrote:
> Hi Jaehoon, Tom,
> 
> On Wed, Aug 9, 2017 at 3:21 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> > This changes pci_mmc driver to use PCI_CLASS_SYSTEM_SDHCI instead of
> > individual vendor id & device id pair to support generic PCI SD host
> > controller.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> >  drivers/mmc/pci_mmc.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> >
> 
> Who is going to review and take this patch?

I would expect Jaehoon to review and take this.  Thanks!
Jaehoon Chung Aug. 17, 2017, 9 a.m. UTC | #3
On 08/09/2017 04:21 PM, Bin Meng wrote:
> This changes pci_mmc driver to use PCI_CLASS_SYSTEM_SDHCI instead of
> individual vendor id & device id pair to support generic PCI SD host
> controller.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
>  drivers/mmc/pci_mmc.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/mmc/pci_mmc.c b/drivers/mmc/pci_mmc.c
> index 6db8977..05c0044 100644
> --- a/drivers/mmc/pci_mmc.c
> +++ b/drivers/mmc/pci_mmc.c
> @@ -64,12 +64,7 @@ U_BOOT_DRIVER(pci_mmc) = {
>  };
>  
>  static struct pci_device_id mmc_supported[] = {
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_SDIO) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_SD) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QRK_SDIO) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TCF_SDIO_0) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TCF_SDIO_1) },
> +	{ PCI_DEVICE_CLASS(PCI_CLASS_SYSTEM_SDHCI << 8, 0xffff00) },
>  	{},
>  };
>  
>
Jaehoon Chung Aug. 17, 2017, 9:01 a.m. UTC | #4
On 08/09/2017 04:21 PM, Bin Meng wrote:
> This changes pci_mmc driver to use PCI_CLASS_SYSTEM_SDHCI instead of
> individual vendor id & device id pair to support generic PCI SD host
> controller.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Sorry for late. Applied to u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

> ---
> 
>  drivers/mmc/pci_mmc.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/mmc/pci_mmc.c b/drivers/mmc/pci_mmc.c
> index 6db8977..05c0044 100644
> --- a/drivers/mmc/pci_mmc.c
> +++ b/drivers/mmc/pci_mmc.c
> @@ -64,12 +64,7 @@ U_BOOT_DRIVER(pci_mmc) = {
>  };
>  
>  static struct pci_device_id mmc_supported[] = {
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_SDIO) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_SD) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QRK_SDIO) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TCF_SDIO_0) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TCF_SDIO_1) },
> +	{ PCI_DEVICE_CLASS(PCI_CLASS_SYSTEM_SDHCI << 8, 0xffff00) },
>  	{},
>  };
>  
>
Bin Meng Aug. 17, 2017, 9:19 a.m. UTC | #5
Hi Jaehoon,

On Thu, Aug 17, 2017 at 5:01 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 08/09/2017 04:21 PM, Bin Meng wrote:
>> This changes pci_mmc driver to use PCI_CLASS_SYSTEM_SDHCI instead of
>> individual vendor id & device id pair to support generic PCI SD host
>> controller.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> Sorry for late. Applied to u-boot-mmc. Thanks!
>

No problem. Thanks!

Regards,
Bin
diff mbox

Patch

diff --git a/drivers/mmc/pci_mmc.c b/drivers/mmc/pci_mmc.c
index 6db8977..05c0044 100644
--- a/drivers/mmc/pci_mmc.c
+++ b/drivers/mmc/pci_mmc.c
@@ -64,12 +64,7 @@  U_BOOT_DRIVER(pci_mmc) = {
 };
 
 static struct pci_device_id mmc_supported[] = {
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_SDIO) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_SD) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QRK_SDIO) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TCF_SDIO_0) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TCF_SDIO_1) },
+	{ PCI_DEVICE_CLASS(PCI_CLASS_SYSTEM_SDHCI << 8, 0xffff00) },
 	{},
 };