Patchwork [1/3] tests: Fix two memory leaks

login
register
mail settings
Submitter Stefan Weil
Date Jan. 21, 2011, 9:49 p.m.
Message ID <1295646569-31125-1-git-send-email-weil@mail.berlios.de>
Download mbox | patch
Permalink /patch/79945/
State Accepted
Headers show

Comments

Stefan Weil - Jan. 21, 2011, 9:49 p.m.
Although both leaks are not really important, fix them
to avoid cppcheck warnings:

tests/linux-test.c:433: error: Memory leak: stack1
tests/linux-test.c:433: error: Memory leak: stack2

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 tests/linux-test.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Aurelien Jarno - Feb. 20, 2011, 5:44 p.m.
On Fri, Jan 21, 2011 at 10:49:29PM +0100, Stefan Weil wrote:
> Although both leaks are not really important, fix them
> to avoid cppcheck warnings:
> 
> tests/linux-test.c:433: error: Memory leak: stack1
> tests/linux-test.c:433: error: Memory leak: stack2
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  tests/linux-test.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/tests/linux-test.c b/tests/linux-test.c
> index 9986e29..2e4a746 100644
> --- a/tests/linux-test.c
> +++ b/tests/linux-test.c
> @@ -426,7 +426,9 @@ void test_clone(void)
>                             CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, "hello2"));
>  
>      while (waitpid(pid1, &status1, 0) != pid1);
> +    free(stack1);
>      while (waitpid(pid2, &status2, 0) != pid2);
> +    free(stack2);
>      if (thread1_res != 5 ||
>          thread2_res != 6)
>          error("clone");
> -- 
> 1.7.2.3
> 
> 
>

Patch

diff --git a/tests/linux-test.c b/tests/linux-test.c
index 9986e29..2e4a746 100644
--- a/tests/linux-test.c
+++ b/tests/linux-test.c
@@ -426,7 +426,9 @@  void test_clone(void)
                            CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, "hello2"));
 
     while (waitpid(pid1, &status1, 0) != pid1);
+    free(stack1);
     while (waitpid(pid2, &status2, 0) != pid2);
+    free(stack2);
     if (thread1_res != 5 ||
         thread2_res != 6)
         error("clone");