| Message ID | 21089a62-0b49-ef34-6eb0-33510a5638c0@linux.vnet.ibm.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: John Allen <jallen@linux.vnet.ibm.com> Date: Mon, 7 Aug 2017 15:42:30 -0500 > Reporting any return code for a receive buffer as an "rx error" only > produces alarming noise and the only values that have been observed to be > used in this field are not error conditions. Change this to a netdev_dbg > with a more descriptive message. > > Signed-off-by: John Allen <jallen@linux.vnet.ibm.com> Applied, thanks John.
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 5932160..99576ba 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1579,7 +1579,8 @@ static int ibmvnic_poll(struct napi_struct *napi, int budget) rx_comp.correlator); /* do error checking */ if (next->rx_comp.rc) { - netdev_err(netdev, "rx error %x\n", next->rx_comp.rc); + netdev_dbg(netdev, "rx buffer returned with rc %x\n", + be16_to_cpu(next->rx_comp.rc)); /* free the entry */ next->rx_comp.first = 0; remove_buff_from_pool(adapter, rx_buff);
Reporting any return code for a receive buffer as an "rx error" only produces alarming noise and the only values that have been observed to be used in this field are not error conditions. Change this to a netdev_dbg with a more descriptive message. Signed-off-by: John Allen <jallen@linux.vnet.ibm.com> ---