| Message ID | f1d16f5ac3eb170493ca7835a7c39c1b4675a81f.1502135910.git.geoff@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 00e7c259e9c44f414ead5fc9bb3c459d8235045c |
| Headers | show |
> @@ -741,7 +741,11 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev) > goto out_unmap_reports; > } > > - ps3vram_cache_init(dev); > + error = ps3vram_cache_init(dev); > + if (error < 0) { > + goto out_unmap_reports; > + } > + > ps3vram_proc_init(dev); > > queue = blk_alloc_queue(GFP_KERNEL); I pointed a few development concerns out. https://patchwork.ozlabs.org/patch/798575/ Will the commit subject “block/ps3vram: Check return value of ps3vram_cache_init()” be more appropriate? Regards, Markus
On Mon, 2017-08-07 at 20:09:20 UTC, Geoff Levand wrote: > Cc: Markus Elfring <elfring@users.sourceforge.net> > Cc: Jim Paris <jim@jtan.com> > Cc: Jens Axboe <axboe@kernel.dk> > Signed-off-by: Geoff Levand <geoff@infradead.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/00e7c259e9c44f414ead5fc9bb3c45 cheers
diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index ba97d037279e..6a55959cbf78 100644 --- a/drivers/block/ps3vram.c +++ b/drivers/block/ps3vram.c @@ -741,7 +741,11 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev) goto out_unmap_reports; } - ps3vram_cache_init(dev); + error = ps3vram_cache_init(dev); + if (error < 0) { + goto out_unmap_reports; + } + ps3vram_proc_init(dev); queue = blk_alloc_queue(GFP_KERNEL);
Cc: Markus Elfring <elfring@users.sourceforge.net> Cc: Jim Paris <jim@jtan.com> Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by: Geoff Levand <geoff@infradead.org> --- drivers/block/ps3vram.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)