From patchwork Mon Aug 7 14:55:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Henrique Cerri X-Patchwork-Id: 798680 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical-com.20150623.gappssmtp.com header.i=@canonical-com.20150623.gappssmtp.com header.b="mYIriakP"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3xR0vR6Wr8z9sMN; Tue, 8 Aug 2017 00:55:31 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1dejRJ-0006mN-0x; Mon, 07 Aug 2017 14:55:29 +0000 Received: from mail-qk0-f174.google.com ([209.85.220.174]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1dejRE-0006lx-7k for kernel-team@lists.ubuntu.com; Mon, 07 Aug 2017 14:55:24 +0000 Received: by mail-qk0-f174.google.com with SMTP id a77so4005023qkb.0 for ; Mon, 07 Aug 2017 07:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=hU4ePwqPJPi3aZrlCnWqEAadDdvtyMmEfv3XpPVwJJ4=; b=mYIriakP6dtx5HkLgh1cG5fwdBR/cyD0D/I4owJI9XwD+bP25CRV8xfeYTgq6AEDQU f7oM7mU9Y9BTLCa+H3yQfzwOxpV11H4vm0414OkZne7RRl9Wjn1sos6sBYxPQguDoKpH xeZ0YBLygDq1WU3cIGV2Zbg+jr9fg3Y/GKtvEN3ViRcAavDGRRtBrOuaE7IE51VX8vCb Q1SGhT8TurmtEPZiJJ+BGt2GeEwJSfKWVDE2286AVhkYAhRaMM2Y88DjdB8Lgo5F4jNv YC24smNlk0jG58Hw/XP0jY/J/XvrG0NDWtn+cgsCuPr5CxkKiHdjdefT1GHbo/yXFjLj N8Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=hU4ePwqPJPi3aZrlCnWqEAadDdvtyMmEfv3XpPVwJJ4=; b=rrvRaoyjkeBu6dEeNMz/IKQgctgckJSH+o/7hSBWe2ZaUtVmREw5w/nmR8i3jG8kfX svC2mPHrGQdxA1isdikgELV2St0lLGO49lcDN48krbvWHPnw2Hg2jPdEptV8g9Kav8bi K2ULJMui9drbel4b0Jml1h0E81mzypH+jPpoxzLgub1OIsVPGm9YSa1kM50oGTMMHsHx GfDwIUPkAEKiZYO1qchfffuZ5F5sm8h0spQBwoKvzXR23zmGLBJAWd2IkIIuGNJdTmiT pGah3a+GFMM+Ws+nvetuUOlWIg5wP1+gJFC5Q9+oQd1GOAK2AqzWV55L6yVhJz8PuYvC jFEQ== X-Gm-Message-State: AHYfb5jqaIHwn2klUdDo8s3mjII3up/Nt4SfHAsYkACHqEL8V8Sp4xdb kCes/7keDkKg+YRYnyo= X-Received: by 10.55.209.86 with SMTP id s83mr1009717qki.171.1502117722995; Mon, 07 Aug 2017 07:55:22 -0700 (PDT) Received: from localhost.localdomain ([191.8.84.147]) by smtp.gmail.com with ESMTPSA id y10sm6089645qtb.57.2017.08.07.07.55.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Aug 2017 07:55:22 -0700 (PDT) From: Marcelo Henrique Cerri To: kernel-team@lists.ubuntu.com Subject: [azure][PATCH] UBUNTU: SAUCE: vmbus-rdma: Use _ to separate major and minor host OS version Date: Mon, 7 Aug 2017 11:55:15 -0300 Message-Id: <1502117715-25614-1-git-send-email-marcelo.cerri@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com BugLink: http://bugs.launchpad.net/bugs/1709101 kmod tools seems to not handle properly module names with dots. Impact: Currently RDMA drivers names have a dot to separate the major and minor host OS version number (eg, hv_network_directly_142.0.ko). That causes some unexpected behavior with the kmod tools. modprobe ignores everything after the dot, so it's only possible to load the modules manually with `modprobe hv_network_direct_142` instead of `modprobe hv_network_direct_142.0`. Also, after the modules is loaded, lsmod shows some errors when searching for `/sys/module/hv_network_direct_142.0` while only `/sys/module/hv_network_direct_142` is available. Fix: Replace dots with underscores to separate major and minor host OS version numbers. Testcase: The user should be able to load the drivers with their complete name, eg `modprobe hv_network_direct_142_0` and lsmod should not show any errors after the module is loaded. Signed-off-by: Marcelo Henrique Cerri Acked-by: Marcelo Henrique Cerri --- debian.azure/abi/4.11.0-1005.5/amd64/azure.modules | 4 ++-- drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile | 4 ++-- drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules b/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules index adf80fa92cd2..863909400f94 100644 --- a/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules +++ b/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules @@ -240,8 +240,8 @@ hid-generic hid-hyperv hv_balloon hv_netvsc -hv_network_direct_142.0 -hv_network_direct_144.0 +hv_network_direct_142_0 +hv_network_direct_144_0 hv_sock hv_utils hyperv_fb diff --git a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile index 8fc23718bcf1..bc825bb4fb0d 100644 --- a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile +++ b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_142.0.o +obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_142_0.o -hv_network_direct_142.0-y := provider.o vmbus_rdma.o hvnd_addr.o +hv_network_direct_142_0-y := provider.o vmbus_rdma.o hvnd_addr.o diff --git a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile index 19afb983ea70..f55fa77566a8 100644 --- a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile +++ b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_144.0.o +obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_144_0.o -hv_network_direct_144.0-y := provider.o vmbus_rdma.o hvnd_addr.o +hv_network_direct_144_0-y := provider.o vmbus_rdma.o hvnd_addr.o