From patchwork Mon Aug 7 14:52:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Henrique Cerri X-Patchwork-Id: 798676 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical-com.20150623.gappssmtp.com header.i=@canonical-com.20150623.gappssmtp.com header.b="hGMMRE6o"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3xR0rJ1ww2z9s7g; Tue, 8 Aug 2017 00:52:48 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1dejOe-0006GZ-Pv; Mon, 07 Aug 2017 14:52:44 +0000 Received: from mail-qt0-f171.google.com ([209.85.216.171]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1dejOZ-0006Fo-8t for kernel-team@lists.ubuntu.com; Mon, 07 Aug 2017 14:52:39 +0000 Received: by mail-qt0-f171.google.com with SMTP id p3so3999477qtg.2 for ; Mon, 07 Aug 2017 07:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=hU4ePwqPJPi3aZrlCnWqEAadDdvtyMmEfv3XpPVwJJ4=; b=hGMMRE6oySkiQ4xAsspfbbduDx/Wqap3n1OqvgS/twL3YknTSYFopCWNG9ErL6qQ9J ooAkJh5o2gYqm2jc2dAg7hQ/0E/H17JVdjM7PqEoBjyalG9OHqOsEkI62+fBHW0hxH4z TgpoJbZMb2IlwzivzaOI997qYovfJzSs0FRKlW+D0dLsKfBqkuHXcoRGC55ucKLh1zOz YE9fukk4Dxsvrrz/oHb7GVefdQzHTYTLxyzG38BuCxp5wpRKtZEl8Bsxha7HEUNv5tgr n1KdsI6ZsjPbnISkLJXV+H25hCq0OaCjMcdoA0t5SLbPIo7fJFERGTr3wBkfn4mN5O+C ZUTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=hU4ePwqPJPi3aZrlCnWqEAadDdvtyMmEfv3XpPVwJJ4=; b=X0dRbZynjEVQ9t5boFB47M6/g4wjeGI4lkR60kH2lj8NaFJl66Slc7nwqBhWzWyIrg hlx5duoJ8ai0EIJspNE3JFaAe3G6FY7vdidyOfHZorTSusTWyaJIIJvWNSGsaqwkI13s 0jwtfnsVALFBNp50uioJXWUqmdaA4eO8ZpJQfhT0UWIAjaJSGc0rCnhG9HysrePdHKc8 InDYnjo2B+lPau92fU5fy0KSUOLEqnxCnJ/htbZ+E/6/vC0K+uOeG/MApwKvTTL6l7mV qoi3B0G2To8EHv+KpJ/jjjDJPeFd7AVDFzNQpFF7g8V8tBNw/QDs8+ZsOSyRJQyFJd+N +gcQ== X-Gm-Message-State: AHYfb5gJbqp1TJ5dY0bClP6DhqGzvP15+8jyVSopVf4HMO7U5Arhffq3 L57gp+miFm3N0ckMUg4= X-Received: by 10.237.53.66 with SMTP id b2mr1144612qte.24.1502117558030; Mon, 07 Aug 2017 07:52:38 -0700 (PDT) Received: from localhost.localdomain ([191.8.84.147]) by smtp.gmail.com with ESMTPSA id f55sm5926766qtc.18.2017.08.07.07.52.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Aug 2017 07:52:37 -0700 (PDT) From: Marcelo Henrique Cerri To: kernel-team@lists.ubuntu.com Subject: [azure][PATCH] U BUNTU: SAUCE: vmbus-rdma: Use _ to separate major and minor host OS version Date: Mon, 7 Aug 2017 11:52:29 -0300 Message-Id: <1502117549-24086-1-git-send-email-marcelo.cerri@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com BugLink: http://bugs.launchpad.net/bugs/1709101 kmod tools seems to not handle properly module names with dots. Impact: Currently RDMA drivers names have a dot to separate the major and minor host OS version number (eg, hv_network_directly_142.0.ko). That causes some unexpected behavior with the kmod tools. modprobe ignores everything after the dot, so it's only possible to load the modules manually with `modprobe hv_network_direct_142` instead of `modprobe hv_network_direct_142.0`. Also, after the modules is loaded, lsmod shows some errors when searching for `/sys/module/hv_network_direct_142.0` while only `/sys/module/hv_network_direct_142` is available. Fix: Replace dots with underscores to separate major and minor host OS version numbers. Testcase: The user should be able to load the drivers with their complete name, eg `modprobe hv_network_direct_142_0` and lsmod should not show any errors after the module is loaded. Signed-off-by: Marcelo Henrique Cerri Acked-by: Marcelo Henrique Cerri --- debian.azure/abi/4.11.0-1005.5/amd64/azure.modules | 4 ++-- drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile | 4 ++-- drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules b/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules index adf80fa92cd2..863909400f94 100644 --- a/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules +++ b/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules @@ -240,8 +240,8 @@ hid-generic hid-hyperv hv_balloon hv_netvsc -hv_network_direct_142.0 -hv_network_direct_144.0 +hv_network_direct_142_0 +hv_network_direct_144_0 hv_sock hv_utils hyperv_fb diff --git a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile index 8fc23718bcf1..bc825bb4fb0d 100644 --- a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile +++ b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_142.0.o +obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_142_0.o -hv_network_direct_142.0-y := provider.o vmbus_rdma.o hvnd_addr.o +hv_network_direct_142_0-y := provider.o vmbus_rdma.o hvnd_addr.o diff --git a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile index 19afb983ea70..f55fa77566a8 100644 --- a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile +++ b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_144.0.o +obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_144_0.o -hv_network_direct_144.0-y := provider.o vmbus_rdma.o hvnd_addr.o +hv_network_direct_144_0-y := provider.o vmbus_rdma.o hvnd_addr.o