| Message ID | 20170806164428.2273-36-mikko.rapeli@iki.fi |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote: > It is not needed and not part of uapi headers, but causes > user space compilation error: > > fatal error: net/tcp.h: No such file or directory > #include <net/tcp.h> > ^ > > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> > Cc: Dave Watson <davejwatson@fb.com> > Cc: Ilya Lesokhin <ilyal@mellanox.com> > Cc: Aviad Yehezkel <aviadye@mellanox.com> > --- > include/uapi/linux/tls.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h > index cc1d21db35d8..d87c698623f2 100644 > --- a/include/uapi/linux/tls.h > +++ b/include/uapi/linux/tls.h > @@ -37,7 +37,9 @@ > #include <asm/byteorder.h> > #include <linux/socket.h> > #include <linux/tcp.h> > +#ifdef __KERNEL__ > #include <net/tcp.h> > +#endif Let's move it to include/net/tls.h instead.
On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote: > On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote: > > It is not needed and not part of uapi headers, but causes > > user space compilation error: > > > > fatal error: net/tcp.h: No such file or directory > > #include <net/tcp.h> > > ^ > > > > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> > > Cc: Dave Watson <davejwatson@fb.com> > > Cc: Ilya Lesokhin <ilyal@mellanox.com> > > Cc: Aviad Yehezkel <aviadye@mellanox.com> > > --- > > include/uapi/linux/tls.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h > > index cc1d21db35d8..d87c698623f2 100644 > > --- a/include/uapi/linux/tls.h > > +++ b/include/uapi/linux/tls.h > > @@ -37,7 +37,9 @@ > > #include <asm/byteorder.h> > > #include <linux/socket.h> > > #include <linux/tcp.h> > > +#ifdef __KERNEL__ > > #include <net/tcp.h> > > +#endif > > Let's move it to include/net/tls.h instead. So everybody ignored this and *new* uapi header was released in a totally unusable form along with v4.13.
On Mon, Sep 04, 2017 at 07:15:11PM +0300, Dmitry V. Levin wrote: > On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote: > > On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote: > > > It is not needed and not part of uapi headers, but causes > > > user space compilation error: > > > > > > fatal error: net/tcp.h: No such file or directory > > > #include <net/tcp.h> > > > ^ > > > > > > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> > > > Cc: Dave Watson <davejwatson@fb.com> > > > Cc: Ilya Lesokhin <ilyal@mellanox.com> > > > Cc: Aviad Yehezkel <aviadye@mellanox.com> > > > --- > > > include/uapi/linux/tls.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h > > > index cc1d21db35d8..d87c698623f2 100644 > > > --- a/include/uapi/linux/tls.h > > > +++ b/include/uapi/linux/tls.h > > > @@ -37,7 +37,9 @@ > > > #include <asm/byteorder.h> > > > #include <linux/socket.h> > > > #include <linux/tcp.h> > > > +#ifdef __KERNEL__ > > > #include <net/tcp.h> > > > +#endif > > > > Let's move it to include/net/tls.h instead. > > So everybody ignored this and *new* uapi header was released > in a totally unusable form along with v4.13. Should issues like these be filed into bugzilla instead? Maybe emails are easier to ignore than bugzilla tickets. -Mikko
diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h index cc1d21db35d8..d87c698623f2 100644 --- a/include/uapi/linux/tls.h +++ b/include/uapi/linux/tls.h @@ -37,7 +37,9 @@ #include <asm/byteorder.h> #include <linux/socket.h> #include <linux/tcp.h> +#ifdef __KERNEL__ #include <net/tcp.h> +#endif /* TLS socket options */ #define TLS_TX 1 /* Set transmit parameters */
It is not needed and not part of uapi headers, but causes user space compilation error: fatal error: net/tcp.h: No such file or directory #include <net/tcp.h> ^ Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> Cc: Dave Watson <davejwatson@fb.com> Cc: Ilya Lesokhin <ilyal@mellanox.com> Cc: Aviad Yehezkel <aviadye@mellanox.com> --- include/uapi/linux/tls.h | 2 ++ 1 file changed, 2 insertions(+)