[LEDE-DEV] kernel: try to remove TCP_RENO from the kernel.

Message ID 20170806011546.14591-1-rosenp@gmail.com
State Rejected
Headers show

Commit Message

Rosen Penev Aug. 6, 2017, 1:15 a.m.
LEDE currently uses CUBIC and not RENO by default. In theory, this
change should remove RENO from the kernel, but it doesn't. Might
as well keep it like this in case something changes.

Signed-off by: Rosen Penev <rosenp@gmail.com>
---
 target/linux/generic/config-3.18 | 2 +-
 target/linux/generic/config-4.4  | 2 +-
 target/linux/generic/config-4.9  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Baptiste Jonglez Aug. 8, 2017, 3:54 p.m. | #1
Hi,

On Sat, Aug 05, 2017 at 06:15:46PM -0700, Rosen Penev wrote:
> LEDE currently uses CUBIC and not RENO by default. In theory, this
> change should remove RENO from the kernel, but it doesn't. Might
> as well keep it like this in case something changes.

As far as I can tell, Reno is hard-wired in the kernel TCP implementation.
So, it's just not possible to disable support for it.  I doubt it would
significantly reduce the size of the kernel anyway.

Baptiste

> Signed-off by: Rosen Penev <rosenp@gmail.com>
> ---
>  target/linux/generic/config-3.18 | 2 +-
>  target/linux/generic/config-4.4  | 2 +-
>  target/linux/generic/config-4.9  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/linux/generic/config-3.18 b/target/linux/generic/config-3.18
> index 1e3f0b5abe..de479a79a8 100644
> --- a/target/linux/generic/config-3.18
> +++ b/target/linux/generic/config-3.18
> @@ -867,7 +867,6 @@ CONFIG_DEFAULT_MMAP_MIN_ADDR=4096
>  # CONFIG_DEFAULT_RENO is not set
>  CONFIG_DEFAULT_SECURITY=""
>  CONFIG_DEFAULT_SECURITY_DAC=y
> -CONFIG_DEFAULT_TCP_CONG="cubic"
>  CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
>  # CONFIG_DELL_SMO8800 is not set
>  # CONFIG_DEPRECATED_PARAM_STRUCT is not set
> @@ -3904,6 +3903,7 @@ CONFIG_TCP_CONG_CUBIC=y
>  # CONFIG_TCP_CONG_HYBLA is not set
>  # CONFIG_TCP_CONG_ILLINOIS is not set
>  # CONFIG_TCP_CONG_LP is not set
> +# CONFIG_TCP_RENO is not set
>  # CONFIG_TCP_CONG_SCALABLE is not set
>  # CONFIG_TCP_CONG_VEGAS is not set
>  # CONFIG_TCP_CONG_VENO is not set
> diff --git a/target/linux/generic/config-4.4 b/target/linux/generic/config-4.4
> index 1c0af9597f..1c13b89912 100644
> --- a/target/linux/generic/config-4.4
> +++ b/target/linux/generic/config-4.4
> @@ -911,7 +911,6 @@ CONFIG_DEFAULT_MMAP_MIN_ADDR=4096
>  # CONFIG_DEFAULT_RENO is not set
>  CONFIG_DEFAULT_SECURITY=""
>  CONFIG_DEFAULT_SECURITY_DAC=y
> -CONFIG_DEFAULT_TCP_CONG="cubic"
>  CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
>  # CONFIG_DELL_RBTN is not set
>  # CONFIG_DELL_SMO8800 is not set
> @@ -4112,6 +4111,7 @@ CONFIG_TCP_CONG_CUBIC=y
>  # CONFIG_TCP_CONG_HYBLA is not set
>  # CONFIG_TCP_CONG_ILLINOIS is not set
>  # CONFIG_TCP_CONG_LP is not set
> +# CONFIG_TCP_RENO is not set
>  # CONFIG_TCP_CONG_SCALABLE is not set
>  # CONFIG_TCP_CONG_VEGAS is not set
>  # CONFIG_TCP_CONG_VENO is not set
> diff --git a/target/linux/generic/config-4.9 b/target/linux/generic/config-4.9
> index 24bbbc0587..06e2c4da4b 100644
> --- a/target/linux/generic/config-4.9
> +++ b/target/linux/generic/config-4.9
> @@ -1008,7 +1008,6 @@ CONFIG_DEFAULT_MMAP_MIN_ADDR=4096
>  # CONFIG_DEFAULT_RENO is not set
>  CONFIG_DEFAULT_SECURITY=""
>  CONFIG_DEFAULT_SECURITY_DAC=y
> -CONFIG_DEFAULT_TCP_CONG="cubic"
>  CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
>  # CONFIG_DELL_RBTN is not set
>  # CONFIG_DELL_SMO8800 is not set
> @@ -4488,6 +4487,7 @@ CONFIG_TCP_CONG_CUBIC=y
>  # CONFIG_TCP_CONG_ILLINOIS is not set
>  # CONFIG_TCP_CONG_LP is not set
>  # CONFIG_TCP_CONG_NV is not set
> +# CONFIG_TCP_CONG_RENO is not set
>  # CONFIG_TCP_CONG_SCALABLE is not set
>  # CONFIG_TCP_CONG_VEGAS is not set
>  # CONFIG_TCP_CONG_VENO is not set

Patch

diff --git a/target/linux/generic/config-3.18 b/target/linux/generic/config-3.18
index 1e3f0b5abe..de479a79a8 100644
--- a/target/linux/generic/config-3.18
+++ b/target/linux/generic/config-3.18
@@ -867,7 +867,6 @@  CONFIG_DEFAULT_MMAP_MIN_ADDR=4096
 # CONFIG_DEFAULT_RENO is not set
 CONFIG_DEFAULT_SECURITY=""
 CONFIG_DEFAULT_SECURITY_DAC=y
-CONFIG_DEFAULT_TCP_CONG="cubic"
 CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
 # CONFIG_DELL_SMO8800 is not set
 # CONFIG_DEPRECATED_PARAM_STRUCT is not set
@@ -3904,6 +3903,7 @@  CONFIG_TCP_CONG_CUBIC=y
 # CONFIG_TCP_CONG_HYBLA is not set
 # CONFIG_TCP_CONG_ILLINOIS is not set
 # CONFIG_TCP_CONG_LP is not set
+# CONFIG_TCP_RENO is not set
 # CONFIG_TCP_CONG_SCALABLE is not set
 # CONFIG_TCP_CONG_VEGAS is not set
 # CONFIG_TCP_CONG_VENO is not set
diff --git a/target/linux/generic/config-4.4 b/target/linux/generic/config-4.4
index 1c0af9597f..1c13b89912 100644
--- a/target/linux/generic/config-4.4
+++ b/target/linux/generic/config-4.4
@@ -911,7 +911,6 @@  CONFIG_DEFAULT_MMAP_MIN_ADDR=4096
 # CONFIG_DEFAULT_RENO is not set
 CONFIG_DEFAULT_SECURITY=""
 CONFIG_DEFAULT_SECURITY_DAC=y
-CONFIG_DEFAULT_TCP_CONG="cubic"
 CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
 # CONFIG_DELL_RBTN is not set
 # CONFIG_DELL_SMO8800 is not set
@@ -4112,6 +4111,7 @@  CONFIG_TCP_CONG_CUBIC=y
 # CONFIG_TCP_CONG_HYBLA is not set
 # CONFIG_TCP_CONG_ILLINOIS is not set
 # CONFIG_TCP_CONG_LP is not set
+# CONFIG_TCP_RENO is not set
 # CONFIG_TCP_CONG_SCALABLE is not set
 # CONFIG_TCP_CONG_VEGAS is not set
 # CONFIG_TCP_CONG_VENO is not set
diff --git a/target/linux/generic/config-4.9 b/target/linux/generic/config-4.9
index 24bbbc0587..06e2c4da4b 100644
--- a/target/linux/generic/config-4.9
+++ b/target/linux/generic/config-4.9
@@ -1008,7 +1008,6 @@  CONFIG_DEFAULT_MMAP_MIN_ADDR=4096
 # CONFIG_DEFAULT_RENO is not set
 CONFIG_DEFAULT_SECURITY=""
 CONFIG_DEFAULT_SECURITY_DAC=y
-CONFIG_DEFAULT_TCP_CONG="cubic"
 CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
 # CONFIG_DELL_RBTN is not set
 # CONFIG_DELL_SMO8800 is not set
@@ -4488,6 +4487,7 @@  CONFIG_TCP_CONG_CUBIC=y
 # CONFIG_TCP_CONG_ILLINOIS is not set
 # CONFIG_TCP_CONG_LP is not set
 # CONFIG_TCP_CONG_NV is not set
+# CONFIG_TCP_CONG_RENO is not set
 # CONFIG_TCP_CONG_SCALABLE is not set
 # CONFIG_TCP_CONG_VEGAS is not set
 # CONFIG_TCP_CONG_VENO is not set