From patchwork Sat Aug 5 16:19:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Sahu X-Patchwork-Id: 798240 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WKiE2tzi"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="VVjro6nx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="RdrX5fhQ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xPpvH2382z9sRq for ; Sun, 6 Aug 2017 02:21:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=kixgmj4i40AxQ30uYtqR/Xoo9ag0BOxf0v4zjprkR3w=; b=WKiE2tziC2OIobuR+xAetdk9oB TvK0IjtGHNSPjQfxXtheds72xytKCF0fFcZkzneI75ydzNBkMyt8WUlhgzbLNHy6XlcZuplSgZ6KX RGKEAksEdoU3JpEEHyUHj4rOgLrYd9xlsrlfD8YgudhYFLsZExi7Y8D+HyrxB8uAjxN0TOWoZ7DLV psLmpqo4he3GaRInIi5dQOz8u4acoqId9Lfc+iH9rFv4vth1YK8lw1yy25dlP+ZW07pemFScAx20o cUhO/8hUin7cwdR8ZmTBEIYH3R7iYtdb0bIR046pVtik2V+P1YICK9u05KNoOkh0cxca788YHJ0jm X6Ceav1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1de1p3-0005g5-3w; Sat, 05 Aug 2017 16:21:05 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1de1op-0005Kf-11 for linux-mtd@lists.infradead.org; Sat, 05 Aug 2017 16:20:54 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CD4D06025C; Sat, 5 Aug 2017 16:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501950030; bh=rWQLLul37d6/WysuXV6o+aqi+KTPKaEZycpZe6Zexnk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VVjro6nxeS0z79oy0WEdPiRcV0020TFwUZ/WDVN7WQiLFfC6l0n0TqSi1sD+ZEaQk KEQsytFohJI0muOtEDzSWtXYNg1Kp/8v31GgkxV1Z+x3Nso7ShPq0ABEdoBhOwLPSL 1PF1FlOC98RJDmzdCV8mPJaFHYB7p9woMR7K6OVw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: absahu@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3333660251; Sat, 5 Aug 2017 16:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501950029; bh=rWQLLul37d6/WysuXV6o+aqi+KTPKaEZycpZe6Zexnk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RdrX5fhQ8tHqYO06zrg7XOsdY7THQQSAmxEJhCezlFeYuI3oJ8VdyZ2EOAnOr5Blk lY20IihctUrDw4VHjYwJ3IYdVHEex7cnJOM/GkiWobAeeMFxdWDtipNgAR+k+z+KtU BCURaOOHZOGCt8f5vGQzQwIj2ack7eZN0XQpHL5s= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3333660251 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=absahu@codeaurora.org From: Abhishek Sahu To: dwmw2@infradead.org, boris.brezillon@free-electrons.com, computersforpeace@gmail.com, marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Subject: [PATCH v3 01/20] mtd: nand: qcom: program NAND_DEV_CMD_VLD register Date: Sat, 5 Aug 2017 21:49:39 +0530 Message-Id: <1501949998-29859-2-git-send-email-absahu@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1501949998-29859-1-git-send-email-absahu@codeaurora.org> References: <1501949998-29859-1-git-send-email-absahu@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170805_092051_424403_3C4FF970 X-CRM114-Status: GOOD ( 12.80 ) X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-4.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [198.145.29.96 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, architt@codeaurora.org, richard@nod.at, cyrille.pitchen@wedev4u.fr, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abhishek Sahu , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, sricharan@codeaurora.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The NAND page read fails without complete boot chain since NAND_DEV_CMD_VLD value is not proper. The default power on reset value for this register is 0xe - ERASE_START_VALID | WRITE_START_VALID | READ_STOP_VALID The READ_START_VALID should be enabled for sending PAGE_READ command. READ_STOP_VALID should be cleared since normal NAND page read does not require READ_STOP command. Fixes: c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver") Cc: stable@vger.kernel.org Reviewed-by: Archit Taneja Signed-off-by: Abhishek Sahu --- drivers/mtd/nand/qcom_nandc.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c index 0289f09..7406019 100644 --- a/drivers/mtd/nand/qcom_nandc.c +++ b/drivers/mtd/nand/qcom_nandc.c @@ -110,6 +110,10 @@ /* NAND_DEV_CMD_VLD bits */ #define READ_START_VLD 0 +#define READ_STOP_VALID 1 +#define WRITE_START_VALID 2 +#define ERASE_START_VALID 3 +#define SEQ_READ_START_VLD 4 /* NAND_EBI2_ECC_BUF_CFG bits */ #define NUM_STEPS 0 @@ -148,6 +152,12 @@ #define FETCH_ID 0xb #define RESET_DEVICE 0xd +/* Default Value for NAND_DEV_CMD_VLD */ +#define NAND_DEV_CMD_VLD_VAL (BIT(READ_START_VLD) | \ + BIT(WRITE_START_VALID) | \ + BIT(ERASE_START_VALID) | \ + BIT(SEQ_READ_START_VLD)) + /* * the NAND controller performs reads/writes with ECC in 516 byte chunks. * the driver calls the chunks 'step' or 'codeword' interchangeably @@ -1995,13 +2005,14 @@ static int qcom_nandc_setup(struct qcom_nand_controller *nandc) { /* kill onenand */ nandc_write(nandc, SFLASHC_BURST_CFG, 0); + nandc_write(nandc, NAND_DEV_CMD_VLD, NAND_DEV_CMD_VLD_VAL); /* enable ADM DMA */ nandc_write(nandc, NAND_FLASH_CHIP_SELECT, DM_EN); /* save the original values of these registers */ nandc->cmd1 = nandc_read(nandc, NAND_DEV_CMD1); - nandc->vld = nandc_read(nandc, NAND_DEV_CMD_VLD); + nandc->vld = NAND_DEV_CMD_VLD_VAL; return 0; }