diff mbox

[U-Boot,v2,37/42] Convert CONFIG_CMD_UNIVERSE to Kconfig

Message ID 20170804223506.105306-38-sjg@chromium.org
State Accepted
Commit 2a242e3e8074ba929f8aa5e871e4ea2bd9d483c7
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass Aug. 4, 2017, 10:35 p.m. UTC
This converts the following to Kconfig:
   CONFIG_CMD_UNIVERSE

Since no board uses this, perhaps we should drop this command?

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2:
- Add a note about dropping CMD_UNIVERSE
- Sort Kconfig options in alphabetical order

 cmd/Kconfig                  | 6 ++++++
 include/config_cmd_all.h     | 1 -
 scripts/config_whitelist.txt | 1 -
 3 files changed, 6 insertions(+), 2 deletions(-)

Comments

Philipp Tomsich Aug. 5, 2017, 9:54 a.m. UTC | #1
> This converts the following to Kconfig:
>    CONFIG_CMD_UNIVERSE
> 
> Since no board uses this, perhaps we should drop this command?
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
> Changes in v2:
> - Add a note about dropping CMD_UNIVERSE
> - Sort Kconfig options in alphabetical order
> 
>  cmd/Kconfig                  | 6 ++++++
>  include/config_cmd_all.h     | 1 -
>  scripts/config_whitelist.txt | 1 -
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Tom Rini Aug. 12, 2017, 1:15 p.m. UTC | #2
On Fri, Aug 04, 2017 at 04:35:01PM -0600, Simon Glass wrote:

> This converts the following to Kconfig:
>    CONFIG_CMD_UNIVERSE
> 
> Since no board uses this, perhaps we should drop this command?
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Applied to u-boot/master, thanks!
Tom Rini Aug. 12, 2017, 1:15 p.m. UTC | #3
On Fri, Aug 04, 2017 at 04:35:01PM -0600, Simon Glass wrote:

> This converts the following to Kconfig:
>    CONFIG_CMD_UNIVERSE
> 
> Since no board uses this, perhaps we should drop this command?
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 7934753232..4524370d23 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -854,6 +854,12 @@  config CMD_TSI148
 	  This provides various sub-commands to initialise and configure the
 	  Turndra tsi148 device. See the command help for full details.
 
+config CMD_UNIVERSE
+	bool "universe - Command to set up the Turndra Universe controller"
+	help
+	  This allows setting up the VMEbus provided by this controller.
+	  See the command help for full details.
+
 config CMD_USB
 	bool "usb"
 	help
diff --git a/include/config_cmd_all.h b/include/config_cmd_all.h
index f93d5508bb..faddca88cd 100644
--- a/include/config_cmd_all.h
+++ b/include/config_cmd_all.h
@@ -13,7 +13,6 @@ 
  * Alphabetical list of all possible commands.
  */
 
-#define CONFIG_CMD_UNIVERSE	/* Tundra Universe Support	*/
 #define CONFIG_CMD_ZFS		/* ZFS Support			*/
 
 #endif	/* _CONFIG_CMD_ALL_H */
diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
index 42eb367aa3..31aee890d7 100644
--- a/scripts/config_whitelist.txt
+++ b/scripts/config_whitelist.txt
@@ -296,7 +296,6 @@  CONFIG_CM922T_XA10
 CONFIG_CMDLINE_EDITING
 CONFIG_CMDLINE_PS_SUPPORT
 CONFIG_CMDLINE_TAG
-CONFIG_CMD_UNIVERSE
 CONFIG_CMD_UUID
 CONFIG_CMD_ZBOOT
 CONFIG_CMD_ZFS