| Message ID | 1295587088.2613.51.camel@edumazet-laptop |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 1/20/2011 9:18 PM, Eric Dumazet wrote: > Le mercredi 19 janvier 2011 à 23:41 -0800, David Miller a écrit : >> From: John Fastabend <john.r.fastabend@intel.com> >> Date: Mon, 17 Jan 2011 10:06:04 -0800 >> >>> This patch provides a mechanism for lower layer devices to >>> steer traffic using skb->priority to tx queues. >> ... >>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com> >> >> Applied. > > Hi John > > Should netif_setup_tc() be static, or is it meant to be exported > somehow ? > > [PATCH net-next-2.6] net: netif_setup_tc() is static > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > --- Acked-by: John Fastabend <john.r.fastabend@intel.com> Yes this should be static. Thanks Eric! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: John Fastabend <john.r.fastabend@intel.com> Date: Fri, 21 Jan 2011 09:54:53 -0800 > On 1/20/2011 9:18 PM, Eric Dumazet wrote: >> Le mercredi 19 janvier 2011 à 23:41 -0800, David Miller a écrit : >>> From: John Fastabend <john.r.fastabend@intel.com> >>> Date: Mon, 17 Jan 2011 10:06:04 -0800 >>> >>>> This patch provides a mechanism for lower layer devices to >>>> steer traffic using skb->priority to tx queues. >>> ... >>>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com> >>> >>> Applied. >> >> Hi John >> >> Should netif_setup_tc() be static, or is it meant to be exported >> somehow ? >> >> [PATCH net-next-2.6] net: netif_setup_tc() is static >> >> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> >> --- > > Acked-by: John Fastabend <john.r.fastabend@intel.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index 2730352..47d3d78 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1605,7 +1605,7 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev) * expected that drivers will fix this mapping if they can before * calling netif_set_real_num_tx_queues. */ -void netif_setup_tc(struct net_device *dev, unsigned int txq) +static void netif_setup_tc(struct net_device *dev, unsigned int txq) { int i; struct netdev_tc_txq *tc = &dev->tc_to_txq[0];