diff mbox

[U-Boot,v3,3/9] fit: fixed bug in locate_dtb_in_fit()

Message ID 1501866064-7853-4-git-send-email-jjhiblot@ti.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Jean-Jacques Hiblot Aug. 4, 2017, 5 p.m. UTC 
If the dtb is the first data of the FIT, the its offset is 0x0. Change the
test to '<' instead of '<='

Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
---

no change since v2

 common/boot_fit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Aug. 6, 2017, 5:16 a.m. UTC | #1 
On 4 August 2017 at 11:00, Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
> If the dtb is the first data of the FIT, the its offset is 0x0. Change the
> test to '<' instead of '<='
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> ---
>
> no change since v2
>
>  common/boot_fit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/common/boot_fit.c b/common/boot_fit.c
index 3767c63..8e81745 100644
--- a/common/boot_fit.c
+++ b/common/boot_fit.c
@@ -73,7 +73,7 @@  void *locate_dtb_in_fit(const void *fit)
 
 	ret = fdt_offset(fit);
 
-	if (ret <= 0)
+	if (ret < 0)
 		return NULL;
 	else
 		return (void *)fit+size+ret;