| Message ID | 20170804151440.320927-9-vsementsov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Rename nbd_recv_coroutines_enter_all to nbd_recv_coroutines_wake_all, > as it most probably just add all recv coroutines into co_queue_wakeup, > not directly enter them. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > block/nbd-client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/block/nbd-client.c b/block/nbd-client.c > index c9ade9b517..8ad2264a40 100644 > --- a/block/nbd-client.c > +++ b/block/nbd-client.c > @@ -34,7 +34,7 @@ > #define HANDLE_TO_INDEX(bs, handle) ((handle) ^ ((uint64_t)(intptr_t)bs)) > #define INDEX_TO_HANDLE(bs, index) ((index) ^ ((uint64_t)(intptr_t)bs)) > > -static void nbd_recv_coroutines_enter_all(NBDClientSession *s) > +static void nbd_recv_coroutines_wake_all(NBDClientSession *s) > { > int i; > > @@ -108,7 +108,7 @@ static coroutine_fn void nbd_read_reply_entry(void *opaque) > } > > s->reply.handle = 0; > - nbd_recv_coroutines_enter_all(s); > + nbd_recv_coroutines_wake_all(s); > s->read_reply_co = NULL; > } > >
On 08/25/2017 01:43 PM, Eric Blake wrote: > On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: >> Rename nbd_recv_coroutines_enter_all to nbd_recv_coroutines_wake_all, >> as it most probably just add all recv coroutines into co_queue_wakeup, s/adds/ >> not directly enter them. s/not/rather than/ >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >> --- >> block/nbd-client.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Eric Blake <eblake@redhat.com> >
diff --git a/block/nbd-client.c b/block/nbd-client.c index c9ade9b517..8ad2264a40 100644 --- a/block/nbd-client.c +++ b/block/nbd-client.c @@ -34,7 +34,7 @@ #define HANDLE_TO_INDEX(bs, handle) ((handle) ^ ((uint64_t)(intptr_t)bs)) #define INDEX_TO_HANDLE(bs, index) ((index) ^ ((uint64_t)(intptr_t)bs)) -static void nbd_recv_coroutines_enter_all(NBDClientSession *s) +static void nbd_recv_coroutines_wake_all(NBDClientSession *s) { int i; @@ -108,7 +108,7 @@ static coroutine_fn void nbd_read_reply_entry(void *opaque) } s->reply.handle = 0; - nbd_recv_coroutines_enter_all(s); + nbd_recv_coroutines_wake_all(s); s->read_reply_co = NULL; }
Rename nbd_recv_coroutines_enter_all to nbd_recv_coroutines_wake_all, as it most probably just add all recv coroutines into co_queue_wakeup, not directly enter them. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- block/nbd-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)