[v3,resend] Documentation: dt-bindings: aspeed-pwm-tacho cooling device.

Submitted by Mykola Kostenok on Aug. 3, 2017, 8:46 a.m.

Details

Message ID 20170803084650.22298-1-c_mykolak@mellanox.com
State Accepted, archived
Headers show

Commit Message

Mykola Kostenok Aug. 3, 2017, 8:46 a.m.
It's add support for cooling device creation to
aspeed-pwm-tacho.
Cooling device could be bound to a thermal zone
for the thermal control.

v1 -> v2:
 - Fix commit message.
v2 -> v3:
 Pointed out by Rob Herring:
 - Put cooling-levels under fan subnodes.

Signed-off-by: Mykola Kostenok <c_mykolak@mellanox.com>
---
 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Guenter Roeck Aug. 9, 2017, 4:08 a.m.
On 08/03/2017 01:46 AM, Mykola Kostenok wrote:
> It's add support for cooling device creation to
> aspeed-pwm-tacho.
> Cooling device could be bound to a thermal zone
> for the thermal control.
> 
> v1 -> v2:
>   - Fix commit message.
> v2 -> v3:
>   Pointed out by Rob Herring:
>   - Put cooling-levels under fan subnodes.
> 
> Signed-off-by: Mykola Kostenok <c_mykolak@mellanox.com>

Did Rob ever Ack this patch ?

Note you didn't copy the hwmon mailing list, which doesn't exactly help
to keep track of it, and I may have lost Rob's Ack. My apologies if that
is the case.

Guenter

> ---
>   Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
> index cf44605..367c820 100644
> --- a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
> +++ b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
> @@ -11,6 +11,8 @@ Required properties for pwm-tacho node:
>   
>   - #size-cells : should be 1.
>   
> +- #cooling-cells: should be 2.
> +
>   - reg : address and length of the register set for the device.
>   
>   - pinctrl-names : a pinctrl state named "default" must be defined.
> @@ -28,12 +30,17 @@ fan subnode format:
>   Under fan subnode there can upto 8 child nodes, with each child node
>   representing a fan. If there are 8 fans each fan can have one PWM port and
>   one/two Fan tach inputs.
> +For PWM port can be configured cooling-levels to create cooling device.
> +Cooling device could be bound to a thermal zone for the thermal control.
>   
>   Required properties for each child node:
>   - reg : should specify PWM source port.
>   	integer value in the range 0 to 7 with 0 indicating PWM port A and
>   	7 indicating PWM port H.
>   
> +- cooling-levels: PWM duty cycle values in a range from 0 to 255
> +                  which correspond to thermal cooling states.
> +
>   - aspeed,fan-tach-ch : should specify the Fan tach input channel.
>                   integer value in the range 0 through 15, with 0 indicating
>   		Fan tach channel 0 and 15 indicating Fan tach channel 15.
> @@ -50,6 +57,7 @@ pwm_tacho_fixed_clk: fixedclk {
>   pwm_tacho: pwmtachocontroller@1e786000 {
>   	#address-cells = <1>;
>   	#size-cells = <1>;
> +	#cooling-cells = <2>;
>   	reg = <0x1E786000 0x1000>;
>   	compatible = "aspeed,ast2500-pwm-tacho";
>   	clocks = <&pwm_tacho_fixed_clk>;
> @@ -58,6 +66,7 @@ pwm_tacho: pwmtachocontroller@1e786000 {
>   
>   	fan@0 {
>   		reg = <0x00>;
> +		cooling-levels = /bits/ 8 <125 151 177 203 229 255>;
>   		aspeed,fan-tach-ch = /bits/ 8 <0x00>;
>   	};
>   
>
Mykola Kostenok Aug. 9, 2017, 7:15 a.m.
> -----Original Message-----

> From: Guenter Roeck [mailto:linux@roeck-us.net]

> Sent: Wednesday, August 9, 2017 7:09 AM

> To: Mykola Kostenok <c_mykolak@mellanox.com>; Rob Herring

> <robh+dt@kernel.org>; devicetree@vger.kernel.org

> Cc: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>;

> openbmc@lists.ozlabs.org; Patrick Venture <venture@google.com>; Vadim

> Pasternak <vadimp@mellanox.com>; Ohad Oz <ohado@mellanox.com>

> Subject: Re: [patch v3 resend] Documentation: dt-bindings: aspeed-pwm-

> tacho cooling device.

> 

> On 08/03/2017 01:46 AM, Mykola Kostenok wrote:

> > It's add support for cooling device creation to aspeed-pwm-tacho.

> > Cooling device could be bound to a thermal zone for the thermal

> > control.

> >

> > v1 -> v2:

> >   - Fix commit message.

> > v2 -> v3:

> >   Pointed out by Rob Herring:

> >   - Put cooling-levels under fan subnodes.

> >

> > Signed-off-by: Mykola Kostenok <c_mykolak@mellanox.com>

> 

> Did Rob ever Ack this patch ?

> 

> Note you didn't copy the hwmon mailing list, which doesn't exactly help to

> keep track of it, and I may have lost Rob's Ack. My apologies if that is the

> case.

> 

> Guenter


Hi, Guenter. 

No, Rob Herring did not ack patch yet. Just comment.

Yes, since I split initial patch to 2 patches, I have sent one to you and hwmon mail list,
and another to Rob and devicetree mail list. And added you both to cc.
Am I need to add both mail lists to both patches in such cases?

Best regards, Mykola Kostenok.
Guenter Roeck Aug. 9, 2017, 1:30 p.m.
On 08/09/2017 12:15 AM, Mykola Kostenok wrote:
>> -----Original Message-----
>> From: Guenter Roeck [mailto:linux@roeck-us.net]
>> Sent: Wednesday, August 9, 2017 7:09 AM
>> To: Mykola Kostenok <c_mykolak@mellanox.com>; Rob Herring
>> <robh+dt@kernel.org>; devicetree@vger.kernel.org
>> Cc: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>;
>> openbmc@lists.ozlabs.org; Patrick Venture <venture@google.com>; Vadim
>> Pasternak <vadimp@mellanox.com>; Ohad Oz <ohado@mellanox.com>
>> Subject: Re: [patch v3 resend] Documentation: dt-bindings: aspeed-pwm-
>> tacho cooling device.
>>
>> On 08/03/2017 01:46 AM, Mykola Kostenok wrote:
>>> It's add support for cooling device creation to aspeed-pwm-tacho.
>>> Cooling device could be bound to a thermal zone for the thermal
>>> control.
>>>
>>> v1 -> v2:
>>>    - Fix commit message.
>>> v2 -> v3:
>>>    Pointed out by Rob Herring:
>>>    - Put cooling-levels under fan subnodes.
>>>
>>> Signed-off-by: Mykola Kostenok <c_mykolak@mellanox.com>
>>
>> Did Rob ever Ack this patch ?
>>
>> Note you didn't copy the hwmon mailing list, which doesn't exactly help to
>> keep track of it, and I may have lost Rob's Ack. My apologies if that is the
>> case.
>>
>> Guenter
> 
> Hi, Guenter.
> 
> No, Rob Herring did not ack patch yet. Just comment.
> 
> Yes, since I split initial patch to 2 patches, I have sent one to you and hwmon mail list,
> and another to Rob and devicetree mail list. And added you both to cc.
> Am I need to add both mail lists to both patches in such cases?
> 

Normally the dt patch would still be pushed through the same subsystem as the driver,
so, yes, it would be useful to have hwmon copied. Otherwise it won't be in the hwmon
patchwork and can easily get lost.

Guenter
Rob Herring Aug. 10, 2017, 5:11 p.m.
On Thu, Aug 03, 2017 at 11:46:50AM +0300, Mykola Kostenok wrote:
> It's add support for cooling device creation to
> aspeed-pwm-tacho.
> Cooling device could be bound to a thermal zone
> for the thermal control.
> 
> v1 -> v2:
>  - Fix commit message.
> v2 -> v3:
>  Pointed out by Rob Herring:
>  - Put cooling-levels under fan subnodes.
> 
> Signed-off-by: Mykola Kostenok <c_mykolak@mellanox.com>
> ---
>  Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>
Guenter Roeck Aug. 13, 2017, 1:47 p.m.
On Thu, Aug 03, 2017 at 11:46:50AM +0300, Mykola Kostenok wrote:
> It's add support for cooling device creation to
> aspeed-pwm-tacho.
> Cooling device could be bound to a thermal zone
> for the thermal control.
> 
> v1 -> v2:
>  - Fix commit message.
> v2 -> v3:
>  Pointed out by Rob Herring:
>  - Put cooling-levels under fan subnodes.
> 
> Signed-off-by: Mykola Kostenok <c_mykolak@mellanox.com>
> Acked-by: Rob Herring <robh@kernel.org>

Applied to hwmon-next (removed version information from description)

Thanks,
Guenter

> ---
>  Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
> index cf44605..367c820 100644
> --- a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
> +++ b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
> @@ -11,6 +11,8 @@ Required properties for pwm-tacho node:
>  
>  - #size-cells : should be 1.
>  
> +- #cooling-cells: should be 2.
> +
>  - reg : address and length of the register set for the device.
>  
>  - pinctrl-names : a pinctrl state named "default" must be defined.
> @@ -28,12 +30,17 @@ fan subnode format:
>  Under fan subnode there can upto 8 child nodes, with each child node
>  representing a fan. If there are 8 fans each fan can have one PWM port and
>  one/two Fan tach inputs.
> +For PWM port can be configured cooling-levels to create cooling device.
> +Cooling device could be bound to a thermal zone for the thermal control.
>  
>  Required properties for each child node:
>  - reg : should specify PWM source port.
>  	integer value in the range 0 to 7 with 0 indicating PWM port A and
>  	7 indicating PWM port H.
>  
> +- cooling-levels: PWM duty cycle values in a range from 0 to 255
> +                  which correspond to thermal cooling states.
> +
>  - aspeed,fan-tach-ch : should specify the Fan tach input channel.
>                  integer value in the range 0 through 15, with 0 indicating
>  		Fan tach channel 0 and 15 indicating Fan tach channel 15.
> @@ -50,6 +57,7 @@ pwm_tacho_fixed_clk: fixedclk {
>  pwm_tacho: pwmtachocontroller@1e786000 {
>  	#address-cells = <1>;
>  	#size-cells = <1>;
> +	#cooling-cells = <2>;
>  	reg = <0x1E786000 0x1000>;
>  	compatible = "aspeed,ast2500-pwm-tacho";
>  	clocks = <&pwm_tacho_fixed_clk>;
> @@ -58,6 +66,7 @@ pwm_tacho: pwmtachocontroller@1e786000 {
>  
>  	fan@0 {
>  		reg = <0x00>;
> +		cooling-levels = /bits/ 8 <125 151 177 203 229 255>;
>  		aspeed,fan-tach-ch = /bits/ 8 <0x00>;
>  	};
>

Patch hide | download patch | download mbox

diff --git a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
index cf44605..367c820 100644
--- a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
+++ b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
@@ -11,6 +11,8 @@  Required properties for pwm-tacho node:
 
 - #size-cells : should be 1.
 
+- #cooling-cells: should be 2.
+
 - reg : address and length of the register set for the device.
 
 - pinctrl-names : a pinctrl state named "default" must be defined.
@@ -28,12 +30,17 @@  fan subnode format:
 Under fan subnode there can upto 8 child nodes, with each child node
 representing a fan. If there are 8 fans each fan can have one PWM port and
 one/two Fan tach inputs.
+For PWM port can be configured cooling-levels to create cooling device.
+Cooling device could be bound to a thermal zone for the thermal control.
 
 Required properties for each child node:
 - reg : should specify PWM source port.
 	integer value in the range 0 to 7 with 0 indicating PWM port A and
 	7 indicating PWM port H.
 
+- cooling-levels: PWM duty cycle values in a range from 0 to 255
+                  which correspond to thermal cooling states.
+
 - aspeed,fan-tach-ch : should specify the Fan tach input channel.
                 integer value in the range 0 through 15, with 0 indicating
 		Fan tach channel 0 and 15 indicating Fan tach channel 15.
@@ -50,6 +57,7 @@  pwm_tacho_fixed_clk: fixedclk {
 pwm_tacho: pwmtachocontroller@1e786000 {
 	#address-cells = <1>;
 	#size-cells = <1>;
+	#cooling-cells = <2>;
 	reg = <0x1E786000 0x1000>;
 	compatible = "aspeed,ast2500-pwm-tacho";
 	clocks = <&pwm_tacho_fixed_clk>;
@@ -58,6 +66,7 @@  pwm_tacho: pwmtachocontroller@1e786000 {
 
 	fan@0 {
 		reg = <0x00>;
+		cooling-levels = /bits/ 8 <125 151 177 203 229 255>;
 		aspeed,fan-tach-ch = /bits/ 8 <0x00>;
 	};