| Message ID | 20170803005150.9286-4-fcooper@ti.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote: > Add information regarding fixed transceiver binding. This is especially > important for MCAN since the IP allows CAN FD mode to run significantly > faster than what most transceivers are capable of. > > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> > --- > Documentation/devicetree/bindings/net/can/m_can.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt > index 9e33177..0b62f47 100644 > --- a/Documentation/devicetree/bindings/net/can/m_can.txt > +++ b/Documentation/devicetree/bindings/net/can/m_can.txt > @@ -43,6 +43,11 @@ Required properties: > Please refer to 2.4.1 Message RAM Configuration in > Bosch M_CAN user manual for details. > > +Optional properties: > +- fixed-transceiver : Fixed-transceiver subnode describing maximum speed Subnode is not a property. > + that can be used for CAN/CAN-FD modes. See > + Documentation/devicetree/bindings/net/can/fixed-transceiver.txt > + for details. > Example: > SoC dtsi: > m_can1: can@020e8000 { > @@ -64,4 +69,8 @@ Board dts: > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_m_can1>; > status = "enabled"; > + > + fixed-transceiver@0 { Same comments here as in previous patch. [...] MBR, Sergei
On 08/03/2017 04:20 AM, Sergei Shtylyov wrote: > On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote: > >> Add information regarding fixed transceiver binding. This is especially >> important for MCAN since the IP allows CAN FD mode to run significantly >> faster than what most transceivers are capable of. >> >> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> >> --- >> Documentation/devicetree/bindings/net/can/m_can.txt | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt >> b/Documentation/devicetree/bindings/net/can/m_can.txt >> index 9e33177..0b62f47 100644 >> --- a/Documentation/devicetree/bindings/net/can/m_can.txt >> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt >> @@ -43,6 +43,11 @@ Required properties: >> Please refer to 2.4.1 Message RAM Configuration in >> Bosch M_CAN user manual for details. >> +Optional properties: >> +- fixed-transceiver : Fixed-transceiver subnode describing maximum >> speed > > Subnode is not a property. Ok makes sense. Several bindings refer to fixed-link as an optional property. I thought there was some kind of weird reasoning to do so which I decided to follow. I'll update it to say "Optional subnode". > >> + that can be used for CAN/CAN-FD modes. See >> + >> Documentation/devicetree/bindings/net/can/fixed-transceiver.txt >> + for details. >> Example: >> SoC dtsi: >> m_can1: can@020e8000 { >> @@ -64,4 +69,8 @@ Board dts: >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_m_can1>; >> status = "enabled"; >> + >> + fixed-transceiver@0 { > > Same comments here as in previous patch. Will fix. > > [...] > > MBR, Sergei
diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt index 9e33177..0b62f47 100644 --- a/Documentation/devicetree/bindings/net/can/m_can.txt +++ b/Documentation/devicetree/bindings/net/can/m_can.txt @@ -43,6 +43,11 @@ Required properties: Please refer to 2.4.1 Message RAM Configuration in Bosch M_CAN user manual for details. +Optional properties: +- fixed-transceiver : Fixed-transceiver subnode describing maximum speed + that can be used for CAN/CAN-FD modes. See + Documentation/devicetree/bindings/net/can/fixed-transceiver.txt + for details. Example: SoC dtsi: m_can1: can@020e8000 { @@ -64,4 +69,8 @@ Board dts: pinctrl-names = "default"; pinctrl-0 = <&pinctrl_m_can1>; status = "enabled"; + + fixed-transceiver@0 { + max-bitrate = <5000000>; + }; };
Add information regarding fixed transceiver binding. This is especially important for MCAN since the IP allows CAN FD mode to run significantly faster than what most transceivers are capable of. Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> --- Documentation/devicetree/bindings/net/can/m_can.txt | 9 +++++++++ 1 file changed, 9 insertions(+)