Message ID | 20170802150932.GA5808@altlinux.org |
---|---|
State | New |
Headers | show |
Hi, Looks like among those few who care about sys/ptrace.h nobody feels experienced enough to review this change, so I'll go forward and commit it. On Wed, Aug 02, 2017 at 06:09:32PM +0300, Dmitry V. Levin wrote: > Remove enum __ptrace_flags along with the only constant it contains, > PTRACE_SEIZE_DEVEL, from Linux's sys/ptrace.h files. > > This flag constant was introduced in Linux by commit v3.1-rc1~308^2~28 > as a part of new experimental PTRACE_SEIZE interface. > Later, as PTRACE_SEIZE had lost its experimental status, > this flag was removed from Linux by commit v3.4-rc1~109^2~20. > > * sysdeps/unix/sysv/linux/sys/ptrace.h (enum __ptrace_flags, > PTRACE_SEIZE_DEVEL): Remove. > * sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h: Likewise. > * sysdeps/unix/sysv/linux/ia64/sys/ptrace.h: Likewise. > * sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h: Likewise. > * sysdeps/unix/sysv/linux/s390/sys/ptrace.h: Likewise. > * sysdeps/unix/sysv/linux/sparc/sys/ptrace.h: Likewise. > --- > ChangeLog | 10 ++++++++++ > NEWS | 3 ++- > sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h | 6 ------ > sysdeps/unix/sysv/linux/ia64/sys/ptrace.h | 6 ------ > sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h | 6 ------ > sysdeps/unix/sysv/linux/s390/sys/ptrace.h | 6 ------ > sysdeps/unix/sysv/linux/sparc/sys/ptrace.h | 6 ------ > sysdeps/unix/sysv/linux/sys/ptrace.h | 6 ------ > 8 files changed, 12 insertions(+), 37 deletions(-) > > diff --git a/NEWS b/NEWS > index 4b7e69a..484c467 100644 > --- a/NEWS > +++ b/NEWS > @@ -13,7 +13,8 @@ Major new features: > > Deprecated and removed features, and other changes affecting compatibility: > > - [Add deprecations, removals and changes affecting compatibility here] > +* On GNU/Linux, the obsolete Linux constant PTRACE_SEIZE_DEVEL is no longer > + defined by <sys/ptrace.h>. > > Changes to build and runtime requirements: > > diff --git a/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h b/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h > index c8ca9e3..479696d 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h > +++ b/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h > @@ -141,12 +141,6 @@ enum __ptrace_request > }; > > > -/* Flag for PTRACE_LISTEN. */ > -enum __ptrace_flags > -{ > - PTRACE_SEIZE_DEVEL = 0x80000000 > -}; > - > /* Options set using PTRACE_SETOPTIONS. */ > enum __ptrace_setoptions > { > diff --git a/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h b/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h > index c77e6dc..681dc89 100644 > --- a/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h > +++ b/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h > @@ -146,12 +146,6 @@ enum __ptrace_request > }; > > > -/* Flag for PTRACE_LISTEN. */ > -enum __ptrace_flags > -{ > - PTRACE_SEIZE_DEVEL = 0x80000000 > -}; > - > /* pt_all_user_regs is used for PTRACE_GETREGS/PTRACE_SETREGS. */ > struct __pt_all_user_regs > { > diff --git a/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h b/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h > index ed1ed63..b2296fa 100644 > --- a/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h > +++ b/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h > @@ -133,12 +133,6 @@ enum __ptrace_request > }; > > > -/* Flag for PTRACE_LISTEN. */ > -enum __ptrace_flags > -{ > - PTRACE_SEIZE_DEVEL = 0x80000000 > -}; > - > /* Options set using PTRACE_SETOPTIONS. */ > enum __ptrace_setoptions > { > diff --git a/sysdeps/unix/sysv/linux/s390/sys/ptrace.h b/sysdeps/unix/sysv/linux/s390/sys/ptrace.h > index e913647..6c7d86b 100644 > --- a/sysdeps/unix/sysv/linux/s390/sys/ptrace.h > +++ b/sysdeps/unix/sysv/linux/s390/sys/ptrace.h > @@ -210,12 +210,6 @@ enum __ptrace_request > }; > > > -/* Flag for PTRACE_LISTEN. */ > -enum __ptrace_flags > -{ > - PTRACE_SEIZE_DEVEL = 0x80000000 > -}; > - > /* Options set using PTRACE_SETOPTIONS. */ > enum __ptrace_setoptions > { > diff --git a/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h b/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h > index f605494..1fda17c 100644 > --- a/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h > +++ b/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h > @@ -215,12 +215,6 @@ enum __ptrace_request > }; > > > -/* Flag for PTRACE_LISTEN. */ > -enum __ptrace_flags > -{ > - PTRACE_SEIZE_DEVEL = 0x80000000 > -}; > - > /* Options set using PTRACE_SETOPTIONS. */ > enum __ptrace_setoptions > { > diff --git a/sysdeps/unix/sysv/linux/sys/ptrace.h b/sysdeps/unix/sysv/linux/sys/ptrace.h > index 1daadd1..6ddd972 100644 > --- a/sysdeps/unix/sysv/linux/sys/ptrace.h > +++ b/sysdeps/unix/sysv/linux/sys/ptrace.h > @@ -163,12 +163,6 @@ enum __ptrace_request > }; > > > -/* Flag for PTRACE_LISTEN. */ > -enum __ptrace_flags > -{ > - PTRACE_SEIZE_DEVEL = 0x80000000 > -}; > - > /* Options set using PTRACE_SETOPTIONS. */ > enum __ptrace_setoptions > { > -- > ldv
On 08/07/2017 11:33 AM, Dmitry V. Levin wrote: > Hi, > > Looks like among those few who care about sys/ptrace.h nobody feels > experienced enough to review this change, so I'll go forward and commit it. Please tread carefully, and give the machine maintainer time to review, or directly TO: the machine maintainers and ask for review. Lack of a response does not mean you can assume consensus. Follow up with machine maintainers, even one ACK from a maintainer goes a long way to knowing there is support for your change.
diff --git a/NEWS b/NEWS index 4b7e69a..484c467 100644 --- a/NEWS +++ b/NEWS @@ -13,7 +13,8 @@ Major new features: Deprecated and removed features, and other changes affecting compatibility: - [Add deprecations, removals and changes affecting compatibility here] +* On GNU/Linux, the obsolete Linux constant PTRACE_SEIZE_DEVEL is no longer + defined by <sys/ptrace.h>. Changes to build and runtime requirements: diff --git a/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h b/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h index c8ca9e3..479696d 100644 --- a/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h +++ b/sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h @@ -141,12 +141,6 @@ enum __ptrace_request }; -/* Flag for PTRACE_LISTEN. */ -enum __ptrace_flags -{ - PTRACE_SEIZE_DEVEL = 0x80000000 -}; - /* Options set using PTRACE_SETOPTIONS. */ enum __ptrace_setoptions { diff --git a/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h b/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h index c77e6dc..681dc89 100644 --- a/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h +++ b/sysdeps/unix/sysv/linux/ia64/sys/ptrace.h @@ -146,12 +146,6 @@ enum __ptrace_request }; -/* Flag for PTRACE_LISTEN. */ -enum __ptrace_flags -{ - PTRACE_SEIZE_DEVEL = 0x80000000 -}; - /* pt_all_user_regs is used for PTRACE_GETREGS/PTRACE_SETREGS. */ struct __pt_all_user_regs { diff --git a/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h b/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h index ed1ed63..b2296fa 100644 --- a/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h +++ b/sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h @@ -133,12 +133,6 @@ enum __ptrace_request }; -/* Flag for PTRACE_LISTEN. */ -enum __ptrace_flags -{ - PTRACE_SEIZE_DEVEL = 0x80000000 -}; - /* Options set using PTRACE_SETOPTIONS. */ enum __ptrace_setoptions { diff --git a/sysdeps/unix/sysv/linux/s390/sys/ptrace.h b/sysdeps/unix/sysv/linux/s390/sys/ptrace.h index e913647..6c7d86b 100644 --- a/sysdeps/unix/sysv/linux/s390/sys/ptrace.h +++ b/sysdeps/unix/sysv/linux/s390/sys/ptrace.h @@ -210,12 +210,6 @@ enum __ptrace_request }; -/* Flag for PTRACE_LISTEN. */ -enum __ptrace_flags -{ - PTRACE_SEIZE_DEVEL = 0x80000000 -}; - /* Options set using PTRACE_SETOPTIONS. */ enum __ptrace_setoptions { diff --git a/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h b/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h index f605494..1fda17c 100644 --- a/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h +++ b/sysdeps/unix/sysv/linux/sparc/sys/ptrace.h @@ -215,12 +215,6 @@ enum __ptrace_request }; -/* Flag for PTRACE_LISTEN. */ -enum __ptrace_flags -{ - PTRACE_SEIZE_DEVEL = 0x80000000 -}; - /* Options set using PTRACE_SETOPTIONS. */ enum __ptrace_setoptions { diff --git a/sysdeps/unix/sysv/linux/sys/ptrace.h b/sysdeps/unix/sysv/linux/sys/ptrace.h index 1daadd1..6ddd972 100644 --- a/sysdeps/unix/sysv/linux/sys/ptrace.h +++ b/sysdeps/unix/sysv/linux/sys/ptrace.h @@ -163,12 +163,6 @@ enum __ptrace_request }; -/* Flag for PTRACE_LISTEN. */ -enum __ptrace_flags -{ - PTRACE_SEIZE_DEVEL = 0x80000000 -}; - /* Options set using PTRACE_SETOPTIONS. */ enum __ptrace_setoptions {