From patchwork Wed Aug 2 12:33:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Sahu X-Patchwork-Id: 796613 X-Patchwork-Delegate: computersforpeace@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TJKo2Gok"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="hELqwEiu"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="iGdK0JEb"; dkim=neutral (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="HZXT5Xl4"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xMtGT4gcmz9t0F for ; Wed, 2 Aug 2017 22:46:09 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=gHs8ATOuEUZl2P3ZiBsIFPWaGsb4sFIe8SNRUfvcDTo=; b=TJK o2GokSevjPrm6ImMHoDzacutn62aym1UxgM0XSLle6eUaL3iHzUecOt5px94PwyvhJidGpkOjyz6W aVtPyEaekrcdylX7ZVDCTAwN1wtS35kDG2vjrQ6e9/mZ5AsmhFi3YsJVOOnuwL9CLYoBOZDRSl7mo BF8sjK2gsa1wQh57X8nHzjWnO5k26EGmeR0aBv6noVoKuJgxNC9W0iriZewafWguS+9bm/n4KQVBV +stVTbTSV5SBS2EL33o0h3KKV259pn0TPe4dgHm00lVTN/2v0z2CBzn5fzSUcZp2NkLtrRUsmTdaJ CXJMAbi4xXiY+px5swb6lsL1xyjrQvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dct2L-0002n5-QO; Wed, 02 Aug 2017 12:46:05 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dct1x-0001cY-Ra for linux-mtd@bombadil.infradead.org; Wed, 02 Aug 2017 12:45:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Oxcnqzr4K9WoBdZsHea7ymGYcxj33EzytZWq5RuexEI=; b=hELqwEiukC6Mp18DmwdYJGWN7 MHDb8b+/gqalscPeBwzIlNGGq3/t4zgvmgcW2DANunzHF18EV9X9HsadIp36/OJnAsMZUJOfCj87y XKqMQvYi3P8CK/uydC944gCc9O2s04Yd4Z5tePl4VgZdKD3G/qvIaKXroCGgKyUaxHKtC4uhH62cJ dUQ44UwfhbZAxnW0/oKrImq7ObHY0ixK1h7BpW4Hp7zXgYNtPkrw/J6FZ0HgASzQiaguWdKZvSoA9 7Eh+dmL1+QCiDLbjeCCoMmp02J6LHd3Bt8lZQJZKJghg5tvWS9UBYg4g+eWxtmcDvzVuXYw3Dr0CJ nPKZCA5IA==; Received: from smtp.codeaurora.org ([198.145.29.96]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dcsqS-0005AZ-5o for linux-mtd@lists.infradead.org; Wed, 02 Aug 2017 12:33:50 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id F05B660884; Wed, 2 Aug 2017 12:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501677205; bh=Zpo1Uq4TsyuVwjtkLmdeT3yvj4Kx6eDq/PwzD+JZx1A=; h=From:To:Cc:Subject:Date:From; b=iGdK0JEbbL2q/hjO0JX5MN3f1M2KPVtySTuzubcgbQMWa1BNAr5/0T64DQN1wxVFI HA1rHdIhOVULPdHnw4lYfEW/UpzH+0CpnIs4WS3jTJCUrDi/RG56+COktYkYZmGQ+K 2w4/r9xwQZ/JN8oULkDxiHv5p75w2jpn4de7eZ4U= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: absahu@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 561B36080A; Wed, 2 Aug 2017 12:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501677202; bh=Zpo1Uq4TsyuVwjtkLmdeT3yvj4Kx6eDq/PwzD+JZx1A=; h=From:To:Cc:Subject:Date:From; b=HZXT5Xl494GWzcfsRFEV/JLuz4trNqItqVi9o6+9ojdLHfr/88vLUIL0x5xIsoSXH UFv0PuuDDAUrl60+M/3Jf/0EOQCdKVrChPjCAV0AZe6LRLdv9ppguIN2E1iVsT5Av4 cz9Gr9xXIMZjjzevpQS8D5KpFG5XbjCblMiwgWyI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 561B36080A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=absahu@codeaurora.org From: Abhishek Sahu To: dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr Subject: [PATCH] mtd: blkdevs: Fix mtd block write failure Date: Wed, 2 Aug 2017 18:03:05 +0530 Message-Id: <1501677185-1308-1-git-send-email-absahu@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170802_133348_360099_F44DFED4 X-CRM114-Status: GOOD ( 13.01 ) X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-4.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [198.145.29.96 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, Abhishek Sahu , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org All the MTD block write requests are failing with following error messages mkfs.ext4 /dev/mtdblock0 print_req_error: I/O error, dev mtdblock0, sector 0 Buffer I/O error on dev mtdblock0, logical block 0, lost async page write The control is going to default case after block write request because of missing return. Fixes: commit 2a842acab109 ("block: introduce new block status code type") Signed-off-by: Abhishek Sahu Acked-by: Boris Brezillon --- drivers/mtd/mtd_blkdevs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index f336a9b..9ec8f03 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -113,6 +113,7 @@ static blk_status_t do_blktrans_request(struct mtd_blktrans_ops *tr, for (; nsect > 0; nsect--, block++, buf += tr->blksize) if (tr->writesect(dev, block, buf)) return BLK_STS_IOERR; + return BLK_STS_OK; default: return BLK_STS_IOERR; }