From patchwork Wed Jan 19 23:01:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerald Pfeifer X-Patchwork-Id: 79623 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2502BB7143 for ; Thu, 20 Jan 2011 10:02:14 +1100 (EST) Received: (qmail 17658 invoked by alias); 19 Jan 2011 23:02:06 -0000 Received: (qmail 17650 invoked by uid 22791); 19 Jan 2011 23:02:04 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from relay03.pair.com (HELO relay03.pair.com) (209.68.5.17) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Wed, 19 Jan 2011 23:01:59 +0000 Received: (qmail 56986 invoked from network); 19 Jan 2011 23:01:56 -0000 Received: from 195.135.221.2 (HELO d95.suse.de) (195.135.221.2) by relay03.pair.com with SMTP; 19 Jan 2011 23:01:56 -0000 X-pair-Authenticated: 195.135.221.2 Date: Thu, 20 Jan 2011 00:01:58 +0100 (CET) From: Gerald Pfeifer To: libtool-patches@gnu.org cc: gcc-patches@gcc.gnu.org, Loren James Rittle Subject: [PATCH] libtool.m4: remove (incorrect) handling of FreeBSD 1.x Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org FreeBSD has been dead for way over a decade (FreeBSD 2.0 was released in 1994) and without support for dynamic linking and shared libraries I doubt there's a lot of software that would build at all. In anycase, libtool's handling code to handle it is buggy and will soon also match FreeBSD 10.0 and later which do support dynamic linking. I think it's best to simplify libtool.m4 per the patch below. I do not have libtool write access, so appreciate help. Let me know how to handle this for GCC, where this should go to HEAD, 4.5 and 4.4 at least. Thanks, Gerald 2011-01-19 Gerald Pfeifer * libtool.m4: Remove handling of freebsd1* which soon would incorrectly match FreeBSD 10.0. Index: libtool.m4 =================================================================== --- libtool.m4 (revision 168842) +++ libtool.m4 (working copy) @@ -2266,10 +2266,6 @@ shlibpath_var=LD_LIBRARY_PATH ;; -freebsd1*) - dynamic_linker=no - ;; - freebsd* | dragonfly*) # DragonFly does not have aout. When/if they implement a new # versioning mechanism, adjust this. @@ -4796,10 +4792,6 @@ _LT_TAGVAR(hardcode_shlibpath_var, $1)=no ;; - freebsd1*) - _LT_TAGVAR(ld_shlibs, $1)=no - ;; - # FreeBSD 2.2.[012] allows us to include c++rt0.o to get C++ constructor # support. Future versions do this automatically, but an explicit c++rt0.o # does not break anything, and helps significantly (at the cost of a little