| Message ID | 1501587558-21227-1-git-send-email-arvind.yadav.cs@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Boris Brezillon |
| Headers | show |
On Tue, 1 Aug 2017 17:09:18 +0530 Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > clk_prepare_enable() can fail here and we must check its return value. You're just a few days late, this one has already been proposed by Fabio [1] ;-). I'll queue other patches from this patchset. Thanks, Boris [1]https://patchwork.ozlabs.org/patch/789812/ > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/mtd/nand/vf610_nfc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > index 744ab10..db03d4f 100644 > --- a/drivers/mtd/nand/vf610_nfc.c > +++ b/drivers/mtd/nand/vf610_nfc.c > @@ -816,10 +816,13 @@ static int vf610_nfc_resume(struct device *dev) > { > struct mtd_info *mtd = dev_get_drvdata(dev); > struct vf610_nfc *nfc = mtd_to_nfc(mtd); > + int ret; > > pinctrl_pm_select_default_state(dev); > > - clk_prepare_enable(nfc->clk); > + ret = clk_prepare_enable(nfc->clk); > + if (ret) > + return ret; > > vf610_nfc_preinit_controller(nfc); > vf610_nfc_init_controller(nfc);
diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 744ab10..db03d4f 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -816,10 +816,13 @@ static int vf610_nfc_resume(struct device *dev) { struct mtd_info *mtd = dev_get_drvdata(dev); struct vf610_nfc *nfc = mtd_to_nfc(mtd); + int ret; pinctrl_pm_select_default_state(dev); - clk_prepare_enable(nfc->clk); + ret = clk_prepare_enable(nfc->clk); + if (ret) + return ret; vf610_nfc_preinit_controller(nfc); vf610_nfc_init_controller(nfc);
clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/mtd/nand/vf610_nfc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)