diff mbox

[U-Boot,v2,14/22] x86: coreboot: kconfig: Imply drivers that are useful

Message ID 1501421008-5737-15-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit 08fb85b2a46914e07d9c0bf92dfe4773f28ad1de
Delegated to: Bin Meng
Headers show

Commit Message

Bin Meng July 30, 2017, 1:23 p.m. UTC
U-Boot as coreboot payload can run on any x86 hardware ideally.
Let's imply some common drivers that are useful.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- imply more common drivers for coreboot

 arch/x86/cpu/coreboot/Kconfig  | 10 ++++++++++
 configs/coreboot-x86_defconfig |  5 -----
 2 files changed, 10 insertions(+), 5 deletions(-)

Comments

Simon Glass Aug. 1, 2017, 9:12 a.m. UTC | #1
On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> U-Boot as coreboot payload can run on any x86 hardware ideally.
> Let's imply some common drivers that are useful.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - imply more common drivers for coreboot
>
>  arch/x86/cpu/coreboot/Kconfig  | 10 ++++++++++
>  configs/coreboot-x86_defconfig |  5 -----
>  2 files changed, 10 insertions(+), 5 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng Aug. 1, 2017, 12:23 p.m. UTC | #2
On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> U-Boot as coreboot payload can run on any x86 hardware ideally.
>> Let's imply some common drivers that are useful.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - imply more common drivers for coreboot
>>
>>  arch/x86/cpu/coreboot/Kconfig  | 10 ++++++++++
>>  configs/coreboot-x86_defconfig |  5 -----
>>  2 files changed, 10 insertions(+), 5 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/arch/x86/cpu/coreboot/Kconfig b/arch/x86/cpu/coreboot/Kconfig
index 9820651..31fe17b 100644
--- a/arch/x86/cpu/coreboot/Kconfig
+++ b/arch/x86/cpu/coreboot/Kconfig
@@ -3,6 +3,16 @@  if TARGET_COREBOOT
 config SYS_COREBOOT
 	bool
 	default y
+	imply ENV_IS_NOWHERE
+	imply E1000
+	imply ICH_SPI
+	imply MMC
+	imply MMC_PCI
+	imply MMC_SDHCI
+	imply MMC_SDHCI_SDMA
+	imply SPI_FLASH
+	imply SYS_NS16550
+	imply VIDEO_COREBOOT
 	imply CMD_CBFS
 	imply FS_CBFS
 
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index 68406ba..ef5d75b 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -4,7 +4,6 @@  CONFIG_TARGET_COREBOOT=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMLS is not set
@@ -32,15 +31,11 @@  CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_E1000=y
-CONFIG_SYS_NS16550=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_COREBOOT=y
 CONFIG_CONSOLE_SCROLL_LINES=5
 CONFIG_TPM=y