From patchwork Sat Jul 29 18:07:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 795262 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="DIfk8ozX"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xKYbX6m3xz9sMN for ; Sun, 30 Jul 2017 04:07:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbdG2SHv (ORCPT ); Sat, 29 Jul 2017 14:07:51 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:37277 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbdG2SHu (ORCPT ); Sat, 29 Jul 2017 14:07:50 -0400 Received: by mail-lf0-f45.google.com with SMTP id m86so94115261lfi.4 for ; Sat, 29 Jul 2017 11:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:user-agent:date:to:cc:subject:mime-version :content-disposition; bh=1gi3yX9aLLYlmdoIhztQCIxKWzHayzDpfSf++JavcBQ=; b=DIfk8ozXlTZyCcGgcTT11NjkTrw7Wnz8Dz+AY/oyw8ANMQSQW+4A+GXveuzMbZQy0D WnA7KRVNPvp2zIl7LR5N5lMRbqNmd+eRQVCchGo0QdJPWuBasUb++Pr7rcW2se+jU2k2 Q+Q4niJEnbKXiZurWnXuCBZcxPD/1UP/1ddXdOsrKTqbJ6V7a3yzgCBT/Lehdyl2sq5J bpreApMvWO9NHpb+4lOAmYqwfCdLOJbMJO3Pz/fGRtykEEIPgM/Flv8mF3JPE+yZN1nf 0OfRrO9pjUv/iCw9FIhPn0rrETCTpkvVU8Tb2tYrLsFx2dpWTl9s25wqmMTmMRYoWtQ9 OIYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:user-agent:date:to:cc:subject :mime-version:content-disposition; bh=1gi3yX9aLLYlmdoIhztQCIxKWzHayzDpfSf++JavcBQ=; b=m2BWJXqUfNTUxYVw3nvztOQ6jO38fQwJdXBJpHs6gLxDxjwM9zo5LhhlqdldJPe01J ylNQtZu0r8uGx7XdFwlLyz+3EkFK4RTkrUBpvqGGfuM1GucP/ScCJGqoXMxg7m3jfTex Ttgfg2+hgo/AaiwyIaxgKU5bd2zLV6xwPkii8hb3oBvMjc8AVvZP/UnYV9X3DI4zTR4r FpWAJhrq3WUb9eCN5wkWOo8vAjL/gT1955kIbbkiAUXylReVGN6SCFtbkwhWpY6gix1z 7W8njDHBSaJ+wPwOyECAeGVWg7kpWX+9D4M5FQdWEbzqiG31GHCxkYLcuDG9ovSItvTv ltmQ== X-Gm-Message-State: AIVw113XLWcB1ocr6ZQIovfmkHNPUZJp1Hnm+DtoGB+gxd4aea/7V0ur nVtAejfLePWI4YTg X-Received: by 10.25.151.19 with SMTP id z19mr4211472lfd.134.1501351669211; Sat, 29 Jul 2017 11:07:49 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.85.243]) by smtp.gmail.com with ESMTPSA id h4sm2944759lji.87.2017.07.29.11.07.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Jul 2017 11:07:47 -0700 (PDT) From: Sergei Shtylyov X-Google-Original-From: "Sergei Shtylyov" Received: by wasted.cogentembedded.com (sSMTP sendmail emulation); Sat, 29 Jul 2017 21:07:44 +0300 Message-Id: <20170729180744.873303067@cogentembedded.com> User-Agent: quilt/0.64 Date: Sat, 29 Jul 2017 21:07:07 +0300 To: Patrice Chotard , Linus Walleij , linux-gpio@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Sergei Shtylyov Subject: [PATCH] pinctrl-st: fix of_irq_to_resource() result check MIME-Version: 1.0 Content-Disposition: inline; filename=pinctrl-st-fix-of_irq_to_resource-result-check.patch Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org of_irq_to_resource() has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up. Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()") Signed-off-by: Sergei Shtylyov --- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c =================================================================== --- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c +++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c @@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru * [irqN]----> [gpio-bank (n)] */ - if (of_irq_to_resource(np, 0, &irq_res)) { + if (of_irq_to_resource(np, 0, &irq_res) > 0) { gpio_irq = irq_res.start; gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip, gpio_irq, st_gpio_irq_handler);