| Message ID | 20170728053610.15770-6-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3b472d7a09..ece02522be 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -278,6 +278,7 @@ S: Supported > F: */kvm.* > F: accel/kvm/ > F: include/sysemu/kvm*.h > +F: linux-headers/asm-*/kvm*.h The linux-headers are not really maintained by the QEMU project - so I guess we do not need an entry for these? Thomas
On 28/07/2017 09:00, Thomas Huth wrote: > On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 3b472d7a09..ece02522be 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -278,6 +278,7 @@ S: Supported >> F: */kvm.* >> F: accel/kvm/ >> F: include/sysemu/kvm*.h >> +F: linux-headers/asm-*/kvm*.h > > The linux-headers are not really maintained by the QEMU project - so I > guess we do not need an entry for these? Actually I agree with the patch. I'd like to be CCed on update-linux-headers patches, and this achieves it. :) Paolo
On Fri, 28 Jul 2017 13:51:14 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote: > On 28/07/2017 09:00, Thomas Huth wrote: > > On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > >> --- > >> MAINTAINERS | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 3b472d7a09..ece02522be 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -278,6 +278,7 @@ S: Supported > >> F: */kvm.* > >> F: accel/kvm/ > >> F: include/sysemu/kvm*.h > >> +F: linux-headers/asm-*/kvm*.h > > > > The linux-headers are not really maintained by the QEMU project - so I > > guess we do not need an entry for these? > > Actually I agree with the patch. I'd like to be CCed on > update-linux-headers patches, and this achieves it. :) But would it not a better idea to add an entry for all headers touched by update-linux-headers, then?
On 28/07/2017 13:56, Cornelia Huck wrote: > On Fri, 28 Jul 2017 13:51:14 +0200 > Paolo Bonzini <pbonzini@redhat.com> wrote: > >> On 28/07/2017 09:00, Thomas Huth wrote: >>> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>> --- >>>> MAINTAINERS | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 3b472d7a09..ece02522be 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -278,6 +278,7 @@ S: Supported >>>> F: */kvm.* >>>> F: accel/kvm/ >>>> F: include/sysemu/kvm*.h >>>> +F: linux-headers/asm-*/kvm*.h >>> >>> The linux-headers are not really maintained by the QEMU project - so I >>> guess we do not need an entry for these? >> >> Actually I agree with the patch. I'd like to be CCed on >> update-linux-headers patches, and this achieves it. :) > > But would it not a better idea to add an entry for all headers touched > by update-linux-headers, then? One thing doesn't exclude the other. That entry would also list the script itself and linux-headers. KVM, VFIO and virtio patterns can only list the files they care about. Migration could list userfaultfd, possibly. And there's also include/standard-headers/, which includes PCI and input subsystem files... It has to be perfected, but it's a good idea. Paolo Paolo
On Fri, 28 Jul 2017 13:59:08 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote: > On 28/07/2017 13:56, Cornelia Huck wrote: > > On Fri, 28 Jul 2017 13:51:14 +0200 > > Paolo Bonzini <pbonzini@redhat.com> wrote: > > > >> On 28/07/2017 09:00, Thomas Huth wrote: > >>> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: > >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > >>>> --- > >>>> MAINTAINERS | 1 + > >>>> 1 file changed, 1 insertion(+) > >>>> > >>>> diff --git a/MAINTAINERS b/MAINTAINERS > >>>> index 3b472d7a09..ece02522be 100644 > >>>> --- a/MAINTAINERS > >>>> +++ b/MAINTAINERS > >>>> @@ -278,6 +278,7 @@ S: Supported > >>>> F: */kvm.* > >>>> F: accel/kvm/ > >>>> F: include/sysemu/kvm*.h > >>>> +F: linux-headers/asm-*/kvm*.h > >>> > >>> The linux-headers are not really maintained by the QEMU project - so I > >>> guess we do not need an entry for these? > >> > >> Actually I agree with the patch. I'd like to be CCed on > >> update-linux-headers patches, and this achieves it. :) > > > > But would it not a better idea to add an entry for all headers touched > > by update-linux-headers, then? > > One thing doesn't exclude the other. That entry would also list the > script itself and linux-headers. KVM, VFIO and virtio patterns can only > list the files they care about. Migration could list userfaultfd, > possibly. And there's also include/standard-headers/, which includes > PCI and input subsystem files... It has to be perfected, but it's a > good idea. Personally, I'm not really a fan. If something is changed in one of the headers, it implies that either it has already been changed in the original headers in Linux (and I will have seen it then), or that someone is sending a preliminary patch (and I should hope that I'm already cc:ed for the changes that this headers change is for then). It does not really hurt, but it feels wrong.
On 28/07/2017 14:13, Cornelia Huck wrote: >>> But would it not a better idea to add an entry for all headers touched >>> by update-linux-headers, then? >> >> One thing doesn't exclude the other. That entry would also list the >> script itself and linux-headers. KVM, VFIO and virtio patterns can only >> list the files they care about. Migration could list userfaultfd, >> possibly. And there's also include/standard-headers/, which includes >> PCI and input subsystem files... It has to be perfected, but it's a >> good idea. > > Personally, I'm not really a fan. If something is changed in one of the > headers, it implies that either it has already been changed in the > original headers in Linux (and I will have seen it then), or that > someone is sending a preliminary patch (and I should hope that I'm > already cc:ed for the changes that this headers change is for then). It > does not really hurt, but it feels wrong. Sometime people pull changes too early, or otherwise I want to comment on the timing of the change... I don't know, I already get too much qemu-devel email. :) Paolo
On Fri, 28 Jul 2017 14:25:08 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote: > Sometime people pull changes too early, or otherwise I want to comment > on the timing of the change... Might be helpful to add magic to checkpatch to verify that any headers change is done via running the script against a specified Linux version. (This is beyond my non-existing perl skills, unfortunately.) > I don't know, I already get too much > qemu-devel email. :) I can certainly agree with that statement :)
diff --git a/MAINTAINERS b/MAINTAINERS index 3b472d7a09..ece02522be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -278,6 +278,7 @@ S: Supported F: */kvm.* F: accel/kvm/ F: include/sysemu/kvm*.h +F: linux-headers/asm-*/kvm*.h ARM M: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)