[linux,dev-4.10] ARM: dts: Romulus: Identify LED is too active

Submitted by Chris Austen on July 27, 2017, 6:50 p.m.

Details

Message ID 1501181400-31373-1-git-send-email-austenc@us.ibm.com
State Needs Review / ACK
Headers show

Commit Message

Chris Austen July 27, 2017, 6:50 p.m.
Identify LED is coming on ever boot.  This is because
it should have been set to ACTIVE_HIGH

Signed-Off-By: Chris Austen <austencj@yahoo.com>
---
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Milton Miller July 27, 2017, 11:40 p.m.
-----"openbmc" <openbmc-bounces+miltonm=us.ibm.com@lists.ozlabs.org> wrote: -----

>To: openbmc@lists.ozlabs.org, joel@jms.id.au
>From: causten 
>Sent by: "openbmc" 
>Date: 07/27/2017 01:50PM
>Cc: Chris Austen <austencj@yahoo.com>
>Subject: [PATCH linux dev-4.10] ARM: dts: Romulus: Identify LED is
>too active
>
>Identify LED is coming on ever boot.  This is because

every boot?

>it should have been set to ACTIVE_HIGH
>
>Signed-Off-By: Chris Austen <austencj@yahoo.com>
>---
> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>index a9e3615..45a3c99 100644
>--- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>+++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>@@ -35,7 +35,7 @@
> 		};
> 
> 		identify {
>-			gpios = <&gpio ASPEED_GPIO(N, 4) GPIO_ACTIVE_LOW>;
>+			gpios = <&gpio ASPEED_GPIO(N, 4) GPIO_ACTIVE_HIGH>;
> 		};
> 
> 		power {
>-- 
>2.7.4
>
>

Patch hide | download patch | download mbox

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
index a9e3615..45a3c99 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
@@ -35,7 +35,7 @@ 
 		};
 
 		identify {
-			gpios = <&gpio ASPEED_GPIO(N, 4) GPIO_ACTIVE_LOW>;
+			gpios = <&gpio ASPEED_GPIO(N, 4) GPIO_ACTIVE_HIGH>;
 		};
 
 		power {