| Message ID | 20170727102951.26964-1-sathya.perla@broadcom.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sathya Perla <sathya.perla@broadcom.com> Date: Thu, 27 Jul 2017 06:29:51 -0400 > bnxt_en depends on MAY_USE_DEVLINK; this is used to force bnxt_en > to be =m when DEVLINK is =m. > > Now, bnxt_re selects bnxt_en. Unless bnxt_re also explicitly calls > out dependency on MAY_USE_DEVLINK, Kconfig does not force bnxt_re > to be =m when DEVLINK is =m, causing the following error: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function > `bnxt_dl_register': > bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' > bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink_register' > bnxt_vfr.c:(.text+0x14e0): undefined reference to `devlink_free' > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function > `bnxt_dl_unregister': > bnxt_vfr.c:(.text+0x1534): undefined reference to `devlink_unregister' > bnxt_vfr.c:(.text+0x153c): undefined reference to `devlink_free' > > Fix this by adding MAY_USE_DEVLINK dependency in bnxt_re. > > Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors") > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Sathya Perla <sathya.perla@broadcom.com> Applied.
diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig index 19982a4..18f5ed0 100644 --- a/drivers/infiniband/hw/bnxt_re/Kconfig +++ b/drivers/infiniband/hw/bnxt_re/Kconfig @@ -1,6 +1,7 @@ config INFINIBAND_BNXT_RE tristate "Broadcom Netxtreme HCA support" depends on ETHERNET && NETDEVICES && PCI && INET && DCB + depends on MAY_USE_DEVLINK select NET_VENDOR_BROADCOM select BNXT ---help---
bnxt_en depends on MAY_USE_DEVLINK; this is used to force bnxt_en to be =m when DEVLINK is =m. Now, bnxt_re selects bnxt_en. Unless bnxt_re also explicitly calls out dependency on MAY_USE_DEVLINK, Kconfig does not force bnxt_re to be =m when DEVLINK is =m, causing the following error: drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register': bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink_register' bnxt_vfr.c:(.text+0x14e0): undefined reference to `devlink_free' drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_unregister': bnxt_vfr.c:(.text+0x1534): undefined reference to `devlink_unregister' bnxt_vfr.c:(.text+0x153c): undefined reference to `devlink_free' Fix this by adding MAY_USE_DEVLINK dependency in bnxt_re. Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors") Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sathya Perla <sathya.perla@broadcom.com> --- drivers/infiniband/hw/bnxt_re/Kconfig | 1 + 1 file changed, 1 insertion(+)