| Message ID | 1501137036-20155-1-git-send-email-vivek.gautam@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 07/26/2017 11:30 PM, Vivek Gautam wrote: > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > index d3879a4e8076..3b04ca63c31e 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > @@ -8,6 +8,23 @@ > reg = <0x2 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > + > + pmi8994_gpios: gpios@c000 { > + compatible = "qcom,pmi8994-gpio"; Please also include the generic "qcom,spmi-gpio" compatible. We really don't need to add the "qcom,pmi8994-gpio" one to the driver right now so I would leave that out of the driver but leave it here in the dtsi file of course.
On 07/26/2017 11:30 PM, Vivek Gautam wrote: > Update the bindings doc and driver for pmi8994-gpio devices. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > > - Have been using this patch-set on db820c [1] for extcon with > usb controller. The usb controller uses one of these gpios > for usb-id/vbus detection. > > [1] https://github.com/boddob/linux/tree/for-qcomlt/4.13rc2-merged > > Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++ > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > index 8d893a874634..74932318d41d 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > @@ -15,6 +15,7 @@ PMIC's from Qualcomm. > "qcom,pm8921-gpio" > "qcom,pm8941-gpio" > "qcom,pm8994-gpio" > + "qcom,pmi8994-gpio" pmi comes after pma. Please sort alphabetically. > "qcom,pma8084-gpio" > > And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio" > @@ -84,6 +85,7 @@ to specify in a pin configuration subnode: > gpio1-gpio44 for pm8921 > gpio1-gpio36 for pm8941 > gpio1-gpio22 for pm8994 > + gpio1-gpio10 for pmi8994 > gpio1-gpio22 for pma8084 > > - function: > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index 664b641fd776..bf0a6438424b 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -799,6 +799,7 @@ static int pmic_gpio_remove(struct platform_device *pdev) > { .compatible = "qcom,pm8916-gpio" }, /* 4 GPIO's */ > { .compatible = "qcom,pm8941-gpio" }, /* 36 GPIO's */ > { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */ > + { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */ As stated on the other patch, please drop this hunk. > { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */ > { .compatible = "qcom,spmi-gpio" }, /* Generic */ > { },
On Fri, Jul 28, 2017 at 2:30 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 07/26/2017 11:30 PM, Vivek Gautam wrote: >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi >> index d3879a4e8076..3b04ca63c31e 100644 >> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi >> @@ -8,6 +8,23 @@ >> reg = <0x2 SPMI_USID>; >> #address-cells = <1>; >> #size-cells = <0>; >> + >> + pmi8994_gpios: gpios@c000 { >> + compatible = "qcom,pmi8994-gpio"; > > > Please also include the generic "qcom,spmi-gpio" compatible. We really > don't need to add the "qcom,pmi8994-gpio" one to the driver right now so > I would leave that out of the driver but leave it here in the dtsi file > of course. Sure, will add the "qcom,spmi-gpio" compatible as well, and will drop the "qcom,pmi8994-gpio" from the driver. Thanks. regards Vivek > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 27, 2017 at 12:00:35PM +0530, Vivek Gautam wrote: > Update the bindings doc and driver for pmi8994-gpio devices. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > > - Have been using this patch-set on db820c [1] for extcon with > usb controller. The usb controller uses one of these gpios > for usb-id/vbus detection. > > [1] https://github.com/boddob/linux/tree/for-qcomlt/4.13rc2-merged > > Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++ > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + > 2 files changed, 3 insertions(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt index 8d893a874634..74932318d41d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt @@ -15,6 +15,7 @@ PMIC's from Qualcomm. "qcom,pm8921-gpio" "qcom,pm8941-gpio" "qcom,pm8994-gpio" + "qcom,pmi8994-gpio" "qcom,pma8084-gpio" And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio" @@ -84,6 +85,7 @@ to specify in a pin configuration subnode: gpio1-gpio44 for pm8921 gpio1-gpio36 for pm8941 gpio1-gpio22 for pm8994 + gpio1-gpio10 for pmi8994 gpio1-gpio22 for pma8084 - function: diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index 664b641fd776..bf0a6438424b 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -799,6 +799,7 @@ static int pmic_gpio_remove(struct platform_device *pdev) { .compatible = "qcom,pm8916-gpio" }, /* 4 GPIO's */ { .compatible = "qcom,pm8941-gpio" }, /* 36 GPIO's */ { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */ + { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */ { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */ { .compatible = "qcom,spmi-gpio" }, /* Generic */ { },
Update the bindings doc and driver for pmi8994-gpio devices. Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> --- - Have been using this patch-set on db820c [1] for extcon with usb controller. The usb controller uses one of these gpios for usb-id/vbus detection. [1] https://github.com/boddob/linux/tree/for-qcomlt/4.13rc2-merged Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++ drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + 2 files changed, 3 insertions(+)