| Message ID | 4D3693CA.40508@cn.fujitsu.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Shan Wei <shanwei@cn.fujitsu.com> Date: Wed, 19 Jan 2011 15:33:30 +0800 > The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK, > not SCTP_DELAYED_ACK. > > Reference: > 8.1.19. Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK) > （http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25) > > > Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> You can't make this change, you'll break applications using the existing definition. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller wrote, at 01/19/2011 03:39 PM: > From: Shan Wei <shanwei@cn.fujitsu.com> > Date: Wed, 19 Jan 2011 15:33:30 +0800 > >> The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK, >> not SCTP_DELAYED_ACK. >> >> Reference: >> 8.1.19. Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK) >> （http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25) >> >> >> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> > > You can't make this change, you'll break applications using the > existing definition. No documents guide user to use SCTP_DELAYED_ACK option. I double that there is no applications using this option. If, there be. How about keeping this be concomitant with SCTP_DELAYED_SACK?
> David Miller wrote, at 01/19/2011 03:39 PM: >> From: Shan Wei <shanwei@cn.fujitsu.com> >> Date: Wed, 19 Jan 2011 15:33:30 +0800 >> >>> The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK, >>> not SCTP_DELAYED_ACK. >>> >>> Reference: >>> 8.1.19. Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK) >>> （http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25) >>> >>> >>> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> >> You can't make this change, you'll break applications using the >> existing definition. > No documents guide user to use SCTP_DELAYED_ACK option. > I double that there is no applications using this option. > > If, there be. How about keeping this be concomitant with SCTP_DELAYED_SACK? You sould do as the same as the following patch, which has fixed the same problem of lksctp-tools, but not lksctp: http://git.kernel.org/?p=linux/kernel/git/vxy/lksctp-tools.git;a=commit;h=ecdc6c0d3c3e40843916427923a45a93d748c1c6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/sctp/user.h b/include/net/sctp/user.h index 2b2769c..74e10d6 100644 --- a/include/net/sctp/user.h +++ b/include/net/sctp/user.h @@ -77,7 +77,7 @@ typedef __s32 sctp_assoc_t; #define SCTP_STATUS 14 #define SCTP_GET_PEER_ADDR_INFO 15 #define SCTP_DELAYED_ACK_TIME 16 -#define SCTP_DELAYED_ACK SCTP_DELAYED_ACK_TIME +#define SCTP_DELAYED_SACK SCTP_DELAYED_ACK_TIME #define SCTP_CONTEXT 17 #define SCTP_FRAGMENT_INTERLEAVE 18 #define SCTP_PARTIAL_DELIVERY_POINT 19 /* Set/Get partial delivery point */ diff --git a/net/sctp/socket.c b/net/sctp/socket.c index a09b0dd..8e02550 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -3428,7 +3428,7 @@ SCTP_STATIC int sctp_setsockopt(struct sock *sk, int level, int optname, retval = sctp_setsockopt_peer_addr_params(sk, optval, optlen); break; - case SCTP_DELAYED_ACK: + case SCTP_DELAYED_SACK: retval = sctp_setsockopt_delayed_ack(sk, optval, optlen); break; case SCTP_PARTIAL_DELIVERY_POINT: @@ -5333,7 +5333,7 @@ SCTP_STATIC int sctp_getsockopt(struct sock *sk, int level, int optname, retval = sctp_getsockopt_peer_addr_params(sk, len, optval, optlen); break; - case SCTP_DELAYED_ACK: + case SCTP_DELAYED_SACK: retval = sctp_getsockopt_delayed_ack(sk, len, optval, optlen); break;
The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK, not SCTP_DELAYED_ACK. Reference: 8.1.19. Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK) （http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25) Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> --- include/net/sctp/user.h | 2 +- net/sctp/socket.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)