| Message ID | 20170727024224.22900-13-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
Le 27/07/2017 à 04:42, Philippe Mathieu-Daudé a écrit : > linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value > if (*host_rt_dev_ptr != 0) { > ^~~~~~~~~~~~~~~~ > > Reported-by: Clang Static Analyzer > Suggested-by: Laurent Vivier <lvivier@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Laurent Vivier <laurent@vivier.eu> > --- > linux-user/syscall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 003943b736..71d45a9963 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -5573,6 +5573,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp, > field_types, THUNK_HOST); > } > unlock_user(argptr, arg, 0); > + assert(host_rt_dev_ptr); > > ret = get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp)); > if (*host_rt_dev_ptr != 0) { >
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 003943b736..71d45a9963 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5573,6 +5573,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp, field_types, THUNK_HOST); } unlock_user(argptr, arg, 0); + assert(host_rt_dev_ptr); ret = get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp)); if (*host_rt_dev_ptr != 0) {
linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value if (*host_rt_dev_ptr != 0) { ^~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Suggested-by: Laurent Vivier <lvivier@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+)