| Message ID | 20170727024224.22900-11-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
On 07/26/2017 07:42 PM, Philippe Mathieu-Daudé wrote: > db3d7945ae extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, 5] > > target/m68k/translate.c:1323:70: warning: identical expressions on both sides of logical operator > if (op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL || > op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL) { > ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ^ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> > Reviewed-by: Laurent Vivier<laurent@vivier.eu> > --- > target/m68k/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <rth@twiddle.net> r~
diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ada2a91b64..be24355080 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1321,7 +1321,7 @@ static void gen_cc_cond(DisasCompare *c, DisasContext *s, int cond) case 5: /* CS (C) */ /* Some cases fold C into X. */ if (op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL || - op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL) { + op == CC_OP_SUBB || op == CC_OP_SUBW || op == CC_OP_SUBL) { tcond = TCG_COND_NE; c->v1 = QREG_CC_X; goto done;
db3d7945ae extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, 5] target/m68k/translate.c:1323:70: warning: identical expressions on both sides of logical operator if (op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL || op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL) { ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Laurent Vivier <laurent@vivier.eu> --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)